Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1C8ECAAD3 for ; Thu, 1 Sep 2022 22:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234471AbiIAWZA (ORCPT ); Thu, 1 Sep 2022 18:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233931AbiIAWYg (ORCPT ); Thu, 1 Sep 2022 18:24:36 -0400 Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97F62A833B for ; Thu, 1 Sep 2022 15:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1662070873; x=1693606873; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=erSoxjQKGP3fPOV61w051dVsCqkqx5Rj1Dn8Q/nY93s=; b=KMiCE6YpLWnlMBHhLf5fqz23fEvPLcCl65eQ9pZTM40uQkDjz8d5L33N 6cl400qpxrJyWwwz2lqf/7iKVqtdu2TxeJdMr5y+0TFCyenrgh0LTqr9y L3kzltXzakB7WpsjS7qIcJH1DbYiX9f2qezK9/CWYojdKkEdkLUWrYAWB E=; X-IronPort-AV: E=Sophos;i="5.93,281,1654560000"; d="scan'208";a="1050492615" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-90d70b14.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 22:19:31 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-90d70b14.us-east-1.amazon.com (Postfix) with ESMTPS id 8D0B3C0916; Thu, 1 Sep 2022 22:19:28 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 1 Sep 2022 22:19:27 +0000 Received: from 88665a182662.ant.amazon.com (10.43.160.191) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.12; Thu, 1 Sep 2022 22:19:25 +0000 From: Kuniyuki Iwashima To: CC: , , , , , Subject: Re: [PATCH v3 net-next 3/5] tcp: Access &tcp_hashinfo via net. Date: Thu, 1 Sep 2022 15:19:17 -0700 Message-ID: <20220901221917.15331-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220901144936.4aaef04b@kernel.org> References: <20220901144936.4aaef04b@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.160.191] X-ClientProxiedBy: EX13D20UWA003.ant.amazon.com (10.43.160.97) To EX19D004ANA001.ant.amazon.com (10.37.240.138) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Thu, 1 Sep 2022 14:49:36 -0700 > On Thu, 1 Sep 2022 14:25:20 -0700 Kuniyuki Iwashima wrote: > > > I looks to me that the above chunks are functionally a no-op and I > > > think that omitting the 2 drivers from the v2: > > > > > > https://lore.kernel.org/netdev/20220829161920.99409-4-kuniyu@amazon.com/ > > > > > > should break mlx5/nfp inside a netns. I don't understand why including > > > the above and skipping the latters?!? I guess is a question mostly for > > > Eric :) > > > > My best guess is that it's ok unless it does not touch TCP stack deeply > > and if it does, the driver developer must catch up with the core changes > > not to burden maintainers...? > > > > If so, I understand that take. OTOH, I also don't want to break anything > > when we know the change would do. > > > > So, I'm fine to either stay as is or add the change in v4 again. > > FWIW I share Paolo's concern. If we don't want the drivers to be > twiddling with the hash tables we should factor out that code to > a common helper in net/tls/ That makes sense. For the moment, I'll add the changes back in v4.