Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E18CC6FA82 for ; Fri, 2 Sep 2022 19:56:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2CA48410B; Fri, 2 Sep 2022 21:56:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="vA9Id96P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9F03E8410B; Fri, 2 Sep 2022 21:56:15 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 513E6826AD for ; Fri, 2 Sep 2022 21:56:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B06760EB1; Fri, 2 Sep 2022 19:56:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAE17C433C1; Fri, 2 Sep 2022 19:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662148570; bh=7XeK/ZQMoZNAtzfv337X5Nd+AoFB7SSU/g7e7A55wUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vA9Id96PySed5WuSf8zvU/57eiIQVRw8tZLGKaZOeDmAazPSVXIlHcD17iQZikGPC lLc93a0ANeDo4JVMV2jIimV/t5xEuItULBHMEibY9fIsOBR8fTrnl34YwFZWKWw2Dx TPRKV0h3UyZfFCPPiv6JY0cuSC7NpkGSLlxu7D8Q/grUNwV9ibjJIeNeOHBZIs2Pti 29cr8ySBOhw6eG97JagwN1Qouc3sA1dws+3DkTkCDBet/zfGdsbscu6tF7OmSaLs4v RVjUylfjE4+p3hc0VdVWkUU98Cu1Up+hwFjW/PeQY/aU/iljsuO/Z8c+tWQQ6Wf+eN PZkjno8WkK0hA== Received: by pali.im (Postfix) id DE6E17EA; Fri, 2 Sep 2022 21:56:07 +0200 (CEST) Date: Fri, 2 Sep 2022 21:56:07 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stefan Roese Cc: u-boot@lists.denx.de Subject: Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks Message-ID: <20220902195607.shanguavmr43psy3@pali> References: <20220802100655.17965-1-pali@kernel.org> <442ade87-f39e-1194-a4d8-266d1cd023fc@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <442ade87-f39e-1194-a4d8-266d1cd023fc@denx.de> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote: > On 02.08.22 12:06, Pali Rohár wrote: > > Remove identify wrapper functions. > > > > Signed-off-by: Pali Rohár > > Reviewed-by: Stefan Roese Any more comments? Or could it be merged? > Thanks, > Stefan > > > --- > > drivers/gpio/gpio-rcar.c | 15 ++------------- > > 1 file changed, 2 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > > index 138801850d3e..ba00bb459679 100644 > > --- a/drivers/gpio/gpio-rcar.c > > +++ b/drivers/gpio/gpio-rcar.c > > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) > > return GPIOF_INPUT; > > } > > -static int rcar_gpio_request(struct udevice *dev, unsigned offset, > > - const char *label) > > -{ > > - return pinctrl_gpio_request(dev, offset, label); > > -} > > - > > -static int rcar_gpio_free(struct udevice *dev, unsigned offset) > > -{ > > - return pinctrl_gpio_free(dev, offset); > > -} > > - > > static const struct dm_gpio_ops rcar_gpio_ops = { > > - .request = rcar_gpio_request, > > - .rfree = rcar_gpio_free, > > + .request = pinctrl_gpio_request, > > + .rfree = pinctrl_gpio_free, > > .direction_input = rcar_gpio_direction_input, > > .direction_output = rcar_gpio_direction_output, > > .get_value = rcar_gpio_get_value, > > Viele Grüße, > Stefan Roese > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de