Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF8EECAAD3 for ; Wed, 14 Sep 2022 14:25:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8C68D0002; Wed, 14 Sep 2022 10:25:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 188148D0001; Wed, 14 Sep 2022 10:25:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 050648D0002; Wed, 14 Sep 2022 10:25:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EA2518D0001 for ; Wed, 14 Sep 2022 10:25:28 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C5EC1AAFC9 for ; Wed, 14 Sep 2022 14:25:28 +0000 (UTC) X-FDA: 79910913936.10.F7479B6 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 870304009E for ; Wed, 14 Sep 2022 14:25:28 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id r23so5884996pgr.6 for ; Wed, 14 Sep 2022 07:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=hdSD8tJb664Fr8pl0NO+kf8L2z4TDzTohEl0wY+gzYc=; b=W15M6v323Iel/iK6eFB5fJmsZj9UgNfzHvij6SGJNxbTuWnqIovbfOPRNq3jRPbdSH 0oyEjnHDaHKU56TfRiVWrQ8OK4AkxXGpiH4n2ZY07EN7lKx2rh0fiNP/u3aArQnoqFKx /juLxkWKnaA99ijCsePo3+Yh3Qbi1J71jaTZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=hdSD8tJb664Fr8pl0NO+kf8L2z4TDzTohEl0wY+gzYc=; b=YaKYffZKQVKYrHAYNOibRttedp2QFHUAUjc2ZZJ3320rGfZXUiVCJorunJ2fmbWEYM Zvh58nmVKZL/86jX4VzyLLSaaUF69awbgyi9qXbtegYzUFj6VRpTNUkYM/VQpimDyvL1 KL0yN0nWoESyMVyq8YZIBgsWb2MuLNmqjHYVhU/vd7oJBRLScI29cq1HvvUKQdIHyMTG +7kurQm+7W0f6floNwRUL4oHUeXZkMiEsSy0EleQlIHKi3JQJmtSbO2DG1lu/SZIj/fN xU6OuEBcAGnGHfXJoZVvQZ2EbmTs1l7N7pRCHUZOdfmNewxIpsRkrTMeUwFvNTLxvnp3 yNCQ== X-Gm-Message-State: ACgBeo0lrRUNeDEy9TXfcrujUO7a9NryMgZ95AfXpWAFVSZEWEEFQH56 iWzWqQVTeNVFRtawxwfo+GqikA== X-Google-Smtp-Source: AA6agR6En5JhEov24TDmvwIDj3j1j5VGKylIZcdmOMCIY6+KUUuqabgXpORLodRAghUj4fpa4NlpVw== X-Received: by 2002:aa7:97b4:0:b0:547:f861:1fc3 with SMTP id d20-20020aa797b4000000b00547f8611fc3mr2784496pfq.42.1663165527599; Wed, 14 Sep 2022 07:25:27 -0700 (PDT) Received: from fastly.com (c-73-223-190-181.hsd1.ca.comcast.net. [73.223.190.181]) by smtp.gmail.com with ESMTPSA id e19-20020a656bd3000000b004351358f056sm9642274pgw.85.2022.09.14.07.25.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2022 07:25:27 -0700 (PDT) Date: Wed, 14 Sep 2022 07:25:24 -0700 From: Joe Damato To: Dave Hansen Cc: x86@kernel.org, linux-mm@kvack.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 1/1] mm: Add per-task struct tlb counters Message-ID: <20220914142523.GC4422@fastly.com> References: <1663120270-2673-1-git-send-email-jdamato@fastly.com> <1663120270-2673-2-git-send-email-jdamato@fastly.com> <20220914141507.GA4422@fastly.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220914141507.GA4422@fastly.com> User-Agent: Mutt/1.5.24 (2015-08-30) ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=fastly.com header.s=google header.b=W15M6v32; dmarc=pass (policy=reject) header.from=fastly.com; spf=pass (imf04.hostedemail.com: domain of jdamato@fastly.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=jdamato@fastly.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663165528; a=rsa-sha256; cv=none; b=YtfavAbB8mER2Mb17MN4z6YD+P6cEGl9zvbFCk4OW4yQx3pHw6mVDpktnc5Ch40Po8ooKL bWjRq/KitnSOIHbQDtcOS89PNHPXPsfW4uaHe+rxu+shg62O8JAtKjcjVdz8a6KPa13Ykp N26VMJi/GgdokRrNvL6tAsn419pANHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663165528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hdSD8tJb664Fr8pl0NO+kf8L2z4TDzTohEl0wY+gzYc=; b=X9ZdSPOGyomkm4WgKX/9rtmpkK3YlmhZaQBSTRmuQtRdHPBkzCie1ER5A0+PMMjJYQyd3g B9wvXMX4UxVRUX5c+oHrtNhJ0TlWqXeZdW3mDKA+OHh4Rht5/7jYE5w8Vxpq4oFYlhfOF/ IaKkAghfHCt7bAYyqJalVEdzN9yac4I= X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=fastly.com header.s=google header.b=W15M6v32; dmarc=pass (policy=reject) header.from=fastly.com; spf=pass (imf04.hostedemail.com: domain of jdamato@fastly.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=jdamato@fastly.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 870304009E X-Stat-Signature: xm1aoy8g9t5pd83smqe919cnipnwocia X-HE-Tag: 1663165528-453996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 07:15:07AM -0700, Joe Damato wrote: > On Wed, Sep 14, 2022 at 12:40:55AM -0700, Dave Hansen wrote: > > On 9/13/22 18:51, Joe Damato wrote: > > > TLB shootdowns are tracked globally, but on a busy system it can be > > > difficult to disambiguate the source of TLB shootdowns. > > > > > > Add two counter fields: > > > - nrtlbflush: number of tlb flush events received > > > - ngtlbflush: number of tlb flush events generated > > > > > > Expose those fields in /proc/[pid]/stat so that they can be analyzed > > > alongside similar metrics (e.g. min_flt and maj_flt). > > > > On x86 at least, we already have two other ways to count flushes. You > > even quoted them with your patch: > > > > > count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); > > > + current->ngtlbflush++; > > > if (info->end == TLB_FLUSH_ALL) > > > trace_tlb_flush(TLB_REMOTE_SEND_IPI, TLB_FLUSH_ALL); > > > > Granted, the count_vm_tlb...() one is debugging only. But, did you try > > to use those other mechanisms? For instance, could you patch > > count_vm_tlb_event()? > > I tried to address this in my cover letter[1]... Err, I forgot the [1]: https://lore.kernel.org/linux-mm/1663120270-2673-1-git-send-email-jdamato@fastly.com/