Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06EB0ECAAD3 for ; Mon, 19 Sep 2022 19:41:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 70EBF84C3C; Mon, 19 Sep 2022 21:41:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663616500; bh=F10H7KhL+2Ly4a7QQMiHPssVYX8ipmkuf9rPq8ZMsuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lyfIHkxbpdzABnjRF8nME/1L/0tehV9fOuVLysq+6K4TpJ8aeoHR5AdsHgCCrqQuZ JQG3MknkxhFbaVKCvGjvIxWTZ7nBA16tFzEeEgvNDjs2oIu3wZseNf27tbzkAhM7NZ uN108SDq70MZVuImXbNrk8MTVnqLeZMJUS7ZSkGSbwqDm3kvmA2GBYCu3koTi3TI2j 33tJXmY13MnvacVPATvvUuIq/9JVdrDUlwKo7VXjFc8QTbnbQ5wyGZDI8jIdaQoq/I kWIRJ7qM52iUTgEUCGT8FvKrq7Mr1+nXijhi6Bwb4bRJieWhU05XW5H/Drlc2L8CQU e+rO6A9YSC4Hg== Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D302C84C38; Mon, 19 Sep 2022 21:41:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663616497; bh=F10H7KhL+2Ly4a7QQMiHPssVYX8ipmkuf9rPq8ZMsuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FZKKJWWH97JDwu9j+Zwef+feroG90pCTGGJfs8hSvuhpvvrxTB50UXEixM2JYI+Al bJ2zqLETb2jYuF+ZZGO+kfdepV6ev5Tz9kNbNEEpPAMzMLei4QF60cyogolsLl7PGk zg95g59bBEiZQ06EmP6S8tM2kuDsLviYxrHOZg3NvDXVRVLqH2I/tCPO2Wyh2f1/b1 4QgxegjjbEldFrPFS7N+QvjVObTDsun15JXZXo0tkQR8R0JfWRL7zUuxCv5mDN63Hw qtM8C4+j7ndmGqPR8a7J6JQNQ6q8up+mQ8haTkGhuXvw4Bzh5nCf3x/+mFTrel/beC 3DLXvcUgEgeVw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan , Stefano Babic , Teresa Remmet Subject: [PATCH 2/4] ARM: imx8m: phycore_imx8mm: Drop bogus spl_board_init() Date: Mon, 19 Sep 2022 21:41:16 +0200 Message-Id: <20220919194118.105820-2-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220919194118.105820-1-marex@denx.de> References: <20220919194118.105820-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The current implementation of spl_board_init() is not correct, the MX8MM BootROM v1 does not support SDP load when re-entered from U-Boot SPL, it is up to U-Boot to perform the next stage load using its own internal CI gadget driver and SDP protocol implementation. Drop the spl_board_init() to let SPL continue with normal load in case the SDP support is enabled. Signed-off-by: Marek Vasut --- Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Teresa Remmet --- board/phytec/phycore_imx8mm/spl.c | 10 ---------- configs/phycore-imx8mm_defconfig | 1 - 2 files changed, 11 deletions(-) diff --git a/board/phytec/phycore_imx8mm/spl.c b/board/phytec/phycore_imx8mm/spl.c index d87ab6d4497..1bae9b1170d 100644 --- a/board/phytec/phycore_imx8mm/spl.c +++ b/board/phytec/phycore_imx8mm/spl.c @@ -42,16 +42,6 @@ static void spl_dram_init(void) ddr_init(&dram_timing); } -void spl_board_init(void) -{ - /* Serial download mode */ - if (is_usb_boot()) { - puts("Back to ROM, SDP\n"); - restore_boot_params(); - } - puts("Normal Boot\n"); -} - int board_fit_config_name_match(const char *name) { return 0; diff --git a/configs/phycore-imx8mm_defconfig b/configs/phycore-imx8mm_defconfig index 9b8c09a73ab..e8d7905bb4a 100644 --- a/configs/phycore-imx8mm_defconfig +++ b/configs/phycore-imx8mm_defconfig @@ -30,7 +30,6 @@ CONFIG_BOARD_LATE_INIT=y CONFIG_SPL_HAS_BSS_LINKER_SECTION=y CONFIG_SPL_BSS_START_ADDR=0x910000 CONFIG_SPL_BSS_MAX_SIZE=0x2000 -CONFIG_SPL_BOARD_INIT=y # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set CONFIG_SPL_STACK=0x920000 CONFIG_SYS_SPL_MALLOC=y -- 2.35.1