Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC7CDC04A95 for ; Fri, 23 Sep 2022 22:29:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D1CD844E4; Sat, 24 Sep 2022 00:29:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663972187; bh=jWqDYfwSiW1jIN+wtUXXXd80SxXAcLVTm9D9X5QTBBw=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Hh/coHz6IwuEBCiV/DRklja9QsZ4cToQIobqdXBQhC9v1KaHnyGfSf0Mol6vP9F+B HGV485CUIqhyNE4lnGsc7OtgUh17QsA1ZhtjDwhGl9R4zOTJKFNe+/mu7llsI/fOY6 1sMOxfrYcCFONdpgj5mnfLf6Sm6JBdgxG3aARtcXsiZNgmv+VgWho1suNEGnrpad6D vAbctiHx3o6L04RJx3X/qXzrR8SKwYk23wuqxJ6mUGUQk8686w5g1tqMNPD7QdLWiq jlBnacmcM3cVD/AHruT0x0f2MsK2DHfXrLuIUJOENwu4n6c8/bHiCAAscQ6gwBFx/L cWJ/CS0gdxZPg== Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6F5EA83FEE; Sat, 24 Sep 2022 00:29:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663972184; bh=jWqDYfwSiW1jIN+wtUXXXd80SxXAcLVTm9D9X5QTBBw=; h=From:To:Cc:Subject:Date:From; b=nquGDp9yp5az38xZ6WwXjj/NMXEC2gR4WRcMI+CgEEhP5kIQnjUdVx+8e+/PsHO6f ke83oDvbWbluHddV6YmzUiTOGrPtX/xnM6KjcDi5f8lyN/+DUyStz+lBNVnioewtss Jp4fHKVkclm7k/Ce1wmodwJ5AcWEGrF2k160B2YKcnMPx1qke0MfG5Vay3rSH3MqZz /C7nM8ndMMppm5avMJb4FXAiduI3CdL2VUqpdrQE1epXv2hifXArsxdsB7qCvDYpyf PV94YdKIgUrDyvigZXKbnIZTuR8+CxZoWfXnB4izJUopjxpN/Uuz64d294wFFdqnA+ bh0z/r2DS+fkA== From: Marek Vasut To: u-boot@lists.denx.de Cc: Ye Li , Marek Vasut , Fabio Estevam , Jaehoon Chung , Marcel Ziswiler , Max Krummenacher , Peng Fan , Stefano Babic Subject: [PATCH] mmc: fsl_esdhc: fix problem when using clk driver Date: Sat, 24 Sep 2022 00:29:33 +0200 Message-Id: <20220923222933.640838-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Ye Li Move init_clk_usdhc to non-clk driver case, since assigned-clocks properties will initialize the clocks by clk driver. Signed-off-by: Ye Li Signed-off-by: Marek Vasut --- NOTE: Was MLK-21848-5 fsl_esdhc: fix problem when using clk driver NOTE: Fixes SD SDR104 mode instability on MX8MP --- Cc: Fabio Estevam Cc: Jaehoon Chung Cc: Marcel Ziswiler Cc: Max Krummenacher Cc: Peng Fan Cc: Stefano Babic --- drivers/mmc/fsl_esdhc_imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index 9befb190bdf..92b152fc979 100644 --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -1519,8 +1519,6 @@ static int fsl_esdhc_probe(struct udevice *dev) * work as expected. */ - init_clk_usdhc(dev_seq(dev)); - #if CONFIG_IS_ENABLED(CLK) /* Assigned clock already set clock */ ret = clk_get_by_name(dev, "per", &priv->per_clk); @@ -1536,6 +1534,8 @@ static int fsl_esdhc_probe(struct udevice *dev) priv->sdhc_clk = clk_get_rate(&priv->per_clk); #else + init_clk_usdhc(dev_seq(dev)); + priv->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK + dev_seq(dev)); if (priv->sdhc_clk <= 0) { dev_err(dev, "Unable to get clk for %s\n", dev->name); -- 2.35.1