Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D12CC04A95 for ; Sun, 25 Sep 2022 13:27:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 40D098492C; Sun, 25 Sep 2022 15:27:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="SJyJTxF3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lNZhUFa9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A7AAF84975; Sun, 25 Sep 2022 15:27:45 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F20488492C for ; Sun, 25 Sep 2022 15:27:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=msuchanek@suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id BCD8B21B4B; Sun, 25 Sep 2022 13:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664112461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MEfOOCAdkX6otc+fEUAczQ5BCTsV8RkJHlwIWViXqC8=; b=SJyJTxF3mjPFTiaYsAVoet2qqvgGBmLa6e3PK+e01M0+6ypzb8rtIfF6gdbchhSwsRqzl5 sshRil9t8qvEfTFUUp7mmGtFFdNIayEGJvanCRaBici4OeSQYIOlxp2hhZwzfqfWqQaqU1 I+tD1vqnzi3wLObsQZdkDgPr+sRhn3U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664112461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MEfOOCAdkX6otc+fEUAczQ5BCTsV8RkJHlwIWViXqC8=; b=lNZhUFa94qEHvXEZqNgP11z+6/u0yNum1TyvJVopQiLzqJP14f4YA7fp9Fr6L7z6A933Xz rVMRKPYlmmBfyVBg== Received: from naga.suse.cz (unknown [10.100.224.114]) by relay2.suse.de (Postfix) with ESMTP id 41AAC2C17A; Sun, 25 Sep 2022 13:27:41 +0000 (UTC) From: Michal Suchanek To: u-boot@lists.denx.de Cc: Michal Suchanek , Marek Vasut , Mario Six , Michal Simek , Rick Chen , Simon Glass Subject: [PATCH 2/2] common: board_f: Print information for all sysresets Date: Sun, 25 Sep 2022 15:27:31 +0200 Message-Id: <20220925132731.6293-2-msuchanek@suse.de> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220925132731.6293-1-msuchanek@suse.de> References: <20220925132731.6293-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Boards can have multiple sysresets, iterate all when printing sysreset info. Also print the symbolic error when reporting sysreset failure. Fixes: 23471aed5c ("board_f: Add reset status printing") Signed-off-by: Michal Suchanek --- common/board_f.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/common/board_f.c b/common/board_f.c index 18e2246733..0835b376bc 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -55,7 +55,7 @@ #include #include #include -#include +#include /* * Pointer to initial global data area @@ -163,20 +163,27 @@ static int print_resetinfo(void) { struct udevice *dev; char status[256]; + bool first = true; int ret; - ret = uclass_first_device_err(UCLASS_SYSRESET, &dev); - if (ret) { - debug("%s: No sysreset device found (error: %d)\n", - __func__, ret); - /* Not all boards have sysreset drivers available during early - * boot, so don't fail if one can't be found. - */ - return 0; - } + /* Not all boards have sysreset drivers available during early + * boot, so don't fail if one can't be found. + */ + for (ret = uclass_first_device_check(UCLASS_SYSRESET, &dev); dev; + ret = uclass_next_device_check(&dev)) { + if (ret) { + debug("%s: %s sysreset device (error: %d %s)\n", + __func__, dev->name, ret, errno_str(ret)); + continue; + } - if (!sysreset_get_status(dev, status, sizeof(status))) - printf("%s", status); + if (!sysreset_get_status(dev, status, sizeof(status))) { + printf("%s%s", first ? "" : " ", status); + first = false; + } + } + if (!first) + printf("\n"); return 0; } -- 2.37.3