Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01DFEC433F5 for ; Thu, 29 Sep 2022 17:51:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 845F984BE8; Thu, 29 Sep 2022 19:51:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jBT3M3BT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 51F2882072; Thu, 29 Sep 2022 19:51:27 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D961182072 for ; Thu, 29 Sep 2022 19:51:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id j8so1355617qvt.13 for ; Thu, 29 Sep 2022 10:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=6EyDVDgHguo0I7bW0YfGX6/t1lZfvoyTv6DSB8YO2wA=; b=jBT3M3BTnxALqHtSmqpgqubcppKyMLI05Dpsj+s4xomXQFpAMoFkW4rZ8F1XqaoVgB VSsl06sMuNb+nz0BE+sEUlDOzVomaXOp8+P21v3DIgu/V3+qY+ofDpueTxaWvR7cOmcD vtn6YbLaVR3plIahxmWnkNelTT756+LAOJtKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=6EyDVDgHguo0I7bW0YfGX6/t1lZfvoyTv6DSB8YO2wA=; b=wHtu/KoltwSTEQmbw+xF1ggnhLqqWMy/rF8P73yQaFKsGvmEvdAl56Dj3VQjh8ZRCv 2zSF5gOOD5Imx54S1sYs3EH2ZnKF2bgVIIw/052rDJGJsU4OlH0ue3DJzhJ/e2XPcDLM F+FpswLW5ivK/2b8k/fU8+/+CQocrFyc6vllZBMgcIeSGx3ePrO1FHCYcplVSqrQ79N4 x1YA8WruPuGQxiGHdouVkli5zzSZGrF6YWZYmQUEOT9659yMGSYh4NWNx8nVgBKNANC0 GAZ5hChzV8RAgvgcp83HcZywT65JmKDsSvhjvYeUa4nR1Hfpgw+RmWdFw5byHrlEOSzz A2lg== X-Gm-Message-State: ACrzQf28GWoqqWj54pguD7jxI0jPu2vCN4YFhX9Gi+SKjoBy3+cILeuI GRMUedBa6bNKyceoAQsnRH3EQA== X-Google-Smtp-Source: AMsMyM60ULzYwxvf8SbU7+VAgZic653JVuFXFxtJjJunUyjqaYKtABBAVrEfIZuNli8m2ERGp/QZBg== X-Received: by 2002:ad4:5b8a:0:b0:4ad:8ee4:a1e5 with SMTP id 10-20020ad45b8a000000b004ad8ee4a1e5mr3583763qvp.23.1664473883573; Thu, 29 Sep 2022 10:51:23 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0186-ea3a-a82b-3964.res6.spectrum.com. [2603:6081:7b00:6400:186:ea3a:a82b:3964]) by smtp.gmail.com with ESMTPSA id bm32-20020a05620a19a000b006c73c3d288esm6670513qkb.131.2022.09.29.10.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 10:51:22 -0700 (PDT) Date: Thu, 29 Sep 2022 13:51:21 -0400 From: Tom Rini To: Roger Quadros Cc: Simon Glass , U-Boot Mailing List Subject: Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL Message-ID: <20220929175121.GF3044094@bill-the-cat> References: <20220928121149.1724-1-rogerq@kernel.org> <20220928121149.1724-2-rogerq@kernel.org> <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HE8xRhbuhm5Vuapo" Content-Disposition: inline In-Reply-To: <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --HE8xRhbuhm5Vuapo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 29, 2022 at 10:02:54AM +0300, Roger Quadros wrote: > Hi Simon, >=20 > On 28/09/2022 19:27, Simon Glass wrote: > > Hi Roger, > >=20 > > On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote: > >> > >> We will need ti-gpmc driver for SPL. Allow memory drivers > >> do be built for SPL. > >> > >> Signed-off-by: Roger Quadros > >> --- > >> scripts/Makefile.spl | 1 + > >> 1 file changed, 1 insertion(+) > >=20 > > Please can you use the existing drivers/ram directory? >=20 > The ti-gpmc driver is not actually a RAM only controller. Although it can= support SRAM. > It is a more general purpose controller that can support different periph= erals. > It is similar to the drivers already existing in the divers/memory direct= ory. >=20 > I was just trying to keep the file layout similar to that in the Linux ke= rnel. >=20 > Do you still see a problem with it? Yes, this makes sense because it's not a ram controller driver. --=20 Tom --HE8xRhbuhm5Vuapo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmM12xYACgkQFHw5/5Y0 tyyECgv/XaKsJiUDjEoRt4wP32drsQE7Hy+TGyvwKWsStgcEp+NmKhWsMlbY20zb 3xvUySJ/gNkLNvVVqmmGO0z5HfPvHquMi+Hk5H01S0Qoiz6Dn33FVYIs8mGcH/dc HujVlgBfPibMYwzRAZhVCsexiz0EomqyO85Iyi5u7T1vKo8uZUPwS3Z5CBkoVipo NZ7emh7PCLGKXhPitaq1/SeVHBWXwRXdsvJ1C1VniBB2467fcCeTCafBKVygeXhi jWD3yfdgpEv1RPDUpTCU0JoFKfUQiSXDcjd+kFVPgr5ub9Tl7xEEh3KM1JYOjVQs zGkjAMdmSKFAxGIHZYWaXSzpTX3bPd/hzjakiKCf3XgbzzC7o+q1voCntpdv2Bej x8p31Ghvi9efzCGKzeCzAldzZUwZ3qE649RVoYVVNz1pBDhxrYtVj5FdhnFMNPU+ Qg3h4FjxAdfs363ycaAq2rQ/RMq4GP5Fr7WWfjmqOfiicNxf3RSIl1DQF7CwEjWq josVJTWO =MWyO -----END PGP SIGNATURE----- --HE8xRhbuhm5Vuapo--