Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DA50C433FE for ; Fri, 30 Sep 2022 14:00:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A1F784D80; Fri, 30 Sep 2022 16:00:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dcaRfmei"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6DF6984D82; Fri, 30 Sep 2022 16:00:27 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C7F284D7C for ; Fri, 30 Sep 2022 16:00:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id e20so2546710qts.1 for ; Fri, 30 Sep 2022 07:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=vt9Nrp2r5jHbwNf3NZIOLF4ZlK7yDHNBj8u8gI1oK20=; b=dcaRfmeix4OoAEk3bauSNBLvn1St0m4MNcBegbc6gg69aj57V1uCwcFn0M3byC4nm+ Y2zzbtQwVVpUTQUtVnCGWcJTz5SpVSp/ZKIUrnzn8+dwpHWlYvdzJLiphfHCPW8omy6I cH7KVTQuduk0DA3mI4rvtUn8Y7oFBfiM5bOLk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=vt9Nrp2r5jHbwNf3NZIOLF4ZlK7yDHNBj8u8gI1oK20=; b=OIJa+tJm3UE6f2rhD2aJe2AEFxEHCq/y2DK7+akfzbeCq4pUl9+o0Uey/yENqflwH1 XvZ9WrbWsownb4osWfwPF1iEoDQYYHhwYAWyvLQGfucf5eWLMlUrq1Is0+3mYRP4ndCf PJG0bQd9qyOF0Kp4qcE/1MTtnqpw8ygO82qpSmxj9DHKBRRkFEtQmk6kzkUgxTk5QWWl QJN34BYloilGQ+FHnu5ciwi01ozMtyM6+ykzvK4JYlNhvx5OCKZE1BjHhJc1zfHHdJT9 MS7Da0U0jm0jGf79Oh0iR3v/XgEYciBWjJ/FsJRAAAbiyZgu5Q+p+AzfJzE8yHqj2Q6l KqAg== X-Gm-Message-State: ACrzQf0Z/wSANPxifYPKvhd8iH88tWjKeb087UJXag5d4V1J3RNBTOSq sSP/2hKQPcK26172p4it82QY8Q== X-Google-Smtp-Source: AMsMyM6ZQyf4qOlKiYFwRY08zO2tmaUwWNnnO5h6P42AbiZpDouiGJBBNJ0TGqJzXPxq8shwnrHUzw== X-Received: by 2002:ac8:5dca:0:b0:35c:e21f:92c3 with SMTP id e10-20020ac85dca000000b0035ce21f92c3mr6835925qtx.473.1664546423189; Fri, 30 Sep 2022 07:00:23 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0186-ea3a-a82b-3964.res6.spectrum.com. [2603:6081:7b00:6400:186:ea3a:a82b:3964]) by smtp.gmail.com with ESMTPSA id i10-20020ac8764a000000b0031f41ea94easm2054760qtr.28.2022.09.30.07.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 07:00:22 -0700 (PDT) Date: Fri, 30 Sep 2022 10:00:20 -0400 From: Tom Rini To: Simon Glass Cc: Roger Quadros , U-Boot Mailing List Subject: Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL Message-ID: <20220930140020.GR3044094@bill-the-cat> References: <20220928121149.1724-1-rogerq@kernel.org> <20220928121149.1724-2-rogerq@kernel.org> <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org> <5f73e765-803d-0ee4-60be-f2a7996f054c@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fIzhkMdFpQQawNxv" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --fIzhkMdFpQQawNxv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 30, 2022 at 07:28:51AM -0600, Simon Glass wrote: > Hi Roger, >=20 > On Fri, 30 Sept 2022 at 06:47, Roger Quadros wrote: > > > > Simon, > > > > On 29/09/2022 21:06, Simon Glass wrote: > > > Hi Roger, > > > > > > On Thu, 29 Sept 2022 at 01:03, Roger Quadros wrot= e: > > >> > > >> Hi Simon, > > >> > > >> On 28/09/2022 19:27, Simon Glass wrote: > > >>> Hi Roger, > > >>> > > >>> On Wed, 28 Sept 2022 at 06:12, Roger Quadros wr= ote: > > >>>> > > >>>> We will need ti-gpmc driver for SPL. Allow memory drivers > > >>>> do be built for SPL. > > >>>> > > >>>> Signed-off-by: Roger Quadros > > >>>> --- > > >>>> scripts/Makefile.spl | 1 + > > >>>> 1 file changed, 1 insertion(+) > > >>> > > >>> Please can you use the existing drivers/ram directory? > > >> > > >> The ti-gpmc driver is not actually a RAM only controller. Although i= t can support SRAM. > > >> It is a more general purpose controller that can support different p= eripherals. > > >> It is similar to the drivers already existing in the divers/memory d= irectory. > > >> > > >> I was just trying to keep the file layout similar to that in the Lin= ux kernel. > > >> > > >> Do you still see a problem with it? > > > > > > Well in this case perhaps the RAM device would be a child of this one? > > > > That's right. > > > > > > But there is no uclass for your new device. One of the drivers in that > > > dir uses UCLASS_NOP and your one seems to use UCLASS_SIMPLE_BUS > > > > > > So let's add a uclass for it and describe exactly what it is for. > > > > Why isn't UCLASS_SIMPLE_BUS sufficient? > > By itself, the GPMC driver doesn't offer any usable functionality. > > It just configures the bus interface and then populates the children. >=20 > That's OK, but in that case it should go in drivers/bus and perhaps > drivers/memory should go away? No, drivers/memory/stm32-fmc2-ebi.c is there and is the equivalent (more or less) of drivers/memory/stm32-fmc2-ebi.c in the linux kernel. So maybe a question is, are we talking about the equivalent of drivers/memory/omap-gpmc.c here? Or something else? --=20 Tom --fIzhkMdFpQQawNxv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmM29mIACgkQFHw5/5Y0 tywErwwAqobJU7ZhHAPMSMP6NQVCLvjr/0wnIFx0ON5fodZQNKVxLm+e3jZZ2eO0 4tg/Hig+gYW32U68F5ITucsN7z+CEp3iwXwJVA1EM0Qrc3kKQDlcb5zJOZBYk3dy RIQFaeFqWzypzXiOmvHvfwAZRdXznsnVTQaWcZZfOxRU+F+QHhgFAPipKJqAx/vP 8fTJAIN+WEkaM3xdX0B2ONXRWBXmtnM/ZeW9TEKEPcfJynHsmXYZZFmNx+Kk9f5S dYyCXdSn8Gxpzg0aey2G4imjvPvX2crKNQ3y7mgfWNT3Bx80SJimxDfTJ1k8ZKCp zU/jBS/IIlPMYPPd/LDGsR9DZkZqQ9A/PkOKvwRQ6c14TaCAN5iSdW6pf/hKn7L0 nlrZBTW8I4DK/5zOKB77ThbKna5FCeVFdOKgMffKncGPPjIHHXFi4JIeYPsMRO0q hbM7FSLa4F1ndLEPBvzYZeGutF2hxOm3t3mjo1HxXltXV27e7YJfMHD0omBPzfk7 IprAqrat =djWp -----END PGP SIGNATURE----- --fIzhkMdFpQQawNxv--