Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20CA8C433F5 for ; Fri, 7 Oct 2022 15:49:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 39C2F84E95; Fri, 7 Oct 2022 17:49:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FRo8qs6Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1AAB284EA1; Fri, 7 Oct 2022 17:49:13 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2918584E94 for ; Fri, 7 Oct 2022 17:49:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id s21so3020725qtx.6 for ; Fri, 07 Oct 2022 08:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2KH6gL+4UcsF+lilR/kBa3tsHv2nHc7y9Et591fPszQ=; b=FRo8qs6YBcaDw3xmZLpGhNOKbRovXdF8ljmJLrGrv0d/utsPwVYBc+upZ6a03Na8bw MfgNPovJbCTukIKFEz0TS4Ay40wkSVEcnd9lDdPvoy6MPneVsgXC6RAL7X2s1nxbftne /aXJay+T8SilV4k49euCxJBtUxcoCDQhqBUfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2KH6gL+4UcsF+lilR/kBa3tsHv2nHc7y9Et591fPszQ=; b=13pqbMjhjPpJUEdDjE5hL+8CBrD5eFfQwen5dhvhQSXvHB4l7c6VK02t+x5+qlNJoi gRinTK6UOMx4kqjO5kdocdXka/j0MB6w5NrV2KWbh3hlhmEabonN4o0zcCasHTdCykSj ZXnjLnn/yIARGZCq92QCv9y5zIDFb1YGrl+vRUDPpJavmb2Ah5uMrT0WVQo3P1u3IGG+ z8NGsR992A2fvGocsXHgGyEGIzbnBswEvPGfK4u1SgUjHZ/X89l7nrh7D6U0VxmegUZq 0CjtSQAYtYbTCZoC4PuH8UFASnVMatpS9A+IQ0xSwUzsCMrLoHpM62jBx/YVkKT8YD8v 5s3Q== X-Gm-Message-State: ACrzQf0g0QzwZQvKqAIPliw5E+eqkZXsHtbqIMAQseSDM7zIZsST9jRK R63bOYL7yF1mahTDycRq8/TRFQ== X-Google-Smtp-Source: AMsMyM5WQRrqrFFYWEQjeHdmjudyrWh7Qpb+fypOOjLKScd/Ef1yApk5ISYfBdIbVluPEyxU16WUkQ== X-Received: by 2002:a05:622a:252:b0:35d:482f:e105 with SMTP id c18-20020a05622a025200b0035d482fe105mr4850836qtx.92.1665157749001; Fri, 07 Oct 2022 08:49:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-e4fb-bc51-aba6-f69c.res6.spectrum.com. [2603:6081:7b00:6400:e4fb:bc51:aba6:f69c]) by smtp.gmail.com with ESMTPSA id s22-20020a05620a255600b006b929a56a2bsm2593741qko.3.2022.10.07.08.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 08:49:08 -0700 (PDT) Date: Fri, 7 Oct 2022 11:49:06 -0400 From: Tom Rini To: Ovidiu Panait Cc: u-boot@lists.denx.de, Holger Brunck , Marek Vasut , Michal Simek , Rick Chen , Simon Glass , Wolfgang Denk Subject: Re: [PATCH v2 1/4] common/board_f: remove XTRN_DECLARE_GLOBAL_DATA_PTR dead code Message-ID: <20221007154906.GJ3044094@bill-the-cat> References: <20220913183129.14184-1-ovpanait@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bf0bWAI6XaKQIHac" Content-Disposition: inline In-Reply-To: <20220913183129.14184-1-ovpanait@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --bf0bWAI6XaKQIHac Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 13, 2022 at 09:31:26PM +0300, Ovidiu Panait wrote: > The XTRN_DECLARE_GLOBAL_DATA_PTR declarations in ppc code are permanently > commented out, so there are no users for this macro: > #if 1 > #define DECLARE_GLOBAL_DATA_PTR register volatile gd_t *gd asm ("r2") > #else /* We could use plain global data, but the resulting code is bigge= r */ > #define XTRN_DECLARE_GLOBAL_DATA_PTR extern > #define DECLARE_GLOBAL_DATA_PTR XTRN_DECLARE_GLOBAL_DATA_PTR \ > gd_t *gd > #endif >=20 > Remove all references to this macro, but add a documentation note regardi= ng > the possibility of using plain global data for the GD pointer. >=20 > Signed-off-by: Ovidiu Panait > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --bf0bWAI6XaKQIHac Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNASnIACgkQFHw5/5Y0 tywUbgv+OtuyKHwKHwlDS02joS21fsx5zjJHpcgjg/6wb99HBprMI2H4Qpi62cxv nKQW0sMLCRoOfOjr5HcUd4a7lg/FeGdweYP4fY6dTyJRZCiL46WyqytyAsuzwrpp t5arzWJPu+ll2DlHuVWFWL/VgbBVwbI1cgPduQoSe+g8ZrtX5aclEQRBAY4Z+Xrf RZmjZJpfuK0t3u4ZrimkslXTbo6Z6F0bkobtDh4kaCXWTJH6Rop7TiRr5wYSyLr0 IdHljc26MaIKB1BxDSnYpIsQtXNeA5cTXdzCSjF7hWiv2Q/J84GN1lr1ZlclV7JH +hBdkLMJuK8PgD8ZzAJHA9p7PVtI4ORoUhCDOKwdxvuvCs47fTbzE671WHaMRawG iRNmd27lk4t3B2HBMlSn3fmBabFcTl9e4M8R6KRPVEvP3UurlwP2IBAslUUiEGPd 5YNbflVFvEIPw2CAdKQgI8jxRUqjStSQXNOiLD9bUBJNusper2wfgBaQivUaEZus +l+s27UO =s+ZW -----END PGP SIGNATURE----- --bf0bWAI6XaKQIHac--