Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565A65C97 for ; Sun, 9 Oct 2022 22:25:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9569DC433B5; Sun, 9 Oct 2022 22:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665354326; bh=0G7pgzAbm2+9YR5/tmvia7bob4tC2qyNvnsTbTuBWPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rRJonGmhKPqEkaqY0Wp7/tWrv2di2s7eIl6r4SiqCc6aF/N6WFak9Z3IuL8jRxhsT uur2PC8OrQ6nPJyB3Yq5ASn+LcePE1KIk/ZxkcwutprrHN8wiQbw6pzYbam1MA1236 OE8sN4mdT0cObv6MNVFk8NXxtpQ49JN3wg0MhnNwxZT5hgqdoIsXI1/0XVnFSQMyQP RO8Z+WuXqNmVcG1FK2KGES5ml+99jbk3GU978XPt+X14p9Rhb4ymgYV+5U6zxpxGOT /AlBXVkCHBhO2tkWItCLFplKNxqrSqh/JjwKt+6ppQzQxdONUdceShPiHJBA5o7i8b XHcnyWcwUyugw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Nathan Chancellor , Jakub Kicinski , Sasha Levin , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ndesaulniers@google.com, mw@semihalf.com, khalasa@piap.pl, wsa+renesas@sang-engineering.com, shayagr@amazon.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 14/25] net: korina: Fix return type of korina_send_packet Date: Sun, 9 Oct 2022 18:24:19 -0400 Message-Id: <20221009222436.1219411-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221009222436.1219411-1-sashal@kernel.org> References: <20221009222436.1219411-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Nathan Huckleberry [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ] The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of korina_send_packet should be changed from int to netdev_tx_t. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Link: https://lore.kernel.org/r/20220912214344.928925-1-nhuck@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/korina.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 9f804e2aba35..d1bd56f6eecb 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -196,7 +196,8 @@ static void korina_chain_rx(struct korina_private *lp, } /* transmit packet */ -static int korina_send_packet(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t korina_send_packet(struct sk_buff *skb, + struct net_device *dev) { struct korina_private *lp = netdev_priv(dev); unsigned long flags; -- 2.35.1