Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3774BC433F5 for ; Mon, 10 Oct 2022 13:54:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C369884CEF; Mon, 10 Oct 2022 15:54:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fJC5v+vL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 494E484CEF; Mon, 10 Oct 2022 15:54:09 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6B45E84CDB for ; Mon, 10 Oct 2022 15:54:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id o67so6706463qvo.13 for ; Mon, 10 Oct 2022 06:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PyFx4csI56EtuImbXbTVFs60+njXOkEmC8m1oGTahUY=; b=fJC5v+vL2VZMDO+20ZZS8NgiM5ZmladvzhiqqqBstjd8K/vGHmHrkWlgfoQvGUkOXy x+vu3vRBnApOVPGbNqrZggD4JlAmmLwOrsf5EN/C8JJcmXYzl37dzQQAFWoy7lXFuYIj LvADBQDo43QEywYm+UkGcUtIkKkqMcNj1XKHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PyFx4csI56EtuImbXbTVFs60+njXOkEmC8m1oGTahUY=; b=cresuUUPbYwMBHLZt151XWVTTH59svDCdHDAbpq9r1PUryHZ6jsPmnHH9dL4ItcWzp LSAjdzcQHzZIF9qy58vyxafh6pwP6J4bBP8XZuebpba6vXYUS0Su6IO2LCdWaB0wwaj3 DFD32WA5jlWAtdPucly60gXL+EUkhhFKWP3jkboyCNJIH2ym3IvcEzkK7n641ItdG9EM WvTcWfL0syGVXeTnJZ+OnQyEz9HdFDs9GjIN529lUWjmRhqPmRwlcNyCNKq3Ja7k0SdW T39BQ4iZSZ+9mcb21CPzIgsIRN4NBIQ0BCdRUY2GPuTG01zx6aNV91DGUUGsRJ5zlmhj 55kw== X-Gm-Message-State: ACrzQf3g6BDBJ54A8+RlvVi7JHWsboYz81a1RRUjf3R2IPa4xtChgh8E uD6ZJN+HY3TxnthGj0eTDTRxc09tNefvvQ== X-Google-Smtp-Source: AMsMyM7+RgQNTkleRHP9SmbuizEMdRNlEAJde8YvlAAZZiIPi6OwvPTJkdt4Uq8pQV/v0WXwDtxUsg== X-Received: by 2002:a05:6214:202d:b0:4b3:d665:3e06 with SMTP id 13-20020a056214202d00b004b3d6653e06mr9980814qvf.47.1665410045126; Mon, 10 Oct 2022 06:54:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id g11-20020ac842cb000000b0035d465ae4cdsm8852207qtm.27.2022.10.10.06.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 06:54:04 -0700 (PDT) Date: Mon, 10 Oct 2022 09:54:02 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, maemo-leste@lists.dyne.org Subject: Re: [PATCH] Nokia RX-51: Fix compilation with non-zero CONFIG_SYS_TEXT_BASE Message-ID: <20221010135402.GE2020586@bill-the-cat> References: <20221009193713.12765-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline In-Reply-To: <20221009193713.12765-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 09:37:13PM +0200, Pali Roh=E1r wrote: > For some unknown reason GNU assembler version 2.31.1 (arm-linux-gnueabi-as > from Debian Buster) cannot compile following code from located in file > board/nokia/rx51/lowlevel_init.S: >=20 > kernoffs: > .word KERNEL_OFFSET - (. - CONFIG_SYS_TEXT_BASE) >=20 > when CONFIG_SYS_TEXT_BASE is set to 0x80008000. It throws strange compile > error which is even without line number: >=20 > AS board/nokia/rx51/lowlevel_init.o > {standard input}: Assembler messages: > {standard input}: Error: attempt to get value of unresolved symbol `L0' > make[2]: *** [scripts/Makefile.build:293: board/nokia/rx51/lowlevel_ini= t.o] Error 1 >=20 > I have no idea about this error and my experiments showed that ARM GNU > assembler is happy with negation of that number. So changing code to: >=20 > kernoffs: > .word . - CONFIG_SYS_TEXT_BASE - KERNEL_OFFSET >=20 > and then replacing mathematical addition by substraction of "kernoffs" > value (so calculation of address does not change) compiles assembler file > without any error now. >=20 > There should be not any functional change. >=20 > Signed-off-by: Pali Roh=E1r > --- > Btw, is somebody understanding that compile error message? Is there (or > was there) some real issue in the code, so assembler refuse to compile > it? Or have I triggered bug in GNU assembler? I would suggest filing a bug with upstream GNU assembler and seeing what they say. --=20 Tom --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNEI/oACgkQFHw5/5Y0 tyzuEAwAiy9JWqv4mFiqsDHaPGgW/9YA3QB+qdq2fLAlo1L5rNSAQgyqH7rT57h1 DZQrWougH07mrB0fV6/QdAGe5a8+LuobxRHt6KqI+QQI1e4aPACjEpU9Wes/mMT3 9LHkDA2Ih/a6W1pzOq/1CdehFrygiFNRi3ch3ORNBI6l1cmd+98psZLhcy8MB8UH WbpWFpyjGWXKK0dEAoPvHk+ANI860nh2/bNR/2cITttY3KLseUJ0cjE28Kz9GzO/ kovVPKxfIi6/h+/fe3gaoE+yGQHpChfvfU6TerpfgRUyIjuOkJ/gYTexcVIYSCOe 6xa68OjLq9pi+jaZHGzEpKowpSjFGHAb2IadXgWykbrrp53bvqcHynZSJZz0j80T W6iYfrbQ1yVGSw0FTb9CKbTFc17lXvCmxj9nekROKiLS/Pw+jJ2cGVcyqzSS4Yym gk9jHsdsv+QE3D/Cf5yMV9nl5vN17OUOtIYWQSHcAg3VWsQ5fif1QfQXvHU4HqLL vemfNqx8 =p/Es -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG--