Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47DF0C433FE for ; Mon, 10 Oct 2022 16:22:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0584484ECC; Mon, 10 Oct 2022 18:22:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hiiAxd62"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 47B7184EE1; Mon, 10 Oct 2022 18:22:03 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DEF3884D22 for ; Mon, 10 Oct 2022 18:21:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id i9so7438799qvo.0 for ; Mon, 10 Oct 2022 09:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XhZEuLZZ0a3XA1LH1U/sOswD8gMLdaT7QiNmNxf2BD4=; b=hiiAxd62ih9uiNjsiuN0pXs1gyVytynEEAMgIy5grEACMkyCqLIJ57hIk+m3lh+g/c N/vLBGRHc4HsIAvbi5i9KvkJtxLhq6djoNyxYusmzx9kGrZt/2z8yo/ZtaECUn1TWxZ6 P/SRwOu99SrGsaa076xz9cU8gqx53/+nX/B30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XhZEuLZZ0a3XA1LH1U/sOswD8gMLdaT7QiNmNxf2BD4=; b=8AkAhGg0HHLRLPZwhZcyGCUW+orC8Wz1knDeM1IAgCOrcwPNsU+NsiR8jDJiXIsqAy wvc/0hJVV+B6bkmkAUfS3mePC5zMe7y8QiNsYAksLe5d7k16+wO5Hx91Jxsx3Yefv5Fq ONxwyvxRtpOw4un1iIn+K5O6LtTmmzkq/bfvvOPgblrMqc3+dxn4ONsUCFp0HerzX3bp OohAxWEcrFUZzl0xEfVrA7diPNeEt/QlqowAGczO4ROWYHngtk6V14eyHCoQmVAI2P79 8FsWcHBfv6WKAWYDeVE2MfzKyRNQcjF4QpBKtj9U9I/zUam7RhWxHFr8bLR3s5qxtmmy FYcw== X-Gm-Message-State: ACrzQf2d/YHIkuMXwH9TIyx1vuB7Hnvx1iiih0RalGrE4F1wmsYN2Ts1 2bpGvMgroZ8I8vdAUgdCWBvxiw== X-Google-Smtp-Source: AMsMyM76IxUBmkFiAa7oju6f9J+bIdkPnuqcbQR7KJZVrnc6Km848VhxAqHNJTgP0bz5ZekZFUUzmQ== X-Received: by 2002:a0c:a711:0:b0:4b1:8816:4168 with SMTP id u17-20020a0ca711000000b004b188164168mr15080162qva.46.1665418918547; Mon, 10 Oct 2022 09:21:58 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id o21-20020a05622a009500b00394d7000941sm8149828qtw.85.2022.10.10.09.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 09:21:58 -0700 (PDT) Date: Mon, 10 Oct 2022 12:21:56 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, maemo-leste@lists.dyne.org Subject: Re: [PATCH] Nokia RX-51: Fix compilation with non-zero CONFIG_SYS_TEXT_BASE Message-ID: <20221010162156.GL2020586@bill-the-cat> References: <20221009193713.12765-1-pali@kernel.org> <20221010135402.GE2020586@bill-the-cat> <20221010161808.zejhhwhnzu6e4fj4@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r5lq+205vWdkqwtk" Content-Disposition: inline In-Reply-To: <20221010161808.zejhhwhnzu6e4fj4@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --r5lq+205vWdkqwtk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 06:18:08PM +0200, Pali Roh=E1r wrote: > On Monday 10 October 2022 09:54:02 Tom Rini wrote: > > On Sun, Oct 09, 2022 at 09:37:13PM +0200, Pali Roh=E1r wrote: > >=20 > > > For some unknown reason GNU assembler version 2.31.1 (arm-linux-gnuea= bi-as > > > from Debian Buster) cannot compile following code from located in file > > > board/nokia/rx51/lowlevel_init.S: > > >=20 > > > kernoffs: > > > .word KERNEL_OFFSET - (. - CONFIG_SYS_TEXT_BASE) > > >=20 > > > when CONFIG_SYS_TEXT_BASE is set to 0x80008000. It throws strange com= pile > > > error which is even without line number: > > >=20 > > > AS board/nokia/rx51/lowlevel_init.o > > > {standard input}: Assembler messages: > > > {standard input}: Error: attempt to get value of unresolved symbol = `L0' > > > make[2]: *** [scripts/Makefile.build:293: board/nokia/rx51/lowlevel= _init.o] Error 1 > > >=20 > > > I have no idea about this error and my experiments showed that ARM GNU > > > assembler is happy with negation of that number. So changing code to: > > >=20 > > > kernoffs: > > > .word . - CONFIG_SYS_TEXT_BASE - KERNEL_OFFSET > > >=20 > > > and then replacing mathematical addition by substraction of "kernoffs" > > > value (so calculation of address does not change) compiles assembler = file > > > without any error now. > > >=20 > > > There should be not any functional change. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > --- > > > Btw, is somebody understanding that compile error message? Is there (= or > > > was there) some real issue in the code, so assembler refuse to compile > > > it? Or have I triggered bug in GNU assembler? > >=20 > > I would suggest filing a bug with upstream GNU assembler and seeing what > > they say. >=20 > And it is really a bug? Is not that issue in current code? I think filing an issue is the best way to find out if we were relying on something undocumented that worked or if it's a regression in the tooling. --=20 Tom --r5lq+205vWdkqwtk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNERqAACgkQFHw5/5Y0 tyzEJgv/cDANh7tfaUUX6qsqTZ77dAzvHYxXmyUlFuIbPeTMS1ZqCHtQcFE3Awy4 98AMTt8cJEjFVHYulTRoTXiAfEVrZcscECEVSo5nXsEPxUU6hGKhE7R7UMv0SOM0 MlLnqKeIWkyqamcZKNeJOqL5VBjLD4eSATWhf1lJTx+dBjlKLTs+aGd8b3INDn/O Df+yG52JjI7ONmLiSpdMWyI5Hs55PmoinP1FotWIXHmJolvWIHSnJCzlXk6gbHSD k8TPdOZbgfGNqyBZi1lVIwBxMVUWSKxgUnHKyLnPROBtY+T0TjEsE7Uuw2wtclkd Drh9LY32CCmpbzkCBWEx+PV1H+CxBeUIOZJc1SgNonyXguHEupH5UqJY4JkT1azj Pdboev6eivS7IFwMefK43H3wII8VgoE1iadNdWqTqRs383Il2HGJJPjtjHpmmmz2 X7OHbPUv36K6+uFBzcrMxfrZvCpCpt4ahm+hI34JqZOXx89fx0tikWJ46fPGn1Vn Axc+L9xT =HmGy -----END PGP SIGNATURE----- --r5lq+205vWdkqwtk--