Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44FD6C433FE for ; Mon, 10 Oct 2022 20:08:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 497FF84ADF; Mon, 10 Oct 2022 22:08:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tHcQsYkm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC71984D22; Mon, 10 Oct 2022 22:07:58 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB2DE844C2 for ; Mon, 10 Oct 2022 22:07:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42B55B80EE4; Mon, 10 Oct 2022 20:07:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC055C433B5; Mon, 10 Oct 2022 20:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665432473; bh=y7NySbWW8RRUBz1YJ3QExMiQBmZvGcaXxAD5qYAtWS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tHcQsYkmGKRTNRk5MaLTM3mvM+Jat1v/YJF4tmG0JnT6PAhHvgPc6se2bRui0pGZn 0dOhTRH++vXRdxjL/JXq3aIJCczJKogAO/t/m53X3H9hAxUqWQvy1qLWdlDwNxEVYo tcU/VNndJacttC7MMOdDZiezyxsVXGyqR6vpFCssPk9F0AhvFU/p3G/Ie4F5D35v// rcX3PY3IJ4R2ksFaY0C3zt0Xl/dWHr6fj9LQnSY/E911xzCBVY9TUPyDFxF2odVJFp IZ6arV/mhJMyRF+2L+qdZVya9EG+JQVTgGxkcpeBIy4ui+0VOuvD4gZuNK4fLuYHQF SGybYXCs96fNQ== Received: by pali.im (Postfix) id EBD7E7F9; Mon, 10 Oct 2022 22:07:50 +0200 (CEST) Date: Mon, 10 Oct 2022 22:07:50 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: u-boot@lists.denx.de, Rasmus Villemoes , Tom Rini , Heinrich Schuchardt , Marek =?utf-8?B?QmVow7pu?= , Quentin Schulz Subject: Re: [PATCH 2/5] Makefile: Correct a missing FORCE on the binman rule Message-ID: <20221010200750.zusxqf5fpd3ffzls@pali> References: <20221010200032.73483-1-sjg@chromium.org> <20221010200032.73483-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221010200032.73483-3-sjg@chromium.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Monday 10 October 2022 14:00:29 Simon Glass wrote: > This is required for if_changed to work correctly. Add it. That is truth. Reviewed-by: Pali Rohár > > Signed-off-by: Simon Glass > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 45f10759a13..2e8ae768c51 100644 > --- a/Makefile > +++ b/Makefile > @@ -1111,7 +1111,7 @@ endef > PHONY += inputs > inputs: $(INPUTS-y) > > -all: .binman_stamp inputs > +all: .binman_stamp inputs FORCE > ifeq ($(CONFIG_BINMAN),y) > $(call if_changed,binman) > endif > -- > 2.38.0.rc2.412.g84df46c1b4-goog >