Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E64AC433F5 for ; Mon, 10 Oct 2022 20:41:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B4D6C84A20; Mon, 10 Oct 2022 22:41:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RcnBGYU+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60E3B84A73; Mon, 10 Oct 2022 22:41:02 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7BD4A84312 for ; Mon, 10 Oct 2022 22:40:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id i12so7806893qvs.2 for ; Mon, 10 Oct 2022 13:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ogz46oVlihDI+WX89rcz+WMLVdzwx7Q2WYof/MbAmrM=; b=RcnBGYU+lYgOHAdoqwFD5+usCdd+wPpzjvAlVfCTlhI6xMIyKxStp7BobBONVXGQXH ZV2c0UOMk0qzvv7IwXQF5IBVWsoCS+Lehq7rDJM54NAbe5ZBIPlsBsh4UXnG8HR/nVtA AawecrQckLCTaqhDWcRMg8+NNCoRQWvXHrXlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ogz46oVlihDI+WX89rcz+WMLVdzwx7Q2WYof/MbAmrM=; b=vPD/wccG+nUOTQAss6slzdpSCe1LkiNTVwTDxq62ZqjV0gZ604bsDxEOOnS3m8XLdg N9FltoXOr/InlKblEDbK1+9LknYnIFZjBn8jVyFbzUju9CqCgBOz0laiX6TaVnn6WKdT X0YJcwFkDYsyRdHsor+XFoUJ5NSQEqrg8Mgbmppjifi5LI8C5SfzNF7kxfuv111G0cli 6vIb4KOYsU4oy1VNUMrdzrKQsvexiF0FDaV2y7U1Z3ERe5IFHBDNAMKrfDc1Bww/wWwT 12K0LU4HqG721PTPV1U2ZVHxSKx5QGiCF+Kux13iENbQc9FSRqZEji3TB+1/thwXzJ7J SWtw== X-Gm-Message-State: ACrzQf2GaYCaMj/jRMh9PE03mKd//w3rFo2gCit0mkqKjTgs3UJEo75B jRyQlzcrAAOM7Q6FyVg3iMp98Q== X-Google-Smtp-Source: AMsMyM4IyDv9+ZqUefCXYePOBNT3nTiZFuKuJYqAT6/IU1TTFA5qs1MvVyFEOqGPI8NgoxspBkdgQA== X-Received: by 2002:a0c:b20c:0:b0:4ac:c5b7:e5ca with SMTP id x12-20020a0cb20c000000b004acc5b7e5camr16072244qvd.126.1665434458388; Mon, 10 Oct 2022 13:40:58 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id he35-20020a05622a602300b0039a55f78792sm2895585qtb.89.2022.10.10.13.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 13:40:57 -0700 (PDT) Date: Mon, 10 Oct 2022 16:40:56 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Rasmus Villemoes , Alper Nebi Yasak Subject: Re: [PATCH 4/5] binman: Use an exit code when blobs are missing Message-ID: <20221010204056.GV2020586@bill-the-cat> References: <20221010200032.73483-1-sjg@chromium.org> <20221010200032.73483-5-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zj18g9eElA7rRQh+" Content-Disposition: inline In-Reply-To: <20221010200032.73483-5-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --zj18g9eElA7rRQh+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 02:00:31PM -0600, Simon Glass wrote: > At present binman returns success when told to handle missing blobs. > This is confusing this in fact the resulting image cannot work. >=20 > Use exit code 103 to signal this problem, with a -W option to convert > it to a warning. >=20 > Signed-off-by: Simon Glass I'm still not sure I like this, rather than changing the default "make" behavior. And then it gets me a bit worried that we have CI not doing some other things "right" as we don't want to ignore warnings in CI, we want warnings to become errors so that new warnings don't make it in-tree. --=20 Tom --zj18g9eElA7rRQh+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNEg1cACgkQFHw5/5Y0 tywuIgwAiuwQp4G/XiE1knB/r2Nl3GAODrX6SDVAEgAXcmAEGwywjEC2bqYt3WIR riVN324L4ygoeWCx2qiThJyyjAk23QWAafxM4gtBr+z/Jf3XjpmR7WH9t7MxpB0f Woae6UmUCOiJvLg2G2XOyWZY46Qbh4BCDUQK716A6p98EMSk/dISynhCH5/HZesA IKfs5YROC02VwHM+2yd2va7ZyBKtI9HcP+5smPUqkYSkHLQv+s+ZMYC9DOm32CVj xsZ6I7ojL3Uf2LW8Hn7ZkXZiaBWLm6np2tAEknp2EI7G6qM6PbFh6IG2ZiX9Hvk5 7G++TXgLIg9g+1L5Vm/RuMgf8yeUfRx6h75sgV2PK0YdUWd37CxkfZfFiCLA57sD 2qYeH286t7RlGUmegbVluizNamxfSFybZURGOnPPKV5ccqblX2hDosGE3c3uSPZ8 SRe2pwMUw6e5s/DW/Uo9ioihW2vZ+JvqsIVRNxPfHV3wR9qvvMzuYA2REiDyH0F/ bQsqqWo3 =AYlv -----END PGP SIGNATURE----- --zj18g9eElA7rRQh+--