Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A65EC4332F for ; Tue, 11 Oct 2022 21:05:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97AD184B55; Tue, 11 Oct 2022 23:05:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ntFsSviT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A6C684B55; Tue, 11 Oct 2022 23:05:20 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D76584ADF for ; Tue, 11 Oct 2022 23:05:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id 8so1877257qka.1 for ; Tue, 11 Oct 2022 14:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J7jjtgaHWylN1q3Hv2BHnEoNXGzIJ4Ct3wmfoYwEgGQ=; b=ntFsSviTfGvSqK/whJYMRbGK9/PbCxifzlHrzUwCN2CZMULWMcRo7XhNGf2KIJGRUj qrbWabKkaR8/flWn8F8WB8Qhr9AvLioPRlmBumEto4aRUdyDzIk6ZFDDP0cOvewq9ejI 3iFS/lszetTef9zxstkJRulRZL+Ad2go2libM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J7jjtgaHWylN1q3Hv2BHnEoNXGzIJ4Ct3wmfoYwEgGQ=; b=I6TsaUHX/nZ0VRnT8Fi9bha/FO6opSfsA9UEY79CAosUieF6Ka/kWA+zLKLBMyOP8l xM24xFQsDAaMDS2lSwu3J50YQzUOKd1W85HRArlTKTNX3YPMDJHZEgdlhzGDzhK6zuHz xLj5Muw7osBioPKMXExkYDSnAOQtWXQPVgSFKEmZiBfGfR4rKJl28ehcoZPkbRYkiFuq 6jnrn9NyrAZIiV4qwWlEvTDKXQm3/0WxjwPbLH8FEOJMChyABOd5VAB0uN1DqVDHOEbB dO9GJ8Sx7Sy8REm8dCdFEKPoJ5M/BxqdI/euW+ZGjf3L4P5HMD49qK5k/5mNmCHFH7Rr 0xsg== X-Gm-Message-State: ACrzQf2gSP8vHwgH3DkE3Xvs1zxdFkbtySBfRz61EyGcuzDPsk/PC+tI MKOnaaWYdjxaDUlyYTS+OmWvBA== X-Google-Smtp-Source: AMsMyM7bYL2tAtqGEzM308Tx2ermOVAH2vr6Pxd02pvL3T3IduHymsskoIzk/JBRR23H10SSlH/aOA== X-Received: by 2002:a05:620a:25c8:b0:6ae:ba71:ea7d with SMTP id y8-20020a05620a25c800b006aeba71ea7dmr18059918qko.547.1665522316163; Tue, 11 Oct 2022 14:05:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9506-5302-f3bb-a137.res6.spectrum.com. [2603:6081:7b00:6400:9506:5302:f3bb:a137]) by smtp.gmail.com with ESMTPSA id c4-20020a05620a268400b006cbcdc6efedsm14031581qkp.41.2022.10.11.14.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 14:05:15 -0700 (PDT) Date: Tue, 11 Oct 2022 17:05:13 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Rasmus Villemoes , Alper Nebi Yasak Subject: Re: [PATCH 4/5] binman: Use an exit code when blobs are missing Message-ID: <20221011210513.GH2020586@bill-the-cat> References: <20221010200032.73483-1-sjg@chromium.org> <20221010200032.73483-5-sjg@chromium.org> <20221010204056.GV2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pMHZerOf5PT7gmN5" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --pMHZerOf5PT7gmN5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 04:25:36PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 10 Oct 2022 at 14:41, Tom Rini wrote: > > > > On Mon, Oct 10, 2022 at 02:00:31PM -0600, Simon Glass wrote: > > > > > At present binman returns success when told to handle missing blobs. > > > This is confusing this in fact the resulting image cannot work. > > > > > > Use exit code 103 to signal this problem, with a -W option to convert > > > it to a warning. > > > > > > Signed-off-by: Simon Glass > > > > I'm still not sure I like this, rather than changing the default "make" > > behavior. >=20 > I did change that, in the sense that 'make' now fails if there are > missing blobs. >=20 > > And then it gets me a bit worried that we have CI not doing > > some other things "right" as we don't want to ignore warnings in CI, we > > want warnings to become errors so that new warnings don't make it > > in-tree. >=20 > That would be quite a big effort, and unrelated to this series. Here > are some warning types I'm aware of: >=20 > - migration > - device tree > - compiler > - missing blobs >=20 > Do we need a per-board whitelist for warnings? It seems pretty tricky to = me. >=20 > It is true that warnings are ignored in CI and this does create > problems...I'd love to make them into errors if we can. This is I guess also a related concern. When I say warnings, I mean C compiler warnings. That we have flags to suppress "warnings" that are other kinds of valid warnings is at least a little confusing. --=20 Tom --pMHZerOf5PT7gmN5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNF2oYACgkQFHw5/5Y0 tyyvAgv+OwMYNoYQKte6B2uXgjLywCNUiQh0wFbY1C+FBmU8dSUUZQ382ZU1udZS 8/gYODsIHSptf1Iaduy/Y0MK9jYS8Kkdxi8cKSblbAd1IEHnDzudbs+JXNJV4Eep qEd1we05Lu8CzOinu9Gm6poB3HpoF4AOLv3JuEEufQt8xPPwk6Uyk8PSVbHrc360 Iy0vB48V+GhhUQah5WY4Z4KKGQfSIZV0Mj2fpNoZMqVRt3WTBOr0LyT/o8+Bwwbj je4b6E8oNfvo3BDFTzpR/W9lOBrZSvMMPbJMS7ZzRQQvqLcosb6Kn3AVyZFwPWWU hEI1xM0ERhb+8CkgsdR8rAHDeZERT83jDmlG5fyIdslQV9pAQrtHvDPNQQrinC/J JjWE6NkKiK6QkugixZh5cydrLMk+PSW9lZYU+PobIZGuP9RxcUmSu4vWq1d0plpd 4dVG+BRtefU/JkJwmTOWvs1irBegQ8yLZM6JM3PcGhlrt2pN7Mr9+eOX2m0PsxHu xay+9U5Z =28He -----END PGP SIGNATURE----- --pMHZerOf5PT7gmN5--