Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26300C433FE for ; Wed, 12 Oct 2022 12:50:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C3C484E57; Wed, 12 Oct 2022 14:50:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jFx2cGr9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA51084E57; Wed, 12 Oct 2022 14:50:06 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 778FE84E5D for ; Wed, 12 Oct 2022 14:50:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id w3so2303479qtv.9 for ; Wed, 12 Oct 2022 05:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DleyqAPSNBTO7p92rIpf5kz5pQTLlh7r9cbMxtxkTk0=; b=jFx2cGr9yIj8hxwvzPTkOliM2SJvTdKMsMweWFYBSCDtbtntJrpQ2U7yOzxVHLIrNf y0NSUqHNBlV0q5wER661ZbE3fQfLmJpQrVlHtHwfGAf2OFuvidyi74fC4X2U7MC1Q/95 6N4HXDH6zghS/A1DQ6e/ogUxoRX6lEqZXF7C4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DleyqAPSNBTO7p92rIpf5kz5pQTLlh7r9cbMxtxkTk0=; b=7dvKe1RSYr/efuKrT+1lhAoL1F/Hf1l8DLXg5hp+jkOYTWYuCMLkI48Tjr8KL8lqHR LkrOkGtrjg3QHDlH5YicAHU8XTmTacwZnrzmtY9+6YZy0Qd2cExnrkGhbWA/jflP0FY6 r2DUoPHDn52FTz7k9k3v2Ypp4tvXD6LjPqOCDzH4buDFj4Vs6ZOQ4+ficVVroBBuJ+Uh /8xm2kmqKFeZLEy9siCGapbcikWwGJRPPXEfeLsDzBPmY0o3uIBXs9kL+2914zurg4i7 g1s8Wh3G/voyQxlHqsOVWubBsGyI2ffs06gwGxVUWptIo+oChO8aMuLI/gzoqlViaFKC STrw== X-Gm-Message-State: ACrzQf3Dmf4Bjl+aw4FF+cJMdAx/yyDLfHINaO00Bx1YQSxpnoyvB+wr pyAAtiId/lclh4gSuUpQlLPl4Q== X-Google-Smtp-Source: AMsMyM6EuRN6IpdAxyj6E3L2aoMrywOKiwzFTn/hBEoIdml5LJrcIIwV9qeiPeppI9ln5BhrjXM0fg== X-Received: by 2002:ac8:5792:0:b0:390:ee6e:5d1a with SMTP id v18-20020ac85792000000b00390ee6e5d1amr22754611qta.631.1665579002297; Wed, 12 Oct 2022 05:50:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-295e-6c71-581f-29f1.res6.spectrum.com. [2603:6081:7b00:6400:295e:6c71:581f:29f1]) by smtp.gmail.com with ESMTPSA id d12-20020a05620a240c00b006cf8fc6e922sm15586049qkn.119.2022.10.12.05.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 05:50:01 -0700 (PDT) Date: Wed, 12 Oct 2022 08:49:59 -0400 From: Tom Rini To: Jit Loon Lim Cc: u-boot@lists.denx.de, Jagan Teki , Vignesh R , Marek , Simon , Tien Fong , Kok Kiang , Siew Chin , Sin Hui , Raaj , Dinesh , Boon Khai , Alif , Teik Heng , Hazim , Sieu Mun Tang Subject: Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT Message-ID: <20221012124959.GA123158@bill-the-cat> References: <20220902032849.4534-1-jit.loon.lim@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mYCpIKhGyMATD0i+" Content-Disposition: inline In-Reply-To: <20220902032849.4534-1-jit.loon.lim@intel.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > From: Tien Fong Chee >=20 > Using imply instead of select for CMD_FAT so overwritten is allowed in > later configuration. >=20 > Signed-off-by: Tien Fong Chee > --- > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Kconfig b/Kconfig > index 991b260182..71374980e9 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -201,7 +201,7 @@ config DISTRO_DEFAULTS > select CMD_ENV_EXISTS > select CMD_EXT2 > select CMD_EXT4 > - select CMD_FAT > + imply CMD_FAT > select CMD_FS_GENERIC > select CMD_PART if PARTITIONS > select CMD_PING if CMD_NET NAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use". --=20 Tom --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNGt/MACgkQFHw5/5Y0 tyysyAwAkWUGhwCWGWisebR+sse7UGq84FRmO9VxHmQBM2UQms5v4wHDmmz7i5CL 5tjpCkXlzCg/iZxjf915ZSHvj2XEdAm246lsyFwtDS39rzxb7aaSOk5QPGqfTwM6 XyLx4PfMpCCOpOwTPhSwLlY94Z+cOnSaoZflXnlC6xeMCNdvY8qaIONtYrhNzF2f UWADKaTw/LS9IzcUWtbTREl5p4ysA2mYROtKFTeVwdsuKoFnzdOXRyuEQC4ORs3l lX9CXjoQ+oOZlB1eLiLdsgTSEa1FJQllzT9fs6NHfG1iAKILWWe5C6SpapyDSGQT ri4ScUxaom455HkC+R4W2tpb+VsplAaFXZHMYVbA1UyyQckUUAVCOqHhmcNRaFIO bvncPFDLit/tkWCAu/qrX0ZfbvBp9G/CvElb2wV40Ze8svVf0vaPFoLxag3nGd2n 8Q91oMIGim44zcbjEDG7UUf747JYAJ011872CoYUcfgNliqWuyGPfLINv7tqMp3W AVWV6gP2 =ipmO -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+--