Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94910C43217 for ; Wed, 12 Oct 2022 14:21:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D07A484DB3; Wed, 12 Oct 2022 16:21:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="T5Uf5A8j"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50E3384E66; Wed, 12 Oct 2022 16:21:49 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FCDE84DB3 for ; Wed, 12 Oct 2022 16:21:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id r19so2026928qtx.6 for ; Wed, 12 Oct 2022 07:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JDedvmPtUbEN2vg0UO6ZRwdLofY67vWThFJomSL7tl0=; b=T5Uf5A8j31AT22lW8n1lzX82qtz8TmWPazGt7vknQ88mnd5fOfTlmsrOggP6PQq81K fVMKf4XR2Zf5fbY+NjPMaBcbl5JSiOEMFsfTGlNwVVByJsNWAGhRwpjirMpm+JVN9OoU z38GZve0V9tkfk6adWl7htGzvom5tzUeNX0L4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JDedvmPtUbEN2vg0UO6ZRwdLofY67vWThFJomSL7tl0=; b=36kcODhCgSEpBt5qacXfH2wvFqkPlNVbL2cWyTpM6pyyoWh5zsdF7MK5JhVCVYuF7y fBpTrGx4Z63YyF5ZxBAfjJVTNCEFkIfOCVLTs93QW72tgF4HBLYjen4tRZn4zuydToPK QUL8t/1hdsmiURXpDNYMPkvexRF/NJgSp5GRFt5cGooXbgO5tAjEDk7chhf5PyV1RU3D 7NDR9zTbC6t1XdIsR4K2giksQ0R+aSZUsFO/wp/ZqjcgvowTDkozoZU6aWVIudpFcoCr k4sZcqmM74WrqMn0r+HEyYnO4v/etK1lAOnoIYX2oNE/7dyrr/YczEXp8bhO6oNLw7s6 1eXQ== X-Gm-Message-State: ACrzQf2ZnzTDMKpW7+H5/8n0e6SFX3wwK9oVcqQLQ7RkV4T6zkaQkGf4 rLdUbHSz39otrFSuZYY9Sk6Izg== X-Google-Smtp-Source: AMsMyM4SUcJi1m1yjIvkiH4En51v3QMO/CONIdNk03aAxIk1jjCUfzWe6UBfsOLDPorzMh9v9WAOqw== X-Received: by 2002:ac8:7c46:0:b0:35d:147c:38ff with SMTP id o6-20020ac87c46000000b0035d147c38ffmr23566358qtv.1.1665584505073; Wed, 12 Oct 2022 07:21:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-295e-6c71-581f-29f1.res6.spectrum.com. [2603:6081:7b00:6400:295e:6c71:581f:29f1]) by smtp.gmail.com with ESMTPSA id cr12-20020a05622a428c00b003434d3b5938sm12730997qtb.2.2022.10.12.07.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 07:21:44 -0700 (PDT) Date: Wed, 12 Oct 2022 10:21:42 -0400 From: Tom Rini To: Simon Glass Cc: Jit Loon Lim , u-boot@lists.denx.de, Jagan Teki , Vignesh R , Marek , Simon , Tien Fong , Kok Kiang , Siew Chin , Sin Hui , Raaj , Dinesh , Boon Khai , Alif , Teik Heng , Hazim , Sieu Mun Tang Subject: Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT Message-ID: <20221012142142.GV2020586@bill-the-cat> References: <20220902032849.4534-1-jit.loon.lim@intel.com> <20221012124959.GA123158@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AoBLyXwWXtFbU0pZ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --AoBLyXwWXtFbU0pZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > > > > > From: Tien Fong Chee > > > > > > Using imply instead of select for CMD_FAT so overwritten is allowed in > > > later configuration. > > > > > > Signed-off-by: Tien Fong Chee > > > --- > > > Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Kconfig b/Kconfig > > > index 991b260182..71374980e9 100644 > > > --- a/Kconfig > > > +++ b/Kconfig > > > @@ -201,7 +201,7 @@ config DISTRO_DEFAULTS > > > select CMD_ENV_EXISTS > > > select CMD_EXT2 > > > select CMD_EXT4 > > > - select CMD_FAT > > > + imply CMD_FAT > > > select CMD_FS_GENERIC > > > select CMD_PART if PARTITIONS > > > select CMD_PING if CMD_NET > > > > NAK, at least without explaining what the use case here is. A big part > > of generic distro work is "oh, you have that FAT32 ESP to use". >=20 > Isn't that just for EFI? >=20 > In general I try to use 'imply' so it is possible for a board to > disable the option. Calling it an ESP? Yes. Expecting the first partition to be FAT? No, that's a forever-and-ever thing distros have been expecting on x86 and want to see everyone else do too (so their installer logic doesn't have to get further complex). --=20 Tom --AoBLyXwWXtFbU0pZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNGzXIACgkQFHw5/5Y0 tyztaQv/Qk16Q5UY8iFlUfjI+HJ9S2PkX9CiwZPxtiifY0zNTuzEJMp3cbK6QgLy LN3TROPNA/2Dtsrwdkasi6h1fKGOt/ou8QhQDkTgkwKMA7695rMNSVLCh2egc8lA xk/nS+r3G+QZ4xC+Jh+E8o2xaNeuHapddhxifqw4OtFjNcc2b4R7ahRn9pdG5mhP 1h1zxdmXuacsexabd5lD8itFtBWJPV0UTvg2S03yyegYAG3Hm7D4o3gfFEWTvl7R lxxSsfPLXa1A4RMkJud0MzmZ9ewBF1soz8wDsuLQA+e0xHJ97m6Mnj4h3cWdYF3U nP/sBlhEswOxlJVN8QfuMMUxmcFJmphr0sp8BBKun0MhLqw6voK7a0i3/s8OQpn0 qIf+faJO/UiC+ytu+QAeQRFaOg9UYpXbSBkArC6dLYchwSDoxgDkCsaWD9QXV/rH 4LQMpowzS3cssGVwq+TV38HyWxdfezbtOc1DBJzYv1bJiglJX7n8SyL07D0uoFng IT4Sv678 =EQQ3 -----END PGP SIGNATURE----- --AoBLyXwWXtFbU0pZ--