Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9226C433FE for ; Wed, 12 Oct 2022 14:29:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6522F84DB3; Wed, 12 Oct 2022 16:29:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="azPyNYg3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59E2084E44; Wed, 12 Oct 2022 16:29:37 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1549784607 for ; Wed, 12 Oct 2022 16:29:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id a18so7628890qko.0 for ; Wed, 12 Oct 2022 07:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qCe7Hn1a5Wy21aYqZ3ggJS0VXbVEXBOOqV80ry4LXbQ=; b=azPyNYg3tK3kgTacfd6Y24R7q2HkS3pxBu5bK/I1Ts8F9uCCXtUI7/VrALcMe/ynCp 2Ao/RoQDE/Sw8pOcPYyNHUZpR2kphuoQPcf1EHhNslcP3Fy08k9eEVGHXs7c/x5Hgikq nkMD0JjkNqSuFsvgtB1ugN+4zoGVvsLUXjw84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qCe7Hn1a5Wy21aYqZ3ggJS0VXbVEXBOOqV80ry4LXbQ=; b=MCRTla5NOdg3fJJSJsoRFynZOKCgOrcwrwCfgfownnNqVrluL3TOst8iTn/1KFx6My H/fLWBxn1RAUreTWPac7sYoTLKziCTdagDd0IhCff/QogVsPimlVMNpQT4GHHCTUUbRE LljONXAIZu+7QiRrh3Hnu4x9YlMjj+Aiv6T7FX4h6WOmKwn40SjhoVimKL4u8X7IW/Ej cWQmJ4DK+2StCboFu5twc8iwElEgwAJhMmv47Maoy6160InRCYIoVmyyzZjYG1YKJ7G0 ARZsyOSDlNU5Fw5Thmd/xheclF2Vmp2I8JhEUNUIuXU+VOe4YW/qF2cK2+Nmmx8hVRG4 jTQQ== X-Gm-Message-State: ACrzQf379WcZ8OUcT8Cf1qIolH3udKGuwkRORYCMRXA9ix2FPhLcR/pj JhZrEU5tf4zjOtGUH6IAtXtbgg== X-Google-Smtp-Source: AMsMyM5z4fapW043qc+dSrJHiFriw3JbnVb4essUpAtpvYU9RRnxGU3qwEWZ9YhelrHEhLixRWF6GQ== X-Received: by 2002:a37:bbc1:0:b0:6ee:a199:6f02 with SMTP id l184-20020a37bbc1000000b006eea1996f02mr1417076qkf.203.1665584972808; Wed, 12 Oct 2022 07:29:32 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-295e-6c71-581f-29f1.res6.spectrum.com. [2603:6081:7b00:6400:295e:6c71:581f:29f1]) by smtp.gmail.com with ESMTPSA id p16-20020a05620a057000b006bb29d932e1sm5767107qkp.105.2022.10.12.07.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 07:29:32 -0700 (PDT) Date: Wed, 12 Oct 2022 10:29:30 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Rasmus Villemoes , Alper Nebi Yasak Subject: Re: [PATCH 4/5] binman: Use an exit code when blobs are missing Message-ID: <20221012142930.GW2020586@bill-the-cat> References: <20221010200032.73483-1-sjg@chromium.org> <20221010200032.73483-5-sjg@chromium.org> <20221010204056.GV2020586@bill-the-cat> <20221011210513.GH2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s33OSBZCP+C8M/FY" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --s33OSBZCP+C8M/FY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2022 at 06:59:21AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 11 Oct 2022 at 15:05, Tom Rini wrote: > > > > On Mon, Oct 10, 2022 at 04:25:36PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 10 Oct 2022 at 14:41, Tom Rini wrote: > > > > > > > > On Mon, Oct 10, 2022 at 02:00:31PM -0600, Simon Glass wrote: > > > > > > > > > At present binman returns success when told to handle missing blo= bs. > > > > > This is confusing this in fact the resulting image cannot work. > > > > > > > > > > Use exit code 103 to signal this problem, with a -W option to con= vert > > > > > it to a warning. > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > I'm still not sure I like this, rather than changing the default "m= ake" > > > > behavior. > > > > > > I did change that, in the sense that 'make' now fails if there are > > > missing blobs. > > > > > > > And then it gets me a bit worried that we have CI not doing > > > > some other things "right" as we don't want to ignore warnings in CI= , we > > > > want warnings to become errors so that new warnings don't make it > > > > in-tree. > > > > > > That would be quite a big effort, and unrelated to this series. Here > > > are some warning types I'm aware of: > > > > > > - migration > > > - device tree > > > - compiler > > > - missing blobs > > > > > > Do we need a per-board whitelist for warnings? It seems pretty tricky= to me. > > > > > > It is true that warnings are ignored in CI and this does create > > > problems...I'd love to make them into errors if we can. > > > > This is I guess also a related concern. When I say warnings, I mean > > C compiler warnings. That we have flags to suppress "warnings" that are > > other kinds of valid warnings is at least a little confusing. >=20 > Yes. But of course binman doesn't have any other kind of warning, so > so long as we don't propagate that flag further, it makes sense I > think. >=20 > The warnings in U-Boot are at least somewhat out of control IMO, as > per my list above. Well, lets dig down in to those for a minute? For "missing blobs", if we're passing the "fake these blobs" flag AND we don't ever default to passing that flag in regular build rules, I can see making it so that we only see those messages either when we don't pass the fake these blobs flag or we have a verbose option set. For device tree warnings? I think we're mirroring the kernel still in terms of ignoring problems so it's likely a matter of poking board maintainers to resync their trees and/or address the warnings upstream too (which upstream would appreciate). For migration warnings, well, which? Are there some that can be easily done and compile tested? Looking at the Makefile atm, I think the CONFIG_DM migration warning logic can go away as there's no boards missing that. There's nothing in the "this passed so long ago we should delete boards" list, but it would be a good idea (so I'll fire off some builds in a moment) to see who trips up on each and email maintainers. --=20 Tom --s33OSBZCP+C8M/FY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNGz0oACgkQFHw5/5Y0 tyy+ygv/ThPPOSkY8hFv7t8IHHp9IZNeWeA717kOikr32FX4uoYWxarZJtpnxkYL mXyD2vubnNPnQl/4ayuV5cyEamSZ9jDfiBTvgoJBORPe2Zi68/8YWcRXyhsIbD41 JFpJbypzfR9RFuolS1PN28UtWBU9HOdMAnXUUOUEbuXoDZ5Kno7k+dtVAPQFRTUZ i+ivhM3HQV66smyPdfFLaKCCAmSSpkRo715uXxaNJHY6TUFZM4GbNJB3Zd72kvWE Jv+Rx6u/4rwMdKa2oJDrXQ0leyKCI2qRSLxKD4cqSNC7z24rKVHuGSwCq85nXGXh +wW7vMvhsfyNf1QMvnXz/j+LCMaOmAEDuMmGk/H8hz0GtxMGrGwQ0qFT/MlpVmW0 LBkhbcmZtozYdxBWaZOAorGFBo7X6JEXg8nhuuXivqJNcfOLcLZnJJlgCUV2H77E 6ZZ52Zqa3GAXDOreni7GCHIwRttdElpk2LhaEqbzJ0j70oWAph5iCJ69cO/EVI2o bLefLYpn =G6wE -----END PGP SIGNATURE----- --s33OSBZCP+C8M/FY--