Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE345C433FE for ; Wed, 12 Oct 2022 16:50:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E11EA84E4C; Wed, 12 Oct 2022 18:50:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="A6rRXJuK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4E52984E5D; Wed, 12 Oct 2022 18:50:23 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 91BE884DFB for ; Wed, 12 Oct 2022 18:50:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id de14so11256413qvb.5 for ; Wed, 12 Oct 2022 09:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m3vEK9B/T4+nhPi5pAg+k5ACa4Fi472Nc6LACRiQvDQ=; b=A6rRXJuK76l42JZQCkiJwl+tjay427OiqCdpfR9qndp/W7js4jcKAUGQmpxq+xMpFn 1TmuI1EAAxj4jhEGMoQcpPWHuEm7E35vWdjp1LqsXT+KZqOHq3xw8VvGGkiPXQA4bfBv h7/25d3mSy9o/++aj5XZAu1nmJTVKXOkXVrXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m3vEK9B/T4+nhPi5pAg+k5ACa4Fi472Nc6LACRiQvDQ=; b=TrTGzISuwIsTkUGXccnqdm+8RVCIy3rcrdUR4MAhv91NSPOq+79BRJlGWtd+lZ20QC 0ZWAtYIDdcHstqGj/fxyShvjAB8UsenDM8mdk141A7uxq+by4zdlvbetjcrtPJz1SbEi 7rHkqnqeA0Mxfqhzur3VIdmwTwv2oUsfG/MBwwFBdxGHF1tMejwBMqNkx6rW2N15s7wK Eak5zk8pPPOyo8DoH+ACsL0Zff/6EIO2Sqd+DkMdRcf6QIzvxF0CjMa3iwm/401Fp7bn w4wRpGSOV8KiMYwGFC6gwjnpdS5hthqMdTKrza47Q5z6Q1TX/nJjDvNbisYeERLgSTIp qg4Q== X-Gm-Message-State: ACrzQf0TIKPlqcUvqgZ0NK2j+0KYgblK+Yyv/unPT2xIYu1HW71wC6VD aVTFpEu0chlSgb64bt3mnH4vNg== X-Google-Smtp-Source: AMsMyM53HuujzBvCR0JRYFeaPC7oyPT4QrRjBu20RX8tyKgSOQUdHusKy4DuXnfPh1+H5PZvRz2OaQ== X-Received: by 2002:a05:6214:1941:b0:4b1:81aa:b1dd with SMTP id q1-20020a056214194100b004b181aab1ddmr24439787qvk.67.1665593419367; Wed, 12 Oct 2022 09:50:19 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-295e-6c71-581f-29f1.res6.spectrum.com. [2603:6081:7b00:6400:295e:6c71:581f:29f1]) by smtp.gmail.com with ESMTPSA id m186-20020a378ac3000000b006e2d087fd63sm15525750qkd.63.2022.10.12.09.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 09:50:18 -0700 (PDT) Date: Wed, 12 Oct 2022 12:50:16 -0400 From: Tom Rini To: Andrey Skvortsov Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Peter Robinson , Alexander Graf , Vagrant Cascadian , Samuel Holland Subject: Re: [PATCH] distro_bootcmd: Always check for custom boot scripts first Message-ID: <20221012165016.GA328460@bill-the-cat> References: <20220901220616.25814-1-andrej.skvortzov@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <20220901220616.25814-1-andrej.skvortzov@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2022 at 01:06:16AM +0300, Andrey Skvortsov wrote: > If extlinux.conf is used, then it's not possible to customize boot > environment, because scripts are not loaded. > Usually it's possible to make some changes manually using command line > and save boot environment. But if exlinux.conf is loaded > from ext4 partition (for example on PinePhone), then environment are > not saved/loaded at boot time from boot partition and it's not > possible to persistently change boot environment without recompiling > u-boot. >=20 > Signed-off-by: Andrey Skvortsov > --- >=20 > include/config_distro_bootcmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/config_distro_bootcmd.h b/include/config_distro_boot= cmd.h > index 5506f3168f..7f4ef960a1 100644 > --- a/include/config_distro_bootcmd.h > +++ b/include/config_distro_bootcmd.h > @@ -477,8 +477,8 @@ > "echo Scanning ${devtype} " \ > "${devnum}:${distro_bootpart}...; " \ > "for prefix in ${boot_prefixes}; do " \ > - "run scan_dev_for_extlinux; " \ > "run scan_dev_for_scripts; " \ > + "run scan_dev_for_extlinux; " \ > "done;" \ > SCAN_DEV_FOR_EFI \ > "\0" \ Reworking the CC list a bit, I think this works against the intent. If the distro provides extlinux.conf, that's what should be used, and customized by the user (through normal distro methods), rather than looking for a boot script that might be out of date / etc. Can you please elaborate on what you're seeing and trying to do on the PinePhone? --=20 Tom --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNG8EUACgkQFHw5/5Y0 tyxccAv3S3pxtMvP/gm3jdEwOrMeVzKE9ygTlYpCq+/jqj0mIrZp2zYHMRv7nNvm c4/Ek+05AC7vH2l6tYJ4MNFsuFqobKpNm4IEtqEwR48qclX+T/4t7s6YHkkcdkNe 60Kp/L65qU8brKEd9tHzZTpbYf15v1UK0qch6NOBFZj0Yea7qIVLDe+9RVdlPck0 f2AQ0BMQCbllsWRxf+D3LqDsFfmKYTWBCazwfWxXHLqUnT4WB08SVsdLLNdyC26a jXZYxMIQJqZgjUY4A/ttmbzdK+pAkAkiUlyMVK28NrZVcJUwUBdpIsZJAYEHDaWc PaDjB2NP9ArUdhUeZNZLOmBO5HwHDYqBwbPOGCEZLHLYkLIIPtYz4r/ZTvI/XE0W jrc7mvyK58bm5yB8HA1beYI9b/aoMSF8IpDYha2+E9n9xCqGrA2NnEJ7Mr0icmoc mNEPew1lpR+L1eKNCFyeUvlYiVSFrakuL+cizhO63zW93ZXCqyZoX7eFVKsk33cC hSb0NGY= =lQd0 -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--