Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00F71C4332F for ; Wed, 12 Oct 2022 19:15:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C1F5C84F35; Wed, 12 Oct 2022 21:14:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="lY9wg+PI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 257F084F1F; Wed, 12 Oct 2022 21:14:56 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1E9FF84F22 for ; Wed, 12 Oct 2022 21:14:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id h15so6690875qtu.2 for ; Wed, 12 Oct 2022 12:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KXta3o7FjF5O8CV59smeO7lEDEEstwPzQeUJNemR9Ic=; b=lY9wg+PIoFbNdAjuRHLbYe9hccx1orFZMKhoi3XYK8bZa/65xqoJAPCIs0FUi1Iys6 CslCgJd7DoYMqJhBmPrOyJgdhK5vASRahkh3r0Kj9tyQe2Pvfi0CvhTzGL+9h5A/XH9H Alk5Cqdn27xce1446W6sONZPsXZFwkvYtoLtU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KXta3o7FjF5O8CV59smeO7lEDEEstwPzQeUJNemR9Ic=; b=BtdkVwSMY8SJhx2yJd5E2je7B9Z3kZHld9goT6/Lrx9Hnb8t/hZNnm76gHqjrq26HW vjXpudkizHPv6BB3yYQDLBLkf9nz9ze3EiWMc3DzdjjacsB5mAyyZ/3Hm9HflVXekfPy QAEO4Vba1mHI3RjiJxrUVyrNDSi11DAMHGPRp7K3NNLdmVlvOTr19Da+Ku+OTqjEeN81 IRHf2P/NahoZ0Z31Qmtw7XYloWHPDiCD6JWp647O0ICdMQzwEuu4ORHIWFeBrwNrVb4t Zj1JWcSVXmnEOcNsdKhdk0njPfxf1KaaUdNC7eQmkfxoztKWQbgiDvxGBDDKl/9UF5Pa B8uQ== X-Gm-Message-State: ACrzQf2q6y0t+HVZkZQCYlgID5qqunftb3C5nRmyfQisQ3iwYqytAHIx mkWaFa8QXWEtr+dB5x5xTIrL7OP2KN1juA== X-Google-Smtp-Source: AMsMyM4PgTTmtJP+865HCrXYk2oeFBfpNwIt2sANI+bCEbTVk/OEFEsOar78uxF9hehRsb2Nwkn+IA== X-Received: by 2002:a05:622a:14d:b0:39c:c531:2506 with SMTP id v13-20020a05622a014d00b0039cc5312506mr2849202qtw.13.1665602091924; Wed, 12 Oct 2022 12:14:51 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-295e-6c71-581f-29f1.res6.spectrum.com. [2603:6081:7b00:6400:295e:6c71:581f:29f1]) by smtp.gmail.com with ESMTPSA id m19-20020a05620a24d300b006cbb8ca04f8sm17427496qkn.40.2022.10.12.12.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 12:14:51 -0700 (PDT) Date: Wed, 12 Oct 2022 15:14:49 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, maemo-leste@lists.dyne.org Subject: Re: [PATCH] Nokia RX-51: Fix double space key press Message-ID: <20221012191449.GG2020586@bill-the-cat> References: <20221009193825.12854-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sIsKpy5+/8vj5Foo" Content-Disposition: inline In-Reply-To: <20221009193825.12854-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --sIsKpy5+/8vj5Foo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 09:38:25PM +0200, Pali Roh=E1r wrote: > Space key is indicated by two different bits. Some HW models indicate pre= ss > of space key only by the first bit. Qemu indicates it by both bits at the > same time, which is currently interpreted by u-boot as double key press. >=20 > Fix this issue by setting first bit when only second is set (to support HW > models which indicate press only by second bit) and always clearing second > bit before processing to not report double space key press. >=20 > Signed-off-by: Pali Roh=E1r Applied to u-boot/master, thanks! --=20 Tom --sIsKpy5+/8vj5Foo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNHEikACgkQFHw5/5Y0 tyxemAv9HR24wYjSWtgbIfbY1z4ktKKiVXf6caqiXpYPTcNfnxubwarUejnC2j7j VIzpM4+zRSr+NJWzKZwOUzODFEcON9QRpMIA8gpqqfYZhkRyvecguKFisZvCeTB7 YYLFcVVaTqzoSY0ECvT7yuAn9CqoMmXcRgJ3M0WlqQJe8OS0p4NAeb50HMg5NN6W zmYITt7QWDcKcfAo2mua39YSAsCp+KBSqnuwQjL6ffnBDv6oH32aaaL60Sr23JI8 8deT1qTPy9QtvXWyhLp7aF/WT8QZXmESxgqTvzRmo/pLMX5g3OZQ7VzK4tDb5fVm WcDqS1HTDYe8Dd20sN3pihbnBFM1+osb4PRsth7Crdtp3mffTjoHaEC2nUE9XHx2 x952+Z0RfQMt1XY1FAF7CUVftaANwVZunb+DUmzaHffzDq/kbLgb9wQX1/jwLw3O lu7qz7vG5b6WmKWEsezanezkOaHKT0xeBXElsZWpbQl7ZO59KB0JbVil7WXmjFii xI8bPV41 =WT9n -----END PGP SIGNATURE----- --sIsKpy5+/8vj5Foo--