Return-Path: Date: Thu, 13 Oct 2022 12:16:35 +0200 From: Florian Westphal Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible Message-ID: <20221013101635.GB11818@breakpoint.cc> References: <20221010230613.1076905-1-Jason@zx2c4.com> <20221010230613.1076905-6-Jason@zx2c4.com> <3026360.ZldQQBzMgz@eto.sf-tec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3026360.ZldQQBzMgz@eto.sf-tec.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Rolf Eike Beer Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, "Jason A. Donenfeld" , Andrew Morton , Florian Westphal , Herbert Xu , Thomas Graf , kasan-dev@googlegroups.com, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Rolf Eike Beer wrote: > Florian, can you comment and maybe fix it? Can't comment, do not remember -- this was 5 years ago. > Or you wanted to move the variable before the loop and keep the random state > between the loops and only reseed when all '1' bits have been consumed. Probably. No clue, best to NOT change it to not block Jasons series and then just simplify this and remove all the useless shifts. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um