Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F550C433FE for ; Fri, 14 Oct 2022 13:13:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0F3EF84CEC; Fri, 14 Oct 2022 15:13:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MFb/jt8L"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F47884B9E; Fri, 14 Oct 2022 15:13:23 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DBF1084D60 for ; Fri, 14 Oct 2022 15:13:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id x13so2364623qkg.11 for ; Fri, 14 Oct 2022 06:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U7DdudUdM4UepOQU2vDoTA04OxGhdzDHz6tiMCGBfqo=; b=MFb/jt8Lnm8dn1aiSjWgoNd2z4dl1SQmwEl2wqWxqLlo9YSqXPhz83yRp1xzhHpLhk Pya04iLNu8JK8f4los7vAah2Dqb5C9HAS6WLo0BDy9JejcCDtLg/Yk91s/Wxi6toXUYf R7ZZN+f6pjreYAVlBgSbd5UXHbU41WqqIlXDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U7DdudUdM4UepOQU2vDoTA04OxGhdzDHz6tiMCGBfqo=; b=cdr3+Rt26xsOb06ohKKeGg8lEhhrHksg+a/oDcKfrrkdggwZk0qyeCi+mrvYD8+9cv oAKzGfEidiz1MS8llCJWCV8SxckBTGeLV5Eb0I+9hoYNsFTdyoETeKR6J/Tb6T7PMNJP y9yelIZXGjgts4XEkSjxMavXjdFd/ytwAWmT/Mo8WFNewaZx9Ht+4Fpb5i94xFOQS4KL y3q13qvinBqZzJL85eTI18NtzwfQklKzMAjjUaPQrcFOM9C53WkaPrYP+kPfkqHwMeFn xXVdEEVX1DfoEfSroIr33EJE6c4Mlkuk5iXO5V24JX0MPgIeZKc452gqOHqo07u26QPI 1E0g== X-Gm-Message-State: ACrzQf3me50hUR0Cx57GseDSB5FV+d8qLoTv3Lba0QM0U58YjJYlhKra JxwvxZ/KJeG/S7ZWipmvcmsVRg== X-Google-Smtp-Source: AMsMyM4Mj7pKUXbHwUJkq2YIUvUZnQX19qJQEEQSc//OKiNi8WAk2Iw0Y1Lvtpeesxqg04ZIUnGdXw== X-Received: by 2002:a05:620a:e16:b0:6ee:82bf:188c with SMTP id y22-20020a05620a0e1600b006ee82bf188cmr3593328qkm.198.1665753198524; Fri, 14 Oct 2022 06:13:18 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id o5-20020a05620a228500b006ee94c5bf26sm2193233qkh.91.2022.10.14.06.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 06:13:17 -0700 (PDT) Date: Fri, 14 Oct 2022 09:13:15 -0400 From: Tom Rini To: Jan Kiszka , Simon Glass Cc: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014131315.GM2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9/uPS4O9TzVxv0qR" Content-Disposition: inline In-Reply-To: <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --9/uPS4O9TzVxv0qR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > On 21.10.21 01:34, Heinrich Schuchardt wrote: > > On 9/25/21 2:30 AM, Simon Glass wrote: > >> This code should never have been added as it builds a new feature on t= op > >> of legacy code. This has already been improved with the dependency on > >> BLK. > >> > >> Add a dependency on DM_ETH also, to avoid needing to deal with this old > >> code. > >> > >> Boards which want EFI_LOADER should migrate to driver model first. > >> > >> Note this patch is included to resolve the following build error: > >> > >> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_TEXT_B= ASE=E2=80=99 > >> =C2=A0=C2=A0=C2=A0=C2=A0undeclared (first use in this function); did y= ou mean > >> =C2=A0=C2=A0=C2=A0=C2=A0=E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > >> =C2=A0=C2=A0 680 |=C2=A0=C2=A0 ulong base =3D CONFIG_SYS_TEXT_BASE; > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~~= ~~~~~~ > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CONFIG_SYS_SRA= M_BASE > >> > >> Signed-off-by: Simon Glass > >=20 > > Reviewed-by: Heinrich Schuchardt > >=20 >=20 > How to deal with boards that need CONFIG_NET but do not actually > implement any driver (yet)? This now broke UEFI for the IOT2050 which > needs NET for network-related device tree setup (see also [1]) and > enforces a local hack for us. Yes, looking at the patch, this should probably use NETDEVICES and not NET as the test? Would that fix your problem, Jan? --=20 Tom --9/uPS4O9TzVxv0qR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJYGgACgkQFHw5/5Y0 tyxSnQwAiUrgTVbz+7Ym2XWztU4ctIZ8r0fGiOoiJw1n0CGvMDhSdJNwzsARlpFp 8JiN0/eGD+guWQ7IjwQVGhapw+BreTe6K9qgsX1w1KMSp+3SMu3eY9qHTeBM0nbG +TqZk2HtSLMupuPv7PURUenCavU21oSMZnDb7KCzXBE21DLpFH3ReebRiEP/ZI2W hNdd+jHSMBkWWdQ2XbEGSq4spnmg6TAyJU84f9FoT/Ug0PhucEU87DNVplXagG+y opaK+YpUXyN6kiaC9K+riLipYPBPSF0FfVpxNdZblTqeCXgzYE9R1HWllOfX8D8D V/CWAWOEszTgtGUIyrptzxvUXPDuHQkx7u0C6+0VrcfLQX9BJLTMVyReBO1ifs3z EM/NaRMGqNVaqVxa+9oxQoe8UFFuwDshsfOodSkhZ8Wmt/P7zLocZo8KN0U9r59F G524egpSJzVZqvTU8wF1R86oYHaPdbHiKI+cDUE7a1FiIfONNW6qmKXaS5kVv/bX aLeXxktS =bPGu -----END PGP SIGNATURE----- --9/uPS4O9TzVxv0qR--