Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 082A5C433FE for ; Fri, 14 Oct 2022 16:08:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A2CB84575; Fri, 14 Oct 2022 18:08:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WRCD6DNr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D5D7D8456E; Fri, 14 Oct 2022 18:08:20 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F0BFD84575 for ; Fri, 14 Oct 2022 18:08:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id 8so2759821qka.1 for ; Fri, 14 Oct 2022 09:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NqkSeu6dpN+rkpq8dcKjXwW5PcC5z3tZxZrwKQZdI2Q=; b=WRCD6DNrG/ZMh7TizqcT42G5hFfCsVGxELp8tybluXlzJzePqzNU2buk0qTnI5gFHP eyg4+4BHur5+gaYg9UYuuzK/yzyWNth0Wj0pmEDYoGrdEXLojD6qQ2DmRk7lCtgaZhDj 8RrFG9geI4KVCwGvKb57wPdQvaDw8sMHbC98w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NqkSeu6dpN+rkpq8dcKjXwW5PcC5z3tZxZrwKQZdI2Q=; b=8CRkF47Z19yjMFpD8wqmjxTcvFifxofBqk3aA3/ZvxOmvPAcSnLBj0vpeGStAQ2+cT Mse6gPQngJs/qD77CLWWOgsfbvfDwjGkeBLD6Rg/EYBgiduRkf0j23cRF3w4neAzJCfD Vsd90+Qe6/XyiLrjUPFToliJKXwwpC/kB/6N5M8JlyzVn4jDeHBQAn3kCIGNaG9XbRK9 i9Ow3NydNU+0naFoEdS0EIfxeTIpbXZT33FXkBcnRr3UTbAVlMksTGeSrs9JEa0c55KD tMxYglEt6Kcbi9eyJ0ISojLb0R+mymWzsLfm73qhnaQS+X8BPBsUBN8NwYkGOpjXd7uX mbzA== X-Gm-Message-State: ACrzQf2tJJI2+1A1OQQ0ezt4Udg0ID2j7iuSUejSID7mlhgeR9AOW1Xp Ml5HAK318wd4Uv4YXkFMrO7UNA== X-Google-Smtp-Source: AMsMyM6CERMFa8RGSYQFRS8w1ULJfx3++8fGfZY/Mm/SYLXnjWaVnydPmIRJk3Fwl8P4BMgdPMdtSQ== X-Received: by 2002:a05:620a:1a9d:b0:6cb:e3f3:eb3c with SMTP id bl29-20020a05620a1a9d00b006cbe3f3eb3cmr4238284qkb.711.1665763696668; Fri, 14 Oct 2022 09:08:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id e10-20020a37ac0a000000b006ee91ab3538sm2622339qkm.36.2022.10.14.09.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 09:08:16 -0700 (PDT) Date: Fri, 14 Oct 2022 12:08:13 -0400 From: Tom Rini To: Simon Glass Cc: Jit Loon Lim , u-boot@lists.denx.de, Jagan Teki , Vignesh R , Marek , Simon , Tien Fong , Kok Kiang , Siew Chin , Sin Hui , Raaj , Dinesh , Boon Khai , Alif , Teik Heng , Hazim , Sieu Mun Tang Subject: Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT Message-ID: <20221014160813.GY2020586@bill-the-cat> References: <20220902032849.4534-1-jit.loon.lim@intel.com> <20221012124959.GA123158@bill-the-cat> <20221012142142.GV2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yf+QnTYkcH7pT0Mu" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --yf+QnTYkcH7pT0Mu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 09:55:47AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 12 Oct 2022 at 08:21, Tom Rini wrote: > > > > On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > > > > > > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > > > > > > > > > From: Tien Fong Chee > > > > > > > > > > Using imply instead of select for CMD_FAT so overwritten is allow= ed in > > > > > later configuration. > > > > > > > > > > Signed-off-by: Tien Fong Chee > > > > > --- > > > > > Kconfig | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/Kconfig b/Kconfig > > > > > index 991b260182..71374980e9 100644 > > > > > --- a/Kconfig > > > > > +++ b/Kconfig > > > > > @@ -201,7 +201,7 @@ config DISTRO_DEFAULTS > > > > > select CMD_ENV_EXISTS > > > > > select CMD_EXT2 > > > > > select CMD_EXT4 > > > > > - select CMD_FAT > > > > > + imply CMD_FAT > > > > > select CMD_FS_GENERIC > > > > > select CMD_PART if PARTITIONS > > > > > select CMD_PING if CMD_NET > > > > > > > > NAK, at least without explaining what the use case here is. A big p= art > > > > of generic distro work is "oh, you have that FAT32 ESP to use". > > > > > > Isn't that just for EFI? > > > > > > In general I try to use 'imply' so it is possible for a board to > > > disable the option. > > > > Calling it an ESP? Yes. Expecting the first partition to be FAT? No, > > that's a forever-and-ever thing distros have been expecting on x86 and > > want to see everyone else do too (so their installer logic doesn't have > > to get further complex). >=20 > OK I See. Well, 'imply' is more friendly since it allows the choice, > if the function is not used. In fact 'DISTRO_DEFAULTS' is mostly > DISTRO_REQUIRED at this point :-) Well, yes. It's supposed to be thee option that you set and then all of the common general Linux distros (and the BSD families have adopted this as well) Just Work, so it needs to be selecting. --=20 Tom --yf+QnTYkcH7pT0Mu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJiW0ACgkQFHw5/5Y0 tywACQv+PRTeWXhGbll7zTbwreGnJv7i/dt01MhAzks55kCq16EsDxN1DAK6IeyF zwrKJt1apbSeydJ0vczkk6bjE1t+70yerCn95CG7wY+o7zsRvcYmJJC8vgxa0XHH qOcmYYxUtLRF1FIrebnDE2agDz9lkObg1daaS1PP6npK//reBdcyFfT+FfXs3kFe anacqtZ9al86YkSK5tB2ExrbH7/YKHMFsUD8oX1NbeI4yX8JIghQqjE0XKg0FhaA 63W0ponG74rv+4HZZMJojVPMRDRwd7QzEMMsbM9K0St3UtlO4WaxcySdL5wyo+45 XGIK1SL6edu+mjPc8kx/MqYLB7oyrzt/RRXa7y3M0K2oPQTlg0PgzFz8OgrIC/vW eCMt8JOtBWqfV6qdO/naTO4AXDNl2h6S7uo4xaZ30Tre1oJzF+xuU9EG1ShhT1la SITUGch6wM47jfVQV2u1D5+FYfSPtbO3wWRtLCtgNwkIy5XGh3eJyYMVc8mCfkBU o51VQjS9 =+kAQ -----END PGP SIGNATURE----- --yf+QnTYkcH7pT0Mu--