Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DA23C433FE for ; Fri, 14 Oct 2022 16:46:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A83D84BDB; Fri, 14 Oct 2022 18:46:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LFTHdbCJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20F2184DFC; Fri, 14 Oct 2022 18:46:29 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E81C84B42 for ; Fri, 14 Oct 2022 18:46:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id de14so3591072qvb.5 for ; Fri, 14 Oct 2022 09:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sieXxpCLq4SNrOhJ9X/s+iEUYxHn3sPQpdSWWbHWuOA=; b=LFTHdbCJMT8X7jKIhE+P1ibxTCa7CFYozD6ZdXiamIfHoE3q1d2Kzowy9G4/Bh9y4c YcUZXPrPjJO685AZO14jRe/S8PMpU01g1TwVXezYRWi/LmgNaqNi+ak/PS3LB7fgv0Xp ewInG+zFDRbKfYb5wEWdrMYWrCZPs42jJx4K0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sieXxpCLq4SNrOhJ9X/s+iEUYxHn3sPQpdSWWbHWuOA=; b=I6N0qfom99Tibupuq9uAFHei452uwxJcb9sE2/2Q8CDVuSGgDsJq2QhthBJpqHqB1n fSUxajnTWoMl5xLSP+Ov7Ubz0WH4qmnqhIiEQXSUGtLHmEzCrJrcW793Sp0ioFSxUovy 0clKYu4SEx9iqlv4Y8RV7ZgblkXI6HqTmKDVt1aE7ArV434C592ckBsn7Qzo9HHKJaWt HKGoqxDC3tr0CyI2bGd4Xo6c6tjiObvtSzB71B18GtrHyBs/oPwIWO628rJPIqrCaW/e +B1hxEgXSRNroopZrIowoAbZjGJqTy8WCdOqmlo7GjFdZ01GuJGDjpu9qwb7p12hvDQn I+JA== X-Gm-Message-State: ACrzQf3DHgtbTFvYToao1j3EFLF+QLJIVZ2DqGS8uE/BuBoha0VuGtCi 19PT+fWFLhjGXaJ/Ti3bUBrEWocRtrPL1Q== X-Google-Smtp-Source: AMsMyM4onBWsYULMmkPMckIb5ejhdrcSx6OWjyu8BNQaMndhhyCAIkUrwV4BHrsPUGjzRdCcPiQUww== X-Received: by 2002:a0c:9c8b:0:b0:4b1:ac82:5c50 with SMTP id i11-20020a0c9c8b000000b004b1ac825c50mr5036522qvf.15.1665765985064; Fri, 14 Oct 2022 09:46:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a0d8600b006cf9084f7d0sm2825187qkl.4.2022.10.14.09.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 09:46:24 -0700 (PDT) Date: Fri, 14 Oct 2022 12:46:22 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, maemo-leste@lists.dyne.org Subject: Re: [PATCH] Nokia RX-51: Fix compilation with non-zero CONFIG_SYS_TEXT_BASE Message-ID: <20221014164622.GA2020586@bill-the-cat> References: <20221009193713.12765-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lBnNT+4yy4PYvQEb" Content-Disposition: inline In-Reply-To: <20221009193713.12765-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --lBnNT+4yy4PYvQEb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 09:37:13PM +0200, Pali Roh=E1r wrote: > For some unknown reason GNU assembler version 2.31.1 (arm-linux-gnueabi-as > from Debian Buster) cannot compile following code from located in file > board/nokia/rx51/lowlevel_init.S: >=20 > kernoffs: > .word KERNEL_OFFSET - (. - CONFIG_SYS_TEXT_BASE) >=20 > when CONFIG_SYS_TEXT_BASE is set to 0x80008000. It throws strange compile > error which is even without line number: >=20 > AS board/nokia/rx51/lowlevel_init.o > {standard input}: Assembler messages: > {standard input}: Error: attempt to get value of unresolved symbol `L0' > make[2]: *** [scripts/Makefile.build:293: board/nokia/rx51/lowlevel_ini= t.o] Error 1 >=20 > I have no idea about this error and my experiments showed that ARM GNU > assembler is happy with negation of that number. So changing code to: >=20 > kernoffs: > .word . - CONFIG_SYS_TEXT_BASE - KERNEL_OFFSET >=20 > and then replacing mathematical addition by substraction of "kernoffs" > value (so calculation of address does not change) compiles assembler file > without any error now. >=20 > There should be not any functional change. >=20 > Signed-off-by: Pali Roh=E1r Thanks for following up with upstream here. I see they didn't answer your final question, but my read of the series is that what you're doing here should always work. Reviewed-by: Tom Rini Link: https://sourceware.org/pipermail/binutils/2022-October/123472.html --=20 Tom --lBnNT+4yy4PYvQEb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJkl4ACgkQFHw5/5Y0 tyxs4Qv4yDoHIeuZ7fPGpSrwOi63Zs8Kk15OnMia7d1YCOqBQSAhFHLwKUo8RZvd uRIqR32TEzEtvVpN2FyJ7IvYCt45WUamGXqZkBMuNanVYYfB8StxysOfC/RdQito SEuYu3HKIUA2xRL99kgYM9mgubd5hAGPZwnwXRe5LfOUuzbCJqhrlaxM2vhl1E0m YASqFPzknUYKqc6rt79LOHwybL7Za6VisIuqZADYpYy4elvdc3BC08alsEE/Ea9w btAv8ytRtq9XlsRHzi0xPLqgP0UdnqB/9ts7PkHTL3o+t3eXfKglGlM2HQFp/UmI bH4Y22LxlYr0XsRTHGmYTw5TURAZWkRS33gV5uGxV8VCW0eMJvLjGohUTLXFhUdt LyHpCtTzCfMatJyJgq1uYGMFROHeeIoVtUt7vsI+ZSp3A5+yXvQBFDObxR1xwMEp oRa3YyKywU+OYDCyaWD7WbLZZlHZsqbWPeIgWq8xXUUuHTcKujjb5UxSwlBKIuuk HNAYupg= =m4OP -----END PGP SIGNATURE----- --lBnNT+4yy4PYvQEb--