Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 868CAC433FE for ; Sun, 16 Oct 2022 10:16:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C5B384CBC; Sun, 16 Oct 2022 12:16:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bAWVXfBA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2EED84D39; Sun, 16 Oct 2022 12:16:04 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38F5A84575 for ; Sun, 16 Oct 2022 12:16:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CB4F60AF4; Sun, 16 Oct 2022 10:16:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A587C433D6; Sun, 16 Oct 2022 10:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665915359; bh=WCeuVLv8Er1jXfLJc8gZ3NV/CyY02RPFK6vCRmVCAqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bAWVXfBAmNWbwaaX9iuvmgpr9B2a3amDy8JnFAygFQqrOocQfb3wFEpbb2yMkG2j0 tpOY1o0YkWptZgdku7L9hKjXfDG/f7rqOeDlg8N78FKUVkSWMrYydgH6Yc4dBYYV0d AoXX+mMrfxd5CloC5hX5Zok7C4KFminROnn7qBFFVDaI8MO5yqKISIyqJPYdAODynZ adYYFNvU1IU33ifYjh1jbHBqaWMreaY1HcyibAa7YjbQw2Kyhs57czECiKVPIOrAnB 0Xb527QDvpsRheQwMA1shUlDvmNj6T/kSGhpduW2jDg8mPmIUiSwN+nGWlBSImvo0/ UDKYENoJsf4LQ== Received: by pali.im (Postfix) id 6656CA3A; Sun, 16 Oct 2022 12:15:56 +0200 (CEST) Date: Sun, 16 Oct 2022 12:15:56 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Masahiro Yamada Cc: Simon Glass , U-Boot Mailing List , Quentin Schulz , Rasmus Villemoes , Tom Rini , Heinrich Schuchardt , Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH v2 2/5] Makefile: Correct a missing FORCE on the binman rule Message-ID: <20221016101556.3b7rtnijfzfbg5cb@pali> References: <20221011141541.538175-1-sjg@chromium.org> <20221011141541.538175-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tuesday 11 October 2022 23:35:22 Masahiro Yamada wrote: > On Tue, Oct 11, 2022 at 11:16 PM Simon Glass wrote: > > > > This is required for if_changed to work correctly. Add it. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Pali Rohár > > --- > > > > (no changes since v1) > > > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 3866cc62f9a..d28e8b4e316 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1111,7 +1111,7 @@ endef > > PHONY += inputs > > inputs: $(INPUTS-y) > > > > -all: .binman_stamp inputs > > +all: .binman_stamp inputs FORCE > > ifeq ($(CONFIG_BINMAN),y) > > $(call if_changed,binman) > > > > 'all' is usually used as a phony target. > > > I think this went wrong. > > if_changed should never be used for a phony target. > In other words, if_changed should produce a build artifact. > > > > FORCE is never used for a phony target because > it is added to 'PHONY'. > > PHONY += all > > I agree, this is really written in the wrong way. Target "all:" should be really phony target and should only depends on other target, it should not have any body / commands. And binman call should be moved to different non-phony target with the correct output file name. > > > > > endif > > -- > > 2.38.0.rc1.362.ged0d419d3c-goog > >