Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB3DE10F7 for ; Mon, 17 Oct 2022 10:25:12 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 054EA1C0016; Mon, 17 Oct 2022 12:25:04 +0200 (CEST) Date: Mon, 17 Oct 2022 12:25:03 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Nathan Chancellor , Jakub Kicinski , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ndesaulniers@google.com, mkl@pengutronix.de, thomas.lendacky@amd.com, khalasa@piap.pl, wsa+renesas@sang-engineering.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.9 11/16] net: korina: Fix return type of korina_send_packet Message-ID: <20221017102503.GA15612@duo.ucw.cz> References: <20221009222713.1220394-1-sashal@kernel.org> <20221009222713.1220394-11-sashal@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20221009222713.1220394-11-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Nathan Huckleberry >=20 > [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ] >=20 > The ndo_start_xmit field in net_device_ops is expected to be of type > netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev= ). >=20 > The mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. >=20 > The return type of korina_send_packet should be changed from int to > netdev_tx_t. Patches 4-6, 9-11: I see this is nice cleanup for mainline, but ... do we have CFI in 4.9 tree? This mismatch does not and can not cause any problems there, right? Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY00tfwAKCRAw5/Bqldv6 8mtRAJ94X1njpj6/XfCoNQNa5Y6rpMWa7gCfemw2E8vG+r/YzUn0hGYsaq3HTqA= =iw2O -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--