Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1okNmG-0006al-2s for mharc-qemu-trivial@gnu.org; Mon, 17 Oct 2022 06:55:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okNmE-0006aS-40 for qemu-trivial@nongnu.org; Mon, 17 Oct 2022 06:55:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:24505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okNm8-00081U-QH for qemu-trivial@nongnu.org; Mon, 17 Oct 2022 06:55:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666004114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hSH4fqNhQ/VLQKfFgArWmXI3WmNksLKbby+lFIcBHUI=; b=QbfLy3CdgN3tBUMrrTHVZa7ylnzGMIqmkTRbsQTcLOFgXi/r0rgDSKrRDZx7w+9I80af1M sGYsnnqrctT38QsymO1rEqfbA5k7Wf++v4giHYj07B2p6O2lOeh/prxUZtQVeSfgz7Q/lz I9IOpkqoRGfM1kOrID10B6cWseFZgK8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-td1jqVpxMIaBr2zJ_K24aw-1; Mon, 17 Oct 2022 06:55:13 -0400 X-MC-Unique: td1jqVpxMIaBr2zJ_K24aw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CEB8B882822; Mon, 17 Oct 2022 10:55:12 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B764409AE9; Mon, 17 Oct 2022 10:55:09 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, bin.meng@windriver.com Cc: qemu-trivial@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" Subject: [PATCH] tests/qtest/migration-test: Do not try to print NULL pointer string Date: Mon, 17 Oct 2022 12:55:06 +0200 Message-Id: <20221017105506.69149-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 10:55:22 -0000 If tmpfs is NULL, we should not try to print it as a string. Reported-by: shengjiangwuqq on github.com Fixes: e5553c1b8d ("tests/qtest: migration-test: Avoid using hardcoded /tmp") Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index ef4427ff4d..de70611f50 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -2481,8 +2481,7 @@ int main(int argc, char **argv) tmpfs = g_dir_make_tmp("migration-test-XXXXXX", &err); if (!tmpfs) { - g_test_message("g_dir_make_tmp on path (%s): %s", tmpfs, - err->message); + g_test_message("g_dir_make_tmp failed: %s", err->message); } g_assert(tmpfs); -- 2.31.1