Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B671C4332F for ; Tue, 18 Oct 2022 17:40:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77BC184EFB; Tue, 18 Oct 2022 19:40:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="q9psXvOX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 660E584F1B; Tue, 18 Oct 2022 19:40:32 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A04BD84E9B for ; Tue, 18 Oct 2022 19:40:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id z8so10139572qtv.5 for ; Tue, 18 Oct 2022 10:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TB81WC5Lx88AqFgGem4d6hxcMGjgua6pyLIAFlClK70=; b=q9psXvOXZIKLIbZE08QCWLPrpG1TLa9lgS7WhOKWNtoNehemndBcwMCO3d15pq4y8R 0GeF33NvD0U/ioofCE866Ps9nlN9DUPEyDc58LItgAsp2oCB/PXWw/UXWoYPZ3OwbTP+ faYWmNbbex0+jQjf0zS19izl+KTyzIyuwkptM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TB81WC5Lx88AqFgGem4d6hxcMGjgua6pyLIAFlClK70=; b=A+HCOknhjKfklAWP5kMNu7dJCoEwSRtF3BnBt0+kyY2Gn8WW7LmLHAV6Oxb5bZVvQr S2xm58+dMx0+UAOKrYgxj0HBDvpaWhZqKrd9a+f1zhgoWg2w9AcNF/R1SC3JJe9Kdg0Y O3sQItZxqqhoeHCmlEUCuo53CSh3pW5aqY/0J68SkBXpZixM2pUHfxeb7me1k1uRu88T llxjrl3rj9VMc+ws7++FE+vhQBVtcNt/RIGVFalu1OQ1ji9LzNdxSyxzjEmQDWwQ6Ets rUDTRyRDJjnfZO5pJjgg6ZFwglG/q88IExNEhZZMW6utyvh68fpqOr1BPaPIYHvSngR6 YUWQ== X-Gm-Message-State: ACrzQf2i1g0DO5Zx47EBTHqJhOZ6WtnTfSwBv2taee1cvSFD0OyYNbdm BMedE86fJd0Vwx57Q66/YEAudw== X-Google-Smtp-Source: AMsMyM647zJrnXRszmn67u9QB54saRPhjIF+F9IpElJN+6065p/mnrufhUUZS/HJzQxZN//dlcW3cA== X-Received: by 2002:a05:622a:48b:b0:39c:c920:d8fd with SMTP id p11-20020a05622a048b00b0039cc920d8fdmr3089446qtx.330.1666114828383; Tue, 18 Oct 2022 10:40:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9c58-0588-a5a5-a6b0.res6.spectrum.com. [2603:6081:7b00:6400:9c58:588:a5a5:a6b0]) by smtp.gmail.com with ESMTPSA id fz24-20020a05622a5a9800b0039cc0fbdb61sm2305153qtb.53.2022.10.18.10.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 10:40:27 -0700 (PDT) Date: Tue, 18 Oct 2022 13:40:25 -0400 From: Tom Rini To: Roger Quadros Cc: sjg@chromium.org, u-boot@lists.denx.de, praneeth@ti.com, kishon@ti.com, Patrick Delaunay , Patrice Chotard Subject: Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL Message-ID: <20221018174025.GA2412547@bill-the-cat> References: <20221006132400.5628-1-rogerq@kernel.org> <20221006132400.5628-3-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20221006132400.5628-3-rogerq@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote: > We will need ti-gpmc driver for SPL. Allow memory drivers > do be built for SPL. >=20 > Signed-off-by: Roger Quadros > --- > scripts/Makefile.spl | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index 3bafeb4fe9..110076b22f 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -114,6 +114,7 @@ libs-$(CONFIG_PARTITIONS) +=3D disk/ > endif > =20 > libs-y +=3D drivers/ > +libs-y +=3D drivers/memory/ > libs-$(CONFIG_SPL_USB_GADGET) +=3D drivers/usb/dwc3/ > libs-$(CONFIG_SPL_USB_GADGET) +=3D drivers/usb/cdns3/ > libs-y +=3D dts/ This ends up being the wrong approach as it then pulls in drivers/memory/stm32-fmc2-ebi.o on all of those platforms, in SPL, which is not what's intended. We need an SPL_MEMORY symbol and then gate the directory on that. --=20 Tom --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNO5QcACgkQFHw5/5Y0 tyxvGQwAgRX9wo366S77PY8x7Vbb33s11TzRSqEpjKeWBe2iobsvqdeqotND7xCN Z1AcMfoOMH7Y0P3tLJGbJHB7TZMGkQB7/bIJo2HgDN4+YkH+gLSBmAIaeEhiEmY9 r7xQDG3vfUs8Y13xVIXd0HAePb9TFClEnyrwdeYGzSFhhpRw7oEnTIAp+hxudEMo XOsUXD6uPyySXFd7OIV8FfqdxOoRVzkWGdtu6lJ10q8mBnth0L1MmUJ9dwfX3rWp TFQ/aQYQcR9Or2L1wiGntKXVpZLkpsBReEKeZYe1BZcdvNiuYO0bdPSBYzMBLAtd KjfI9a4sOPPm0rn+AStyBnCJXebLyNgVwwsjSX+vYQfGfNYxBBQPeskBnYKE4A0G NyvJ0UDYpCi+V2jCTBp4NiXHR0TTGNoo8tQk8S0+27jrJvJ/C5yGEf2Ige3KYBiT F+Juj7stogC7osvNFXzYiZJ77C98rmvyQRTux1JGocpwcH5cUtvoEB3w1gfUnmlc HBl+G3Hw =BqB/ -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--