Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 134DBC4332F for ; Tue, 18 Oct 2022 22:17:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 404FA84FAB; Wed, 19 Oct 2022 00:17:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Qn/r9q9T"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 630DD84F90; Wed, 19 Oct 2022 00:16:14 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8F6C84F8F for ; Wed, 19 Oct 2022 00:16:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72e.google.com with SMTP id x13so9613923qkg.11 for ; Tue, 18 Oct 2022 15:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dU+Wc58WfE7Ib4kxZTzxbG+WqkxMC9yPZftznIKZ/e4=; b=Qn/r9q9T5udGUGGo73exnnbHtRH4Jrt9PUAFnNKzg/cmD0guFHznPZ0p0uQ9Q6IQSs +fm4bRTTtjambg1fqXKZbo5RNCidJDDY3ynJeJw/djaLKTDa0+lJiuo3g+Ane4ItFVR3 wYaEvRDPs+RXDzYVW4eTRG0eAxOqY3Ugs92M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dU+Wc58WfE7Ib4kxZTzxbG+WqkxMC9yPZftznIKZ/e4=; b=ykaNnEuym1CClkjXihGw3I4UEvwfZMW+sy+g5hTgFw5bDkvhfAt5CZgktYk6u2UFZI eADMCZxSOu0KYxb3zTU+1O5xoZTQOUJmkGYjIdPZ9EWaBX7egryjDPfwOHpWlmq339wH J9ec/plUl38Pf7PRPEhZXUxH2n1JeiwsoCQxy8wB4WIqYh4IOA4+q2MA1wXA0islsrr4 r1WgMKo3p0ttQA66rOotHoDBWTh8jAQE3SxWIVB0Juo3YpgB0usmD6fhe3+93jI7kJ/A C+bV/fieExXizUtdij4NjnPqglWKX1waVCxIDjgy0NV7YG59SK2qUpnGZ3z9qA2N9MYx F7oQ== X-Gm-Message-State: ACrzQf1rxizByL7tu+0SovWvsX275VyEw0UgWuBN7R5zk1NgxpZ/2exN cM7atYloDtEhl1THcYb5N20Hc3vFRFcq9w== X-Google-Smtp-Source: AMsMyM5oodY3pEMpeyXhIdQk7N0QafcfOfb8SDcDROwFr8cqYLCrVA172NVnLlsK2jBbH8d88aSRwg== X-Received: by 2002:ae9:e013:0:b0:6ec:9961:4ead with SMTP id m19-20020ae9e013000000b006ec99614eadmr3543087qkk.582.1666131365376; Tue, 18 Oct 2022 15:16:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9c58-0588-a5a5-a6b0.res6.spectrum.com. [2603:6081:7b00:6400:9c58:588:a5a5:a6b0]) by smtp.gmail.com with ESMTPSA id c1-20020ac87d81000000b0039a8b075248sm2865396qtd.14.2022.10.18.15.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 15:16:04 -0700 (PDT) Date: Tue, 18 Oct 2022 18:16:02 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, maemo-leste@lists.dyne.org Subject: Re: [PATCH] Nokia RX-51: Fix compilation with non-zero CONFIG_SYS_TEXT_BASE Message-ID: <20221018221602.GE2020586@bill-the-cat> References: <20221009193713.12765-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L7HOq7zyYWLAwxxS" Content-Disposition: inline In-Reply-To: <20221009193713.12765-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --L7HOq7zyYWLAwxxS Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 09:37:13PM +0200, Pali Roh=E1r wrote: > For some unknown reason GNU assembler version 2.31.1 (arm-linux-gnueabi-as > from Debian Buster) cannot compile following code from located in file > board/nokia/rx51/lowlevel_init.S: >=20 > kernoffs: > .word KERNEL_OFFSET - (. - CONFIG_SYS_TEXT_BASE) >=20 > when CONFIG_SYS_TEXT_BASE is set to 0x80008000. It throws strange compile > error which is even without line number: >=20 > AS board/nokia/rx51/lowlevel_init.o > {standard input}: Assembler messages: > {standard input}: Error: attempt to get value of unresolved symbol `L0' > make[2]: *** [scripts/Makefile.build:293: board/nokia/rx51/lowlevel_ini= t.o] Error 1 >=20 > I have no idea about this error and my experiments showed that ARM GNU > assembler is happy with negation of that number. So changing code to: >=20 > kernoffs: > .word . - CONFIG_SYS_TEXT_BASE - KERNEL_OFFSET >=20 > and then replacing mathematical addition by substraction of "kernoffs" > value (so calculation of address does not change) compiles assembler file > without any error now. >=20 > There should be not any functional change. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --L7HOq7zyYWLAwxxS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNPJaIACgkQFHw5/5Y0 tyyntwwApwfBJ6+krRHO7Gd0B0osopA5grXKbXFxNzpcEibBRLuyYoQedLiqYstP u6aOK1Y3PsrJTlmjy3LdQxeVMH7ve22Rlmfiu/py/66LSJOXVQzzgytiq7vd+iDn ovLjnDRslfEQvUC5zrN1ZGrPIP3cdtnkYskBG6S5swlRFThUU4Kv3cho2SNigRa3 hPy0DKpVBG644/rpo7aKHP6jPa2jFIisxwavyy7f6RzjJJjT6Ue0jJs9NPdYaBlp yZW38edZnzNPuZ6f1vQfcDGz7XOpdQN1s9bzJxMe56u5PUSvdEuzKFiU/TMoWzGW StXz50PIGSxSUUuXAJeainR9nFAaB0c3kAOT6NyZFGMHVxCnWQgUv0aLpzZ7zcZ1 u311PIfZ/SmpbC0XFw2oh0OuNx30WArB0wO783C/uTBDgMZrvb92kX4KY481SolN MpZid4+ePnH6lR7CRfY6n/VJ1x5QnVOmATf8tRi/E9L1/WmzqABC9Gg1QgFOut5Z 0klaPsdm =eWDj -----END PGP SIGNATURE----- --L7HOq7zyYWLAwxxS--