Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E97FC43219 for ; Wed, 19 Oct 2022 12:54:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B067284E91; Wed, 19 Oct 2022 14:54:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ifclCLjP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B543484EA3; Wed, 19 Oct 2022 14:54:32 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 03D9E84E73 for ; Wed, 19 Oct 2022 14:54:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id bb5so11537038qtb.11 for ; Wed, 19 Oct 2022 05:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xx3LF5qQIxaq91/Eck60wHRDm5R4hv26uypb09/v8KU=; b=ifclCLjPgPg+JKtJaWLnrdDMtK/QRdAv4hQWFYnJ6b4eUNeLjXMkEM7lKu16Y0ZopB EHPQJW/RuTOtRs+zXYbEdaWTm3WzfytNWfYs989eD2rItlUApQhaJ50oWo4IgfsRpQc1 XHSuAA/5yveLgIP6QvjcAxYNZvwHNC2cjfgoI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xx3LF5qQIxaq91/Eck60wHRDm5R4hv26uypb09/v8KU=; b=RzauQTxFn4lrl7MKAUEHxo554pcpyy4mfkOZWvtHVWa3rYvdP2ZUQgZGE+PACLf6vB nntMtrwUBZd4c0JhyNaiiyaTvDnUmYA76DZpv/i6vLmael0sRD6UfkDHvVRT0vTkW/m6 BfY3BmrUHisqROH7jlqzvP9AESxAlJK3gLZmz5G8L1uCKZ8EqeYApEslBuGGE1BsuzUc It9L4z9wx4sOWvVK6qLVqkOpfa6QSoZR9uhfWGvaTxn65yev/ordQEu3asBnypgP6vbN DM5ST4JNpKU++qPQLH1uSPPXvjL6Ctm76e1DHwKf4ixgKbSzXfXVW7MA/+QoW2vWMe8d 1T+Q== X-Gm-Message-State: ACrzQf2tUoayuZDZdr+6gXcTcCHbHAs+TKbG/Ro+YWXDLyW/n0ymow1R Pg1a1pMHRfXULvWgdtMdnKqHgQ== X-Google-Smtp-Source: AMsMyM4ePf+XGQmyK695GTsLpBXy9mHAGRcJobvCwmF2zW94JW1ue5EKKeDW2A/L4RCP9BmydrFtng== X-Received: by 2002:a05:622a:1a19:b0:39c:d550:6ac3 with SMTP id f25-20020a05622a1a1900b0039cd5506ac3mr6134106qtb.204.1666184068771; Wed, 19 Oct 2022 05:54:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-245f-e62e-ad5e-ad1d.res6.spectrum.com. [2603:6081:7b00:6400:245f:e62e:ad5e:ad1d]) by smtp.gmail.com with ESMTPSA id x6-20020a05620a448600b006eecc4a0de9sm4987633qkp.62.2022.10.19.05.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 05:54:27 -0700 (PDT) Date: Wed, 19 Oct 2022 08:54:25 -0400 From: Tom Rini To: Roger Quadros Cc: sjg@chromium.org, u-boot@lists.denx.de, praneeth@ti.com, kishon@ti.com, Patrick Delaunay , Patrice Chotard Subject: Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL Message-ID: <20221019125425.GH2020586@bill-the-cat> References: <20221006132400.5628-1-rogerq@kernel.org> <20221006132400.5628-3-rogerq@kernel.org> <20221018174025.GA2412547@bill-the-cat> <2a378fe3-d8f6-3b60-eeb9-f511921fb831@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aaeYxw/B9teUOk8U" Content-Disposition: inline In-Reply-To: <2a378fe3-d8f6-3b60-eeb9-f511921fb831@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --aaeYxw/B9teUOk8U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 19, 2022 at 11:17:35AM +0300, Roger Quadros wrote: >=20 >=20 > On 18/10/2022 20:40, Tom Rini wrote: > > On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote: > >> We will need ti-gpmc driver for SPL. Allow memory drivers > >> do be built for SPL. > >> > >> Signed-off-by: Roger Quadros > >> --- > >> scripts/Makefile.spl | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > >> index 3bafeb4fe9..110076b22f 100644 > >> --- a/scripts/Makefile.spl > >> +++ b/scripts/Makefile.spl > >> @@ -114,6 +114,7 @@ libs-$(CONFIG_PARTITIONS) +=3D disk/ > >> endif > >> =20 > >> libs-y +=3D drivers/ > >> +libs-y +=3D drivers/memory/ > >> libs-$(CONFIG_SPL_USB_GADGET) +=3D drivers/usb/dwc3/ > >> libs-$(CONFIG_SPL_USB_GADGET) +=3D drivers/usb/cdns3/ > >> libs-y +=3D dts/ > >=20 > > This ends up being the wrong approach as it then pulls in > > drivers/memory/stm32-fmc2-ebi.o on all of those platforms, in SPL, which > > is not what's intended. We need an SPL_MEMORY symbol and then gate the > > directory on that. > >=20 >=20 > That's right. I'll fix it up. Will wait for your comments on the rest > of the series before re-spin. Everything else is fine, I was about to merge it (with a %s/DM_MEMORY/MEMORY) when I saw the stm32 platforms increasing in size and dug in. --=20 Tom --aaeYxw/B9teUOk8U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNP83sACgkQFHw5/5Y0 tywgggv/fMNJnLzEVtw/vQeC2EHCIK6I8roJk/KURtZo+W7wrQX+Fs1Eaz+0orJO eTpcMgaL25XehvyRDZavwi5hQaQLKw+o/9QVeRM3+vnJhB2dP2/yNfxmwUzi1jwa bCCs4bc5BGXI6iQ98PSmolArg4BjVqvtIXAPSTKeGwE6hy9qSD8uaGfmSajCpGGO kcbY/tf73rXg3zL0JMLEkXjy9my4eb3v8bad96Jpcqie7WXKL6v2jIPM4yIa/fhg PoteQvC2mUsJIhRWhnoRL3Dta/Fe/8+0v+HQyEtFeUPq5a6zz926Vab5c8IHebXi Ta4wKFdIKSM+jkN0OPaO2XubxHDY+BiPE+xPhmBovrHBenIOG5F/NquXR4wKRX8c Zn/OHYQetyGwmW2VYhCwvUlE/wr+ArcXowDGOrXUvjEG2oiZ3d8aOH3r5f6XFont yVHEV0w1HANi3OC1YxJRcmJ8d2lePMknuj2PEj8nLzGXen95+9fSJfmx8ZqLDAQA WshwYkEB =X3xi -----END PGP SIGNATURE----- --aaeYxw/B9teUOk8U--