Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC9A3C4332F for ; Fri, 21 Oct 2022 13:14:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 51FCD84FD2; Fri, 21 Oct 2022 15:14:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OCKeXged"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9532D84FD4; Fri, 21 Oct 2022 15:14:48 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5AD4884EE8 for ; Fri, 21 Oct 2022 15:14:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id w3so1563118qtv.9 for ; Fri, 21 Oct 2022 06:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EbpIXzhTUDxOTBBEwkPLaFElKBFpzn8kIapBOvNvkVo=; b=OCKeXgedl5eJTzpzRof4EGoWrT6PvougqlH1I27PAot1ftNXDjZe+guAoN4KJG02nD X/cT+0kCJ3jmVAQtjQdFGptTIFvLEp86jxyzzIT6QMpATF8f6reRA5pP7w3zcamuzt4L sBGfJV7kzSyXtvaKhYsvEx5U++0XKvbksJycg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EbpIXzhTUDxOTBBEwkPLaFElKBFpzn8kIapBOvNvkVo=; b=FzOzVvkCP/eX1Vnp7X7Zq0olyr3Sz5t/8Ii7u4DUqX1eVmCNDGi3gLYDUU/bnNuDrJ haZXR1t5tpWvA/QXmTJPPDODFpxvI5W7M3CK7uKnb7mXZJl+VNi6RR1pvxQxchNc/F5+ 2Lw25LJtRwBbaOzCr4KyrS6WgKnCiyYoJw8X+c7HQiPCTPIttBVFcnDBPGL7mmxjK5GY P/30gppDC91bYCVbp6CDTM5ctV0HosdOvGGE2EYfHMnBM3oxvfxwEoEwi/XTZTE7xbn9 uq4WIft4m+pr6biAUFhIyunGY/IxkmAnRzEOxr//wFNHhki1uUieLHxMbrO1YMYfT5Jr GpQg== X-Gm-Message-State: ACrzQf3Jp4nKwagJ5pGyLoRVK1NctLgilk0wADRelFPfxP7ty0u8SNe5 t7JLELNt0WW8EFsNY9ztSkpj9w== X-Google-Smtp-Source: AMsMyM6qXu4bIl7jHuH4RzncB15WbVrdFgfKGyQDSzlrZCwg4mkyhtyPJ1pRAyC7TCf3YT4JXVDEEQ== X-Received: by 2002:ac8:5cc2:0:b0:39c:e770:4e77 with SMTP id s2-20020ac85cc2000000b0039ce7704e77mr16193994qta.328.1666358084116; Fri, 21 Oct 2022 06:14:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-54a5-60cd-d75f-79a0.res6.spectrum.com. [2603:6081:7b00:6400:54a5:60cd:d75f:79a0]) by smtp.gmail.com with ESMTPSA id x6-20020a05620a448600b006eecc4a0de9sm9922247qkp.62.2022.10.21.06.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 06:14:43 -0700 (PDT) Date: Fri, 21 Oct 2022 09:14:41 -0400 From: Tom Rini To: Michael Nazzareno Trimarchi Cc: Dario Binacchi , u-boot@lists.denx.de, Balamanikandan Gunasundar , linux-amarula@amarulasolutions.com Subject: Re: [PATCH] cmd: nand: Extend nand info to print ecc information Message-ID: <20221021131441.GY2020586@bill-the-cat> References: <20220922133937.277463-1-michael@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7SYSPvbQ4CuS4Akc" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --7SYSPvbQ4CuS4Akc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 21, 2022 at 03:05:48PM +0200, Michael Nazzareno Trimarchi wrote: > HI Tom >=20 > On Thu, Sep 22, 2022 at 3:43 PM Dario Binacchi > wrote: > > > > Hi Michael, > > > > On Thu, Sep 22, 2022 at 3:39 PM Michael Trimarchi > > wrote: > > > > > > Extract the information about ecc strength and ecc step size > > > from mtd controller. This information is usefull to check if > > > what we think as ecc is what we really configured. > > > > > > Signed-off-by: Michael Trimarchi > > > --- > > > cmd/nand.c | 14 ++++++++------ > > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > > > diff --git a/cmd/nand.c b/cmd/nand.c > > > index e730484d0b..9a9794684b 100644 > > > --- a/cmd/nand.c > > > +++ b/cmd/nand.c > > > @@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx) > > > printf("%dx ", chip->numchips); > > > printf("%s, sector size %u KiB\n", > > > mtd->name, mtd->erasesize >> 10); > > > - printf(" Page size %8d b\n", mtd->writesize); > > > - printf(" OOB size %8d b\n", mtd->oobsize); > > > - printf(" Erase size %8d b\n", mtd->erasesize); > > > - printf(" subpagesize %8d b\n", chip->subpagesize); > > > - printf(" options 0x%08x\n", chip->options); > > > - printf(" bbt options 0x%08x\n", chip->bbt_options); > > > + printf(" Page size %8d b\n", mtd->writesize); > > > + printf(" OOB size %8d b\n", mtd->oobsize); > > > + printf(" Erase size %8d b\n", mtd->erasesize); > > > + printf(" ecc strength %8d bits\n", mtd->ecc_strength); > > > + printf(" ecc step size %8d b\n", mtd->ecc_step_size); > > > + printf(" subpagesize %8d b\n", chip->subpagesize); > > > + printf(" options 0x%08x\n", chip->options); > > > + printf(" bbt options 0x%08x\n", chip->bbt_options); > > > > > > /* Set geometry info */ > > > env_set_hex("nand_writesize", mtd->writesize); > > > -- > > > 2.34.1 > > > > > > > Reviewed-by: Dario Binacchi > > >=20 > Can I pick it up? Yes. --=20 Tom --7SYSPvbQ4CuS4Akc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNSmzsACgkQFHw5/5Y0 tyyPjQwAptxgYdctYVgU2oK8X8fPN7EdGY8YJCi8rJny0/TDQYhik2RfRXHTa4cR 4EGzd/SchI6fjeN8L2CW90qHpuKmhMi+jVfb3fUbwdaqFdta7T08SlXZrHqnVIN3 2F1kgwApDgw0ugwr8voDMwplHDP0cVmyFsbfN4P4Xc2mxlCvu2znT3GJQSYQ7xMM yUNxI0Ftcsilvc4aS1aMsAaZblBFOSZHzXkfuVfvGNfAvD8HwZaTGt3V8OZoHxbH bdx/8AU0sVh/Fx+CF7Wl39MitQNksxQTcyWwCBD5GgSnmusKhyu2SO/J3m/3YpIu ruIxkTBT0rz1J5NOizrQQUWHF0nVaWNiC0cRyZ7sOZBDGW9dudgtxkpCoPqbX6U0 RgTEERnGGmNOGCZEFY+mqJw93wD7crmtBIzMP0BOJQPHjTF1B6vn9hX/noCXJxlQ lLzFt5walQHKLX5BgRFC1VXMjPBJiLBDNspp46njuhj4oCfK7wOvbd/sUSkxUJVR zRx7OB0Y =vSTo -----END PGP SIGNATURE----- --7SYSPvbQ4CuS4Akc--