Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A0A4ECAAA1 for ; Mon, 24 Oct 2022 12:23:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD54683EDF; Mon, 24 Oct 2022 14:22:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D3xxFcsr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C9A5480FB5; Mon, 24 Oct 2022 14:22:21 +0200 (CEST) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BC46C80F70 for ; Mon, 24 Oct 2022 14:22:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id w10so105219qvr.3 for ; Mon, 24 Oct 2022 05:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KrXk0k7Ix5+4Uthl5hnY67f+47kCITOrB856AuKl4uI=; b=D3xxFcsrYQwExbysy97/HoccNYaoR5Idb0azwkxTf4WQzOFTfrkte7Dw+d3dYkMedj o+2meug1QmysjIDBF8Ti2+fMnetp4iZKlpvenT4HZ0KHOkkAI7M277mheQ2ei5umcl2n gHXHMkVHIRS9Qfk1tOL8Ew6c3YKIA2tIxFWOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KrXk0k7Ix5+4Uthl5hnY67f+47kCITOrB856AuKl4uI=; b=JaO93/3fuvEvSXsj10Qsp6U4w/ORLpAYIPC5ocaqJf0LP/fYj3RqbfG+ZzExoGI8NF nEYf5HoCqtHMV2+3ZY+PlposuyFJWYLqtYa2cctBtvT3i9OyVjuV99adcKZvFhaaXdGp rU7QknJcVrsQoyjpH6GHYaTm58zApqoeGaMPsgKHwVAT9h+YkH4b6eAVICvvlx5taMlI Ry5ppTlm1M+id8KkPrnTdQTQI+luNXSlkWsso1/qBwH5oJ4zjLv5/G+NUd19JT+iHcrU rsCxIB7CYGs1hSABOKjja7DgjGzYw5rd/CJdFDHvphR8y7s0KUnI2ALTGHE+Z6L+ln1c rY+A== X-Gm-Message-State: ACrzQf199pJU+zZPocDQT122gsmaG9+pui+335JgBHMKYYffsokzLayU n2eX+gvVCnUYWUIwe+BjjG4lIg== X-Google-Smtp-Source: AMsMyM7ptE2ElwLwdQXfWQs3Nj6Pw399945/Xfy1P/8kLOZ09ghulMbXZTgvMRE0y6WgA5wb9P4/FQ== X-Received: by 2002:a05:6214:29c9:b0:4b3:fcfe:3731 with SMTP id gh9-20020a05621429c900b004b3fcfe3731mr27078216qvb.29.1666614137534; Mon, 24 Oct 2022 05:22:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-f53f-b0aa-caa3-a9b8.res6.spectrum.com. [2603:6081:7b00:6400:f53f:b0aa:caa3:a9b8]) by smtp.gmail.com with ESMTPSA id l20-20020a05620a28d400b006b8e8c657ccsm15084165qkp.117.2022.10.24.05.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 05:22:16 -0700 (PDT) Date: Mon, 24 Oct 2022 08:22:15 -0400 From: Tom Rini To: Andre Przywara Cc: Tuomas Tynkkynen , Simon Glass , Harrison Mutai , u-boot@lists.denx.de Subject: Re: [PATCH 2/3] qfw: return failure when no kernel could be loaded Message-ID: <20221024122215.GU2020586@bill-the-cat> References: <20221010170122.1527138-1-andre.przywara@arm.com> <20221010170122.1527138-3-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8Q7Y/Z59S04kz3AK" Content-Disposition: inline In-Reply-To: <20221010170122.1527138-3-andre.przywara@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --8Q7Y/Z59S04kz3AK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 06:01:21PM +0100, Andre Przywara wrote: > When we try to load a kernel via the QEMU firmware device, we currently > "return -1;" if no kernel was specified on the QEMU command line. This > leads to the usage output, which is confusing (since nothing on the > command line was really wrong), but also somewhat hides the actual error > message. >=20 > Return CMD_RET_FAILURE (1), as it's a proper error, and make the message > more clear that this is not only a "warning". >=20 > This helps to call this command in boot scripts, and to gracefully > continue if this doesn't work. >=20 > Signed-off-by: Andre Przywara Applied to u-boot/master, thanks! --=20 Tom --8Q7Y/Z59S04kz3AK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNWg3cACgkQFHw5/5Y0 tywOOwv/QatBujyraj4F24tcV5hK761p+z+VefPaYF6OFeffce5BCLI4PdvhhKlG ycRIVX/X4k3hTvJ06/K8CktkiFsF3keA+UKWTSnT+2ADAvBlt0T4RKFBcDo+gLHb tCxreoxyQ8rKgo1JqUzwDllXPtli0mSQ2BUU3D6mhtH/yLxRgY+gv0zL0rURRNZR QMWF5QvrTayxB9CnlIQ0c2TVFm5zyyscPac9ZmKNIT6tKsa4idNOuFh+W8k1sgi9 8UlXrgVdNig4xm+oNIG2YCOBS6X9X1UESILqV8PpB07sz5gA/NV7/rNaL9bPHwzR j36/xm6Kh0Crj5NJz65bJlan38nl8xCnOoCVMYO8gkTfAh7NVWMVQY4c+j5PKPeQ LLdLFXT1nkaCjjXXvY6awxhV5S1xLr95KbKL1P8kep0zZ103xbsyw9ltB9gZFwjz z7i358AGPYUtYgp28ixtS7nR+RH7XZ54qgTvW5tzoIU8OjKbgju6oSeGdkUC2RZ4 ZZWkmmZi =torz -----END PGP SIGNATURE----- --8Q7Y/Z59S04kz3AK--