Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E16BC38A2D for ; Wed, 26 Oct 2022 13:51:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EA11185054; Wed, 26 Oct 2022 15:51:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nQi2ZuVT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A308885057; Wed, 26 Oct 2022 15:51:21 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ECFDC8504A for ; Wed, 26 Oct 2022 15:51:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id f22so9884651qto.3 for ; Wed, 26 Oct 2022 06:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X2F5wkrK6tYXIfROYHlUXH8emfhlHlRgfC172S0nbYM=; b=nQi2ZuVTYxhSsEuvLyfOTDN1NX/ovqGLgyw3WELiaVjcbprlbpHbn9s+RsDLi9Xrkb gvWr9BW55e43sNy1WthZ/AI6+gUbZkzWdWR3EfFqRvC8htGGHkJMIqAArLPv9PPfR4tW oIvHT6EwmvaubasoD9+VTXoTQGseblgXkG2CU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X2F5wkrK6tYXIfROYHlUXH8emfhlHlRgfC172S0nbYM=; b=wB3EpxPrEhuoJMJRj6umgX3zLF4n2k9aZmglgR29HOpLN/dPi0Tp17uTVgzUu/Lhks TgYJAXd8G5RqNDKW+dIFT7vW0aLR/VG23nkuU4MzcRABPUn+PaOmL64OORyXZ8uHkGcR r1eI45Nq5X6ADIYF50d2oUYXcWNB6p5UDHrbSl7T7HYOYKQUG2vkSUrTL49DgkotDH2S 9Qftr3sapeeIwj7Jw+aUBl7PL21i/12P1Y8WkEMAyBYv/VfhR3o130VCBgLJYegz5Wur AszO/OOGbwJU2tfBjgXJCM5wmb+WBf16NfReCp+8IYsRC1Cy5ToLd1ZQjRmKm6gOtEJG lLDw== X-Gm-Message-State: ACrzQf1cVYo3kgA8pH/mvNAqwHS9G6kIdT3bmw+RnVXAV6vLUshqUM93 MGodGWeiF2f7aN0wfqlt0mrTGQ== X-Google-Smtp-Source: AMsMyM4SQdc0W8IKgeVfriR6FxIuAdwQfWgX+b/8MhosGvO+/OZY4eqnmPNQ6HFRPI0hwSQQJMP2Hw== X-Received: by 2002:a05:622a:492:b0:39d:789:b915 with SMTP id p18-20020a05622a049200b0039d0789b915mr31623598qtx.561.1666792277653; Wed, 26 Oct 2022 06:51:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0125-cbbc-0c8f-48fb.res6.spectrum.com. [2603:6081:7b00:6400:125:cbbc:c8f:48fb]) by smtp.gmail.com with ESMTPSA id f17-20020ac84651000000b0034305a91aaesm3157283qto.83.2022.10.26.06.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 06:51:17 -0700 (PDT) Date: Wed, 26 Oct 2022 09:51:15 -0400 From: Tom Rini To: Michael Nazzareno Trimarchi Cc: Roger Quadros , Dario Binacchi , tony@atomide.com, gadiyar@ti.com, u-boot@lists.denx.de Subject: Re: [u-boot][PATCH] spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard Message-ID: <20221026135115.GQ2020586@bill-the-cat> References: <20220929101128.3502-1-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7zXkBnrtCPTreBSJ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --7zXkBnrtCPTreBSJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2022 at 08:30:40AM +0200, Michael Nazzareno Trimarchi wrote: > Hi Roger >=20 > On Mon, Oct 10, 2022 at 12:38 PM Roger Quadros wrote: > > > > +Dario > > > > On 29/09/2022 13:11, Roger Quadros wrote: > > > OMAP3 BeagleBoard NAND boot hangs when spl_load_legacy_img() tries > > > to read the header into 'struct hdr' which is allocated on the > > > stack. > > > > > > As the header has already been read once before by spl_nand.c, > > > we can avoid the extra header read here by simply passing around > > > the pointer to the header. > > > > > > This fixes NAND boot on OMAP3 BeagleBoard. > > > >=20 > I can see that fix is only a collateral effect of reduce the > allocation on this scenario. >=20 > I think that is better to mention as it. So the real change is to > avoid to allocate two times > mostly >=20 > Reviewed-By: Michael Trimarchi Since I was about to push this out, is it OK to go with this commit message as-is or should I reword it, if Roger doesn't shortly? Thanks. --=20 Tom --7zXkBnrtCPTreBSJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNZO0wACgkQFHw5/5Y0 tyxZqQv9F9x0OFmvxcaHQCM7HsEsrOJKHYXQ1ghamgveKVVV8o7uxP9b9Q4WXzyi +rMfFntP9YJiv+Kvlxk+eQTF4dkxE2Z6UdI+4uoMj3NM/1gpo5p09vjWJpg63MwV p/K2aNaShkomM2C6pVBUwGdx4L7ViCNq+jS0kmpw749VGsBmNw9HHxw6420ATdp8 4AQ9miE/RUuWlainxHN7DHzf7n0sdc9zEGRu2zqM4ABP28s1WwDglmPXswaxGZCU 1onV503vt6Js4ZYU+IlR/dV7mqu1HuBEHK5J20uT4Ttj1n1tkOblWak/NyWmitUZ mVAMWYUp5MLgHc1+JuzYDbhJrExZ7U2PiexAp1M7wauOCo8TFCmHQ9J/dIo9srSs pFRNhqGRjRzOrz/1PhqgouSeguApHuQxdjnHLIu0TPcKxM7rN/jVWTJzHsbSpQZV 66Il4mqMJZB4kElrOC9aXbqk6kw9N3gcFPsGUOnzuftwwBtkdE+QrvUe6Sv/wUwu 0yLz0c3q =dtgx -----END PGP SIGNATURE----- --7zXkBnrtCPTreBSJ--