Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B70ECDFA1 for ; Wed, 26 Oct 2022 19:26:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DA0798509C; Wed, 26 Oct 2022 21:26:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="M0jPoiQg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0874D8509E; Wed, 26 Oct 2022 21:26:52 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9351585089 for ; Wed, 26 Oct 2022 21:26:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id r19so10765566qtx.6 for ; Wed, 26 Oct 2022 12:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xv2HxRLTPr+DiC79KwUhXDeuvcy70+zZ2OCc4HWF2YQ=; b=M0jPoiQgyIHlLeoe+/O79BRmbkjX46O2W9bwcRFVUoX3880eVCUEJCi/O/4odS+dSy wnKrleyGpFXfCV9CEKRO6/32jOi+De0xGla3d8Ylf5A11c5W48NDpcN/WuEhdYgNhkmQ 2IgV9bNj1f9JN0d015Skge1jMWtIdzzsXNExc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xv2HxRLTPr+DiC79KwUhXDeuvcy70+zZ2OCc4HWF2YQ=; b=hlnyBqXESoGPJIoqxAUhlAKl9LhgZWH4uRKDoS80edoAmD53FAgmsCPDKubDuFwDYO IUpcHXNw6llMN5H1woj5SpuRf9ggrNYKEkpvf2tXOAfjINe8HZaW4dOHhVi26fEogJAD fuKyBinWgPtSPWmixloE06TmjHKsVSkiy0dZ+BnBuQDjJUHIgiQ8fP2etnKldKdSjeCl yNpb9kidtqD6EqY6SscSls2bb47eXzW6HOnZIKZCgeneLHLfadU4a0UvltL/f5nuhf7m NVrIdibv5wx6j4QUudy8RbzUWGeHyvTmAQ8m/xzyu6ZhAjQVDKkt2cp46gFAkyuw12Fo OObA== X-Gm-Message-State: ACrzQf3uaZH0gZPfFJLTslPpvGyUwiarwOYOAUlOnBY8KiZDzfXUon8S EPQY5BvNHl/8uW3i5jTHuuastA== X-Google-Smtp-Source: AMsMyM7omnKpwP7tiUUNQJ7Ytpgf0l1axLUlEJyw/a0okDj1W2KE74bhC1Q1Ev8mqsprLpkH49FFVw== X-Received: by 2002:a05:622a:144b:b0:39c:eb3b:7e with SMTP id v11-20020a05622a144b00b0039ceb3b007emr38206052qtx.354.1666812408376; Wed, 26 Oct 2022 12:26:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0125-cbbc-0c8f-48fb.res6.spectrum.com. [2603:6081:7b00:6400:125:cbbc:c8f:48fb]) by smtp.gmail.com with ESMTPSA id q13-20020a05620a0d8d00b006dfa0891397sm4438745qkl.32.2022.10.26.12.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 12:26:47 -0700 (PDT) Date: Wed, 26 Oct 2022 15:26:45 -0400 From: Tom Rini To: Roger Quadros Cc: michael@amarulasolutions.com, dario.binacchi@amarulasolutions.com, tony@atomide.com, gadiyar@ti.com, u-boot@lists.denx.de Subject: Re: [PATCH v2] spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard Message-ID: <20221026192645.GY2020586@bill-the-cat> References: <20221026191956.7576-1-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AmQwmWFbeMnnUgEL" Content-Disposition: inline In-Reply-To: <20221026191956.7576-1-rogerq@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --AmQwmWFbeMnnUgEL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2022 at 10:19:56PM +0300, Roger Quadros wrote: > OMAP3 BeagleBoard NAND boot hangs when spl_load_legacy_img() tries > to read the header into 'struct hdr' which is allocated on the > stack. >=20 > As the header has already been read once before by spl_nand.c, > we can avoid the extra header allocation and read here by > simply passing around the pointer to the header. >=20 > This fixes NAND boot on OMAP3 BeagleBoard. >=20 > Signed-off-by: Roger Quadros > Reviewed-By: Michael Trimarchi Applied to u-boot/master, thanks! --=20 Tom --AmQwmWFbeMnnUgEL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNZifIACgkQFHw5/5Y0 tywnrQv+IsQTX8bTIKnRo+2TR570q2QAjBdlM6d4tkR0PVNbjxNQkgF3p5Sax351 QcplPkTDfiCUz6xFsBY19u9Jw89pFbvW630/iBBTqrohI6ERk6uJVK03Q9fT8r30 3OP0LHQUUaIDqjoi1L48ZyYt3K3YDVNNKTxyQCbZwP2fniG9RDQWaxIJ1uV74vRH N5/let5H8jLZAekom9rqRyXRmbI4UiU/LuLAdQzyRxMBTfJXtQglUEgYZqA82YEF BZiP1l0YKPLwlPNjRoeNF1VSl6rVeriufEVtawu+wo6DacPBlNBUAvKob0DFDPGs gqJBlNyLCU4TgZzOIGVacIDlsnAhSY3/Zh44dm09n0B2LZpSMU8cDvh6oRxTQeA+ ll6R1+rr856SIz1JyPYioPGA9hqhfjB9qcV8bSdx4BDY/DSr1FAwwSuQ3OQ/RxOC AknOdxY7qQNPETLGoGwmIqqenzGtbnItsLiAVkOm7qXBDhLrwR5FwKCHQz0DSlaG q6kkPGmj =3VOW -----END PGP SIGNATURE----- --AmQwmWFbeMnnUgEL--