Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C528FFA3740 for ; Thu, 27 Oct 2022 15:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=48KikOh6sHyaVVoT2cM4OPN2N+xTh0uU7L2OJyFQWGo=; b=lm9WoeTN13Vu0V vjnJrx52FJCwP35Fet0JkDL9FnDh3rH0DwojrAkkSjJuOKT1g8303LKbIN2UXYnRxPSnp+TfQkJ64 p1/Fri0xQ32XZ0PdVmaZSdl1X/lEa4NtrsAdPNM5gXRipNbYrU4akgfmZWlD4JlJ0zFGktAjFqrwn 4uvv0HaSw6Q2NJvidt7eoF2jxxdAQxbmSxMLWcnsYO0s6gdxMM32ex3JHhwPtOPNTz2YoaYJTghj3 T0JRwnuE8/WB+DRRHCivdeAwt1HEpHupGf+Ua3z+WdvFPTzQ26CvsIRNn+DDP0vLgZDggOXxsaw0D 6n7owg6sDv+3eqTJ/2tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo4rp-00E5xW-4w; Thu, 27 Oct 2022 15:32:25 +0000 Received: from esa2.hc353-39.eu.iphmx.com ([207.54.65.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo4rk-00E5vX-Uf for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 15:32:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=sequans.com; i=@sequans.com; l=1669; q=dns/txt; s=corp; t=1666884740; x=1698420740; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7fBie9wn3NSPZ8jc3U9YBZPIq94L5arqcHKggHacoY4=; b=OVvUxG0tly10lcQX6wATgXiHBTR/nvfzr7wQhsdNdVAi2M24Xq0vg+Wn OuFWrCMlDDEx916FmC1A5qdTG3xSVSUUrS7mm1F/PkLqpeYRvanDll5Dj BNOouIba3W+I89amVLJU95sLCyFo9BsEKuFUbZzmCPDdgzSeI7kf5l2nQ M=; X-IPAS-Result: =?us-ascii?q?A2FfAQBao1pjl5bSIB9agliFBrMMgX0PAQEBAQEBAQEBC?= =?us-ascii?q?UQEhQeEeyc2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBAQUBAQEBAQEGAgEBAQECE?= =?us-ascii?q?AEBAQEBAQEBNgUON4UvRoI1IoN3NgFGgVGCfYMhoDEBjEyBAYRwgy6BZoE9i?= =?us-ascii?q?yqGA4FJRIR9hRGFcASWRwMJAwcFSUADCxgNFjINEz0bWA4JHxwlDQUGEgMgb?= =?us-ascii?q?gUHOg8oL2crHBsHgQwqKBUDBAQDAgYTAyICDSkxFAQpEw8tByNxCQIDImoDA?= =?us-ascii?q?wQoLAMJIR8HJSQ8B1g6BQMCECI8BgMJAwIiV3UwEhQFAw0XJQgFTwQIOgIFB?= =?us-ascii?q?lISAgoRAxIPLEgOSj45FgYnRAE0Dw4WA2JRIJlpgQ+CUsJkg2+gMEyWeJIbl?= =?us-ascii?q?yajI4QhMIFAKQOCDE0jgzdRGQ+NdgE1DQmOMHM7AgcLAQEDCYpbAQE?= IronPort-PHdr: A9a23:bJP4eBZJ0Wucz469+3B/D3b/LTG20IqcDmcuAnoPtbtCf+yZ8oj4O wSHvLMx1gOPBdmQu60My7KP9fy6AipYudfJmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnF t9JTl5v8iLzG0FUHMHjew+a+SXqvnYdFRrlKAV6OPn+FJLMgMSrzeCy/IDYbxlViDanbr5+M hq7oR/NusQZjodvKaQ8wQbNrndUZuha32xlKUydkhrm+su84Jtv+DlMtvw88MJNTb/0dLkiQ 7xCCzQmPWE15Mn1uhTGUACC+HgSXHgInxRRGwTK4w30UZn3sivhq+pywzKaMtHsTbA1Qjut8 aFmQwL1hSgdNj459GbXitFsjK9evRmsqQBzz5LSbYqIMvd1Y6HTcs4ARWdZXshfSTJMDJ6yY YUMCOQOMulWopLhq1YNtxayGROhCP/zxjJOm3T43bc60+MkEQze0wMvBdYOv2rSrNXpNacSV /2+wqzPzTXZcfxW3yzy6IzJchA9vPqBWqxwccnWyUk1CQzFiE6fqYjkPzOJzekNqHaU7/N9V e21jW4nsBt9rSSoxscpk4TEgJ8exV/Y+ytj2ok1OcG4R1BhYd6iCJZdqiCXOo9rTs4tQWxmt yY0x7MItJOncyYHyYgrygLDZ/KIboSF4xHuWfiVLDp5mn5pZb2xiRmx/EW91OHyVte53VBXp SRGitnBrn4A2wHJ5sWJVPdx5Fmt1SuT2wzJ9+1JIVw4mKzGIJA72LEwjIAcsUHbEy/zn0X5k bGZe10/+uit9+TnerLmpoKAN4NsigHxLKAumsunDOU5MwgOWnOU+f6m27H55k32XqxKjuAsn anfq5DWP9gUpqm8AwNN04Yj7QiwDyu+3dkWgHULNlxIdAydg4T3Jl3CPOr0Aeq/jliwiDtrw urJPrzlApXDNHjDl7LhcK5j605fzwoz185Q55RPBbEFIfLzRlT8tMfGAR8gLgy72eDnCM5n2 owCXmKPB7eVMKXJvlCQ/OIgP/GMZJMJuDb6M/Up+ebijWUlll8FYampwZwXZWi7HvR8IkWZe mbsgtYHEWgQpAY+SfbliEeeUT5IeXmyWaE85jYgBY28F4fDQ5qhj6CG3Ce+BpFWfHxJCkiQE Xf0cIWJQ/MMaCOUIs98nT0ITKKuS5Uk1R23tw/11aBnLuzK9S0crp/j0Nl15/bPlREp7zB0D sKd02+XT25ug2wHWSU5071lrUx60FeD3vswv/sNEd1V+uMMWx0/cJ3R1ep3D/j2WxndZZGIT li8S9mrCD13Scg+kPEUZEMoJdymgxbf3iziILgPmrqBAJ0ouvbC3H/rKsB3z3fa/LIslkQvR NAJPmqj0P0svzPPDpLExh3K352hcr4RiXalyQ== IronPort-Data: A9a23:Vwa8b6hu57W2snU/5H3KdvTMX161qxAKZh0ujC45NGQN5FlHY01je htvXWCBa//eZzDwfttwb4q/9klT65DVxoJlG1Fvqng1HnkW8JqUDtmwEB7MMnLJJKUvbq7GA +Y2OoKQfJ5sHhcwgj/3b9ANeFEljfngqpzUVracYkidYic7FHx+4f5bs7dlxNQu2bBVOivV0 fvqucrTJVS57DB9N2MQ+sqrpQhm+f//o1v0hHRnDRxwlAKYxiR94K43f/nrdSKgGNYMRIZWe s6apF2H1jKBl/sSIo79+lrLWhViaqLfOwGIlk1XV8CK6vSVjnVvukqTHKN0hXZ/011lrfgoo Dl+ncXYpTMSA0H5sL11vy9wTX4nZf0WpuOvzU+X6KR/x2WeG5fl668+XBluVWES0r8f7Wpmr JT0JBhSNEjb7w4fLX3SpuRE36wewMfX0Iw34F99ySHrNtodEMqSG6H1x+dUgSwdr5UbdRreT 5JxhTtHfhXFaQdGfEwaEY83mvzujX76G9FagAnM4/FtpTKKlEoojeCF3Nn9I7RmQe1LnUGCq 2TM+2XlKgoXLcGWzyHD+XWp7gPKtX+gBdlMRe3QGvhCslCWy0g5EhAvTEq//+Xnj0qFAOBOE hlBksYphfJorRbwJjXnZDW7un+foh8aUpxVGvcm8wyLya386hycQGMDS1ZpbN0gqd9zTCYvk 1yEhdXkARRrsaaJUjSc8LmOpD+/MCRTKnUNDRLoViMX4tzpuoh1lR/WU99lC+i+idid9SzML y6i9gYjg6UhtuIwhv/qpVT4oQqg+4PkZ1tgjunIZV5J/j+Vdab8OdL2twaAsqseRGqKZgXR7 SVcx6By+MhUVM3dzkRhVc1XRNmUC+C53Cr0r2QH83MJ0j2s4HmlZsV06T9wJVt1P67okhe2M BGL4Wu9CLf42n+nKKN6JqyrAsIhwMDd+TXZuhP8N4smjmBZLlPvwc2XTRf4M5rRuEYti7ojH pyQbNyhC30XYYw+kmToF79MieRzn3tnrY82eXwd50n2uVZ5TCDMIYrpzHPRBgzExPzc8V6Iq 4o32zWikkgGCrCWjtbrHX47dwpTdyNT6WHeoctKZ+GeLxEuBGwlBvTWxNscl39NwcxoehPz1 ijlACdwkQOn7VWecFniV5yWQO62NXqJhSlgZnJE0JfB8yVLXLtDG49EJ8FvI+J7r7I/pRO2J tFcE/i97j10Ymyv01wggVPV9eSOqDzDadqyAheY IronPort-HdrOrdr: A9a23:R98d/qHXbynrZIugpLqE/8eALOsnbusQ8zAXPo5KKSC9Ffbo8f xG885rtyMc5Ax+ZJhCo6HmBED/ewK4yXcd2+B4VtrPMzUO01HYT72Kg7GC/9SZIVybygeD78 1dT5Q= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="5.95,218,1661810400"; d="scan'208";a="4353698" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Virus-Scanned: amavisd-new at sequans.com From: Valentin Korenblit To: linux-arm-kernel@lists.infradead.org Cc: kristina.martsenko@arm.com, Valentin Korenblit Subject: [boot-wrapper PATCH] gic: assign last ITLine to group 1 Date: Thu, 27 Oct 2022 17:32:10 +0200 Message-Id: <20221027153210.30692-1-vkorenblit@sequans.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_083221_408930_465392FE X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ITLinesNumber, bits [4:0] == NUM_SPIS/32 The loop is not considering the last irq line, thus only NUM_SPIS-32 are usable in non-secure mode. Signed-off-by: Valentin Korenblit --- common/gic-v3.c | 2 +- common/gic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/gic-v3.c b/common/gic-v3.c index 6207007..23d6dc5 100644 --- a/common/gic-v3.c +++ b/common/gic-v3.c @@ -91,7 +91,7 @@ void gic_secure_init_primary(void) } while (!(typer & GICR_TYPER_Last)); typer = raw_readl(gicd_base + GICD_TYPER); - for (i = 1; i < (typer & GICD_TYPER_ITLineNumber); i++) { + for (i = 1; i <= (typer & GICD_TYPER_ITLineNumber); i++) { raw_writel(~0x0, gicd_base + GICD_IGROUP0 + i * 4); raw_writel(0x0, gicd_base + GICD_IGRPMOD0 + i * 4); } diff --git a/common/gic.c b/common/gic.c index 04d4289..6c3ee76 100644 --- a/common/gic.c +++ b/common/gic.c @@ -41,7 +41,7 @@ void gic_secure_init(void) uint32_t typer = raw_readl(gicd_base + GICD_TYPER); /* Set SPIs to Group 1 */ - for (i = 1; i < (typer & GICD_TYPER_ITLineNumber); i++) + for (i = 1; i <= (typer & GICD_TYPER_ITLineNumber); i++) raw_writel(~0, gicd_base + GICD_IGROUPRn + i * 4); raw_writel(GICD_CTLR_EnableGrp0 | GICD_CTLR_EnableGrp1, -- 2.20.1 -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel