Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99BE6C4332F for ; Tue, 1 Nov 2022 15:29:30 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.434842.687524 (Exim 4.92) (envelope-from ) id 1optCc-0001RH-47; Tue, 01 Nov 2022 15:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434842.687524; Tue, 01 Nov 2022 15:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCb-0001Qc-TB; Tue, 01 Nov 2022 15:29:21 +0000 Received: by outflank-mailman (input) for mailman id 434842; Tue, 01 Nov 2022 15:29:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCb-0007Tl-AO for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f43d8c1a-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B133F1F8E3; Tue, 1 Nov 2022 15:29:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 849211346F; Tue, 1 Nov 2022 15:29:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4R78Hk87YWO+YAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f43d8c1a-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBpnpvtRtx53neoNfKJ9kBe5E0CVVtJQnxw6pFlViTQ=; b=Ryg26mb5pXdhw1khCYn7z4/27NjZGgmswuPON1qOxmwXcRX/BRryG4vFYnp8VE2FNaCGn3 SBN2aXbQQJFrICf0GUkGjL6TijOAETGDR8pxGd0auGbXfC/AQyX1s1I+PZsF2105saUIlK D0sEVKe4jiVvjo2y2GpJ9Xl2CicbWXQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped Date: Tue, 1 Nov 2022 16:28:28 +0100 Message-Id: <20221101152842.4257-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a domain has been recognized to have stopped, remove all its registered watches. This avoids sending watch events to the dead domain when all the nodes related to it are being removed by the Xen tools. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index aa86892fed..1516df71d8 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -364,6 +364,12 @@ void check_domains(void) && !domain->shutdown) { domain->shutdown = true; notify = 1; + /* + * Avoid triggering watch events when the + * domain's nodes are being deleted. + */ + if (domain->conn) + conn_delete_all_watches(domain->conn); } if (!dominfo.dying) continue; -- 2.35.3