Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5144C4332F for ; Thu, 3 Nov 2022 21:31:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EFD8284F8B; Thu, 3 Nov 2022 22:31:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4174E80710; Thu, 3 Nov 2022 22:31:07 +0100 (CET) Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6CB685079 for ; Thu, 3 Nov 2022 22:31:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=janne@jannau.net Received: by soltyk.jannau.net (Postfix, from userid 1000) id 7FF3926F2D0; Thu, 3 Nov 2022 22:31:03 +0100 (CET) Date: Thu, 3 Nov 2022 22:31:03 +0100 From: Janne Grunau To: Marek Vasut Cc: Simon Glass , u-boot@lists.denx.de, Mark Kettenis Subject: Re: [PATCH] usb: Add 1ms delay after first Get Descriptor request Message-ID: <20221103213103.GM4024@jannau.net> References: <20221030223835.422976-1-marex@denx.de> <3e17b8b3-d5ca-aa04-e8cf-c7a13724f240@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e17b8b3-d5ca-aa04-e8cf-c7a13724f240@denx.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022-10-31 21:57:39 +0100, Marek Vasut wrote: > On 10/31/22 20:27, Simon Glass wrote: > > Hi Marek, > > Hi, > > > On Sun, 30 Oct 2022 at 16:38, Marek Vasut wrote: > > > > > > Logitech Unifying Receiver 046d:c52b bcdDevice 12.10 seems > > > sensitive about the first Get Descriptor request. If there > > > are any other requests in the same microframe, the device > > > reports bogus data, first of the descriptor parts is not > > > sent to the host. Wait over one microframe duration before > > > issuing subsequent requests to avoid probe failure with > > > this device, since it can be used to connect USB keyboards. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Janne Grunau > > > Cc: Mark Kettenis > > > --- > > > common/usb.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > Is this device complying with the spec or is it broken? This is not just this device. We have seen this reported with a few keyboards on apple silicon devices. Keychron devices are one group I can remember. > > > > In any case we need a way to enable/disable this as it will slow down > > unaffected platforms. > > This makes little difference, since anyone can plug such device into a port > and suddenly the platform is affected. We cannot really predict what users > have on their desks. Would it make sense to limit it to dwc3 host controllers or do you fear the same problem could happen with other controllers on fast boards? In any case patch fixes the problem here as well. Tested-by: Janne Grunau Thanks, Janne