Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FB4C433FE for ; Tue, 8 Nov 2022 06:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233527AbiKHGU6 (ORCPT ); Tue, 8 Nov 2022 01:20:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233589AbiKHGUh (ORCPT ); Tue, 8 Nov 2022 01:20:37 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24774419AA for ; Mon, 7 Nov 2022 22:20:34 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id E884E68C7B; Tue, 8 Nov 2022 07:20:30 +0100 (CET) Date: Tue, 8 Nov 2022 07:20:30 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , linux-block@vger.kernel.org Subject: Re: [PATCH] blk-mq: remove blk_mq_alloc_tag_set_tags Message-ID: <20221108062030.GA19853@lst.de> References: <20221107061706.1269999-1-hch@lst.de> <97c6c6b7-1de5-a341-e24c-f18e62aeaae7@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97c6c6b7-1de5-a341-e24c-f18e62aeaae7@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 07, 2022 at 09:20:37PM -0700, Jens Axboe wrote: > Getting rid of the helper is nice, but the realloc one is badly > named imho. Can we rename that while at it? There are only 1 > caller after this anyway. Tell me your preferred name and I'll do it.