Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC629C433FE for ; Tue, 8 Nov 2022 16:50:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A1798503B; Tue, 8 Nov 2022 17:50:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667926230; bh=zeDkv07JsQJstAg/LipmTtAuXdVd+M/Jjv0XPZXnPrI=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=N+mhTJT5XVWt83FHuM46QEwrzOnDnZw/fG+4Tty0/+RGC98Efx86/w0KRTrk7zE5y Aqt0TWM3vndg46+jqmya+8JTFntKbkSOspZLqbawf6MCkMXAOHTUtAy1gVifQ2SS1M ZEIVP8FSf7AFISGvITWcBLsAJ+mMYDAEzSO+Zca5Ev8PqropM4EZPxkMVxp5scvvVj O8tF93K9RKa+co92nhvhkMTJdEW1dDV0Fm9DRlM6KXwYuCvx3sjNNQ/HVAVoXVjCbR S3PNTJO6LwICDc8O1KDG4EPR1alDZc68zW1UxNQytg/1ODyqEUALZpvrniAgD3l0wU SBOcB1b2sgj4g== Received: by phobos.denx.de (Postfix, from userid 109) id 7013384F72; Tue, 8 Nov 2022 17:49:55 +0100 (CET) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CFE9385045 for ; Tue, 8 Nov 2022 17:38:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4N6DLt2h9qz1s94G; Tue, 8 Nov 2022 17:38:46 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4N6DLt1RFzz1qqlR; Tue, 8 Nov 2022 17:38:46 +0100 (CET) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id ROZSRPWr4FTH; Tue, 8 Nov 2022 17:38:45 +0100 (CET) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 8 Nov 2022 17:38:45 +0100 (CET) From: sbabic@denx.de X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1682465 X-Patchwork-Delegate: sbabic@denx.de To: Matthias Schiffer , u-boot@lists.denx.de Subject: [PATCH] ARM: mx7: psci: fix suspend/resume e10133 workaround In-reply-to: <20220926083108.10934-1-matthias.schiffer@ew.tq-group.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20221108164955.7013384F72@phobos.denx.de> Date: Tue, 8 Nov 2022 17:49:50 +0100 (CET) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > The e10133 workaround was broken in two places: > - The code intended to temporarily mask all interrupts in GPC_IMRx_CORE0. > While the old register values were saved, the actual masking was > missing. > - imx_udelay() expects the system counter to run at its base frequency, > but the system counter is switched to a lower frequency earlier in > psci_system_suspend(), leading to a much longer delay than intended. > Replace the call with an equivalent loop (linux-imx 5.15 does the same) > This fixes the SoC hanging forever when there was already a wakeup IRQ > pending while suspending. > Fixes: 57b620255e ("imx: mx7: add system suspend/resume support") > Signed-off-by: Matthias Schiffer Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================