Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD58EC433FE for ; Tue, 8 Nov 2022 23:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667949110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vkuAdhBfUjvGUiOBYvsP1ETf9lKipZrBH7xgoN7wu4Y=; b=bNykxjfTQi153CVpiT0Hiw1XEUmX6nB/oHGs0ooFj2vNCRYhgPR0dkzB2w1mw5fPJzQ0uc kwHdXKQYvLUI3dCQ7o8wR3+50s6CTjrFxjU4JOrOPtzBX+GDHjOjjYoS+Prf2BPT28Y6QK KTy944zfsdgZ866HZ6311n5VnWPVMck= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-rMlFXSEbNBmg33XqJRTH6w-1; Tue, 08 Nov 2022 18:11:46 -0500 X-MC-Unique: rMlFXSEbNBmg33XqJRTH6w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCB7A101A54E; Tue, 8 Nov 2022 23:11:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB2F111F3BB; Tue, 8 Nov 2022 23:11:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2DBF2194658F; Tue, 8 Nov 2022 23:11:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 046991946588 for ; Tue, 8 Nov 2022 23:11:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BB3F64B3FCF; Tue, 8 Nov 2022 23:11:39 +0000 (UTC) Received: from octiron.msp.redhat.com (octiron.msp.redhat.com [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96F7E4B3FC6; Tue, 8 Nov 2022 23:11:39 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 2A8NBcuh002557; Tue, 8 Nov 2022 17:11:38 -0600 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 2A8NBb5E002556; Tue, 8 Nov 2022 17:11:37 -0600 Date: Tue, 8 Nov 2022 17:11:37 -0600 From: Benjamin Marzinski To: Xose Vazquez Perez Message-ID: <20221108231137.GL19568@octiron.msp.redhat.com> References: <20221105213733.182458-1-xose.vazquez@gmail.com> MIME-Version: 1.0 In-Reply-To: <20221105213733.182458-1-xose.vazquez@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Subject: Re: [dm-devel] [PATCH] multipath-tools: multipath.conf man page housekeeping X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DM-DEVEL ML , Martin Wilck Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Nov 05, 2022 at 10:37:33PM +0100, Xose Vazquez Perez wrote: > Mark deprecated options as (Deprecated), and standardize the description > Document pg_timeout > Default value of "features" is "0" > directio is also an alternative to readsector0 > > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez Reviewed-by: Benjamin Marzinski > --- > multipath/multipath.conf.5 | 41 ++++++++++++++++++++------------------ > 1 file changed, 22 insertions(+), 19 deletions(-) > > diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 > index 8e28ba12..063b05a7 100644 > --- a/multipath/multipath.conf.5 > +++ b/multipath/multipath.conf.5 > @@ -178,7 +178,7 @@ The default is: \fBno\fR > . > .TP > .B multipath_dir > -This option is not supported any more. The value is ignored. > +(Deprecated) This option is not supported any more, and the value is ignored. > . > . > .TP > @@ -242,6 +242,11 @@ The default is: \fBfailover\fR > . > . > .TP > +.B pg_timeout > +(Deprecated) This option is not supported any more, and the value is ignored. > +. > +. > +.TP > .B uid_attrs > . > Setting this option activates \fBmerging uevents\fR by WWID, which may improve > @@ -283,7 +288,7 @@ The default is: \fBID_WWN\fR, for NVMe devices > . > .TP > .B getuid_callout > -This option is not supported any more. The value is ignored. > +(Deprecated) This option is not supported any more, and the value is ignored. > . > . > .TP > @@ -468,7 +473,7 @@ cannot be changed. \fInvme:tcp\fR paths are only supported in multipath > devices with queue_mode set to \fIbio\fR. multipath will automatically > set this when creating a device with \fInvme:tcp\fR paths. > .TP > -The default is: \fB\fR > +The default is: \fB0\fR > .RE > . > . > @@ -484,7 +489,7 @@ second, until \fIchecker_timeout\fR seconds have elapsed. Possible values are: > .TP 12 > .I readsector0 > (Deprecated) Read the first sector of the device. This checker is being > -deprecated, please use \fItur\fR instead. > +deprecated, please use \fItur\fR or \fIdirectio\fR instead. > .TP > .I tur > Issue a \fITEST UNIT READY\fR command to the device. > @@ -556,7 +561,7 @@ The default is: \fBmanual\fR > . > . > .TP > -.B rr_min_io > +.B rr_min_io > Number of I/O requests to route to a path before switching to the next in the > same path group. This is only for \fIBlock I/O\fR(BIO) based multipath and > only apply to \fIround-robin\fR path_selector. > @@ -740,7 +745,7 @@ The default is: \fB\fR > . > .TP > .B bindings_file > -This option is deprecated, and will be removed in a future release. > +(Deprecated) This option is deprecated, and will be removed in a future release. > The full pathname of the binding file to be used when the user_friendly_names > option is set. > .RS > @@ -751,7 +756,7 @@ The default is: \fB/etc/multipath/bindings\fR > . > .TP > .B wwids_file > -This option is deprecated, and will be removed in a future release. > +(Deprecated) This option is deprecated, and will be removed in a future release. > The full pathname of the WWIDs file, which is used by multipath to keep track > of the WWIDs for LUNs it has created multipath devices on in the past. > .RS > @@ -762,7 +767,7 @@ The default is: \fB/etc/multipath/wwids\fR > . > .TP > .B prkeys_file > -This option is deprecated, and will be removed in a future release. > +(Deprecated) This option is deprecated, and will be removed in a future release. > The full pathname of the prkeys file, which is used by multipathd to keep > track of the persistent reservation key used for a specific WWID, when > \fIreservation_key\fR is set to \fBfile\fR. > @@ -934,7 +939,7 @@ The default is: \fB\fR > . > .TP > .B config_dir > -This option is not supported any more. The value is ignored. > +(Deprecated) This option is not supported any more, and the value is ignored. > . > . > .TP > @@ -1047,7 +1052,7 @@ The default is: \fBno\fR > . > .TP > .B delay_watch_checks > -This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_forget_rate\fR. > +(Deprecated) This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_forget_rate\fR. > If this is set to a value greater than 0 and no \fIsan_path_err\fR options > are set, \fIsan_path_err_forget_rate\fR will be set to the value of > \fIdelay_watch_checks\fR and \fIsan_path_err_threshold\fR will be set to 1. > @@ -1061,7 +1066,7 @@ The default is: \fBno\fR > . > .TP > .B delay_wait_checks > -This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_recovery_time\fR. > +(Deprecated) This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_recovery_time\fR. > If this is set to a value greater than 0 and no \fIsan_path_err\fR options > are set, \fIsan_path_err_recovery_time\fR will be set to the value of > \fIdelay_wait_checks\fR times \fImax_polling_interval\fR. This will give > @@ -1228,8 +1233,7 @@ The default is: \fBno\fR > . > .TP > .B disable_changed_wwids > -This option is deprecated and ignored. If the WWID of a path suddenly changes, > -multipathd handles it as if it was removed and then added again. > +(Deprecated) This option is not supported any more, and the value is ignored. > .RE > . > . > @@ -1848,7 +1852,7 @@ normal pathgroup. The logic of determining \(dqshaky\(dq condition, as well as > the logic when to reinstate, differs between the three methods. > .TP 8 > .B \(dqdelay_checks\(dq failure tracking > -This method is \fBdeprecated\fR and mapped to the \(dqsan_path_err\(dq method. > +(Deprecated) This method is \fBdeprecated\fR and mapped to the \(dqsan_path_err\(dq method. > See the \fIdelay_watch_checks\fR and \fIdelay_wait_checks\fR options above > for more information. > . > @@ -1878,16 +1882,15 @@ path checks by multipathd, which is variable and controlled by the > . > .TP > .B \(dqFPIN \(dq failure tracking > +(Deprecated) This method is \fBdeprecated\fR in favor of the \(dqmarginal_path\(dq > +failure tracking method, and only offered for backward compatibility. > +.RS 8 > +.LP > Fibre channel fabrics can notify hosts about fabric-level issues such > as integrity failures or congestion with so-called Fabric Performance > Impact Notifications (FPINs).On receiving the fpin notifications through ELS > multipathd will move the affected path and port states to marginal. > . > -.RS 8 > -.LP > -This method is \fBdeprecated\fR in favor of the \(dqmarginal_path\(dq failure > -tracking method, and only offered for backward compatibility. > -. > .RE > .LP > See the documentation > -- > 2.38.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel