Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434F4C43217 for ; Wed, 9 Nov 2022 18:41:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbiKISlD (ORCPT ); Wed, 9 Nov 2022 13:41:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbiKISlA (ORCPT ); Wed, 9 Nov 2022 13:41:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920E9F036 for ; Wed, 9 Nov 2022 10:40:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3023161C30 for ; Wed, 9 Nov 2022 18:40:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 833CFC433D6; Wed, 9 Nov 2022 18:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668019258; bh=yCIqxIoXfc5kamIuxwM4Y1tlh9EQbVTy+Nv9vethuz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sk7O9Y7BCfNEcPsu0xp4jBIGP30eGpGAo/92sMVYHp9PKoccJL+6uOtUh4fm01k/I 4oEjdnvI4D3Wts0e3/FweRDPmgBKhQa3Qgo/erBvjNINH8/lqF5JVoD/CKrFTEHeov /qEOf/NLS7M6l9mRlahgYgiBSmGbN3h06V/bRIvHY6taqJ7fM+0dSouoS0WlJNWxpr w817jN3qVSepK0xZjiltkXAab1+NZeJXEr7A/9G0L+ybt/l7BL7vc4HxHqf//LF2J7 LmmLMn9SlXLr5Fv9RJlVVETFoYvc1sw4+qtl04Wov55aC1KuQWjx9qBtHP+kuHHNn7 01hmmUEYS9+hA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Roy Novich , Alexander Schmidt , Moshe Shemesh Subject: [V3 net 02/10] net/mlx5: Allow async trigger completion execution on single CPU systems Date: Wed, 9 Nov 2022 10:40:42 -0800 Message-Id: <20221109184050.108379-3-saeed@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221109184050.108379-1-saeed@kernel.org> References: <20221109184050.108379-1-saeed@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roy Novich For a single CPU system, the kernel thread executing mlx5_cmd_flush() never releases the CPU but calls down_trylock(&cmd→sem) in a busy loop. On a single processor system, this leads to a deadlock as the kernel thread which executes mlx5_cmd_invoke() never gets scheduled. Fix this, by adding the cond_resched() call to the loop, allow the command completion kernel thread to execute. Fixes: 8e715cd613a1 ("net/mlx5: Set command entry semaphore up once got index free") Signed-off-by: Alexander Schmidt Signed-off-by: Roy Novich Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c index 46ba4c2faad2..2e0d59ca62b5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c @@ -1770,12 +1770,17 @@ void mlx5_cmd_flush(struct mlx5_core_dev *dev) struct mlx5_cmd *cmd = &dev->cmd; int i; - for (i = 0; i < cmd->max_reg_cmds; i++) - while (down_trylock(&cmd->sem)) + for (i = 0; i < cmd->max_reg_cmds; i++) { + while (down_trylock(&cmd->sem)) { mlx5_cmd_trigger_completions(dev); + cond_resched(); + } + } - while (down_trylock(&cmd->pages_sem)) + while (down_trylock(&cmd->pages_sem)) { mlx5_cmd_trigger_completions(dev); + cond_resched(); + } /* Unlock cmdif */ up(&cmd->pages_sem); -- 2.38.1