Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1BBC4332F for ; Thu, 17 Nov 2022 21:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229451AbiKQVOA (ORCPT ); Thu, 17 Nov 2022 16:14:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233270AbiKQVNy (ORCPT ); Thu, 17 Nov 2022 16:13:54 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3798556D41 for ; Thu, 17 Nov 2022 13:13:50 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ovmCh-00069N-JG; Thu, 17 Nov 2022 22:13:47 +0100 Date: Thu, 17 Nov 2022 22:13:47 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH v2 0/4] xt: Implement dump and restore support Message-ID: <20221117211347.GB15714@breakpoint.cc> References: <20221117174546.21715-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117174546.21715-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > If nft can't translate a compat expression, dump it in a format that can > be restored later without losing data, thereby keeping the ruleset > intact. Why? :-( This cements nft_compat.c forever. If we're goping to do it lets at least dump it properly, i.e. nft ... add rule compat "-m conntrack --ctstate NEW". At this time I'd rather like a time machine to prevent nft_compat.c from getting merged :-(