Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22562C4332F for ; Fri, 18 Nov 2022 12:36:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B0C5485248; Fri, 18 Nov 2022 13:36:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ht1l+Mq/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 64A958523E; Fri, 18 Nov 2022 09:50:11 +0100 (CET) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 35E7485103 for ; Fri, 18 Nov 2022 09:50:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilin.mikhail.ol@gmail.com Received: by mail-lf1-x130.google.com with SMTP id j16so7104929lfe.12 for ; Fri, 18 Nov 2022 00:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Za/uJHmuUDy2O0cvm7eRXhAKTJ7/lRoOESJXDeU7uU=; b=Ht1l+Mq/RVi5uKLU+q3YYSZOQYg7FM9jUmTEoKeaIpW2V/LNBMf2PtQ57LExOlw1qy j1DwvuFj+nEzHon+2t5esa17Pg8X3io/kuC/9tsV/c7gV/U4hPzOVdIlttmxc7SLpiAL eHZcTCH1+fLZrJwNGlhsQ3D3Pwou5Jn0cJgVeE12SoMlp+FyG/QfYORDUQU8/OBV8fnM kL2Wh0sgALsWdUBT2p3SWQJmLLS3c97uML20vClh1jQ6RHT5lAQEAyrzSOGcOag63KWT uMY56gEv5vtYleYxO5PyNCSHQQl3yKVSRiA1K/w0aP5DpOQoPjKJflE6V8DZNDVUAitJ 92+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Za/uJHmuUDy2O0cvm7eRXhAKTJ7/lRoOESJXDeU7uU=; b=Q71AyxBKk9gSZC0wCHw9o5FFJmRzEURbAs29055zfHK/PErVdJ8vs1d6eS1hNWeGbl dg6gLWcibNKgffjMJxfdEkIhYPirtW2VCEx3/1isFVEqLxuT7HJem3+NdYvK7GNbxnHO 75bLTkZEveMTvfsC9pc70smZWPTQicgzRmq5DajpdVTjNN4IMp+1NF6YfkBVqcl93LG6 wnWBevSuDHJM6pUyNmmeKjRj4ezwwp22yfft65kqSwB36osk1ydnHEwPR/nEpfZv4VD7 0hfrFBr/OLvVphoPWOQ6kv29BjHdOymSjb9CtA/XQi0/Vbrb5bj8bGfiqwp8DKCXfiQz /Akg== X-Gm-Message-State: ANoB5plAYkMqoFMAA16rsAsxGZQ7x3/a6n/ZJ1FC7EIrvDrrQCbT1HNr Do+fzOPrFpir2CcOFR+wTUYsO4giM1cihpnudWk= X-Google-Smtp-Source: AA0mqf4WROfBg6LUQeoaEAVRZG5UKQSQSzh2cwuWlihmr7nprNVZoy3upN7Bdzom76X57tKGAYU8Sg== X-Received: by 2002:ac2:4219:0:b0:4a2:2701:7d29 with SMTP id y25-20020ac24219000000b004a227017d29mr2259140lfh.322.1668761408023; Fri, 18 Nov 2022 00:50:08 -0800 (PST) Received: from milin-wrk.rasu.local ([178.70.40.200]) by smtp.gmail.com with ESMTPSA id s9-20020a056512214900b004acff58a951sm578469lfr.133.2022.11.18.00.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 00:50:07 -0800 (PST) From: Mikhail Ilin To: u-boot@lists.denx.de Cc: Mikhail Ilin Subject: [PATCH v2020.01] tool: ifwitool: The function localtime() can return NULL. Date: Fri, 18 Nov 2022 11:50:02 +0300 Message-Id: <20221118085002.21577-1-ilin.mikhail.ol@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Fri, 18 Nov 2022 13:36:05 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean This will cause the local_time pointer is passed as the 4th argument to function strftime() to also point to NULL. This result in a segmentation fault. Thus, it's necessary to add a check of the local_time pointer to NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Mikhail Ilin --- tools/ifwitool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/ifwitool.c b/tools/ifwitool.c index 543e9d4e70..b9873deb6b 100644 --- a/tools/ifwitool.c +++ b/tools/ifwitool.c @@ -1630,6 +1630,8 @@ static void init_manifest_header(struct manifest_header *hdr, size_t size) curr_time = time(NULL); local_time = localtime(&curr_time); + assert(local_time != NULL); + strftime(buffer, sizeof(buffer), "0x%Y%m%d", local_time); hdr->date = strtoul(buffer, NULL, 16); -- 2.17.1