Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 56AC3409B6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 64D5F40306 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669061884; bh=IhNl1vJm3VXqLz/ACfcWWRbRVPnFw5gG6KxRJkVvCnA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lxUWsUEPCrFrZwmJ6lNTMZOQFI44VAboWP7tjFx/pVRPWovDYI4i5cPpy/6KUJGNg OI4+n/0mmTC1k7r98QA+zMbNSZuulwXCQPpP0tN/NedQjlCcjv3qNodgraUNJzkb1k b0greRQNwn4uhMPxVMJlD0x71Iu05YKJlsVK817AEVr2WdWdEkLyJtkhyArjGEMA3u kltB4rJmyfEj/C1p6c5lo0k1O/Aqf2K9nANgcCSqLIAlImpdUMzmK0cg5Bn8ZBF7U0 JXT+ZYBP65Dk4te31iG353KqFaUQnVVnxcr8NrDyADFAshMSeMn/6WT/K3fUauGbXz AysDyZtShvHdA== Date: Mon, 21 Nov 2022 12:18:03 -0800 From: Jakub Kicinski Message-ID: <20221121121803.31962489@kernel.org> In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org> References: <20221121094649.1556002-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kroah-Hartman Cc: linux-nfs@vger.kernel.org, "Rafael J. Wysocki" , netdev@vger.kernel.org, Nikolay Aleksandrov , bridge@lists.linux-foundation.org, Jeff Layton , linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Chuck Lever , Anna Schumaker , Roopa Prabhu , Paolo Abeni , Trond Myklebust On Mon, 21 Nov 2022 10:46:45 +0100 Greg Kroah-Hartman wrote: > The call, kobject_get_ownership(), does not modify the kobject passed > into it, so make it const. This propagates down into the kobj_type > function callbacks so make the kobject passed into them also const, > ensuring that nothing in the kobject is being changed here. > > This helps make it more obvious what calls and callbacks do, and do not, > modify structures passed to them. Acked-by: Jakub Kicinski