Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86709C4332F for ; Mon, 21 Nov 2022 14:54:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 857A4852C4; Mon, 21 Nov 2022 15:54:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kSbm9PXO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B69E0852B1; Mon, 21 Nov 2022 15:54:29 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 70039852C4 for ; Mon, 21 Nov 2022 15:54:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id c15so7358194qtw.8 for ; Mon, 21 Nov 2022 06:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s7s3nV86tve9JWm7gm0CCZ56+zs3u8Gbf+tR6C4ulaE=; b=kSbm9PXORr/hxi+1fR5+dqApnpFSvmkq82nn3SuqEnqwJth16yv1mvNMsjCwq37Ogq x74ZznzTbd5r/wCOyzMcbB/VwHKR6TWPB4JdgPKDdtOIaosO9gcNwIeA/LEHCnw25aJL QyTrphHSj2M5hueambrbZJX1lPVTmX0K8Ce98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s7s3nV86tve9JWm7gm0CCZ56+zs3u8Gbf+tR6C4ulaE=; b=d78+SmlerIrPynj035MKnmUDxLonqLkfUkLdCluJpXTh9KFsCfVCRHLk3ZPm2JcQyU 2A4AmyMqc3nmrOVke9lR5e4XNQVmGMXKDOfwA0TdzD50tn/scTvNCtL+SAyvZDo4EXBe rU7jn/jg9UjAuRiF5N6189Wb1NmmEHufbWmHlgOLSrnBCJpIm51vZ5cqi6Ytuhjdo4JC eTOf8OxV1lueCyktUWmZXwQj7HOmVwMUnmQaVWwsjZsaBlzJ9hYeJVyxbmLZnsernwdB 8nSaqEpsuPFfX32d7Gn0Y5m4HWmNVnqfh0KMKHGNupQR23rGaGcLTOhy/8HC9gIAtTZD y/eA== X-Gm-Message-State: ANoB5pnLTxbqkWI5m7crgHGJUC/ytoHBvrIuc39sKtEi/vpatn8Ad2cC 1kUiocjjPDMsPhsMUBvDeXQbVA== X-Google-Smtp-Source: AA0mqf6OMQo8AC4+d9a6rztFM/RRCkMnVffo2sa0U+Ytg1E7SSlFJsIOZCIU1RV6W3F22dTPT2mmgA== X-Received: by 2002:a05:622a:904:b0:3a5:1e70:f3cd with SMTP id bx4-20020a05622a090400b003a51e70f3cdmr18433589qtb.70.1669042463195; Mon, 21 Nov 2022 06:54:23 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-91a3-6c7b-3405-8039.res6.spectrum.com. [2603:6081:7b00:6400:91a3:6c7b:3405:8039]) by smtp.gmail.com with ESMTPSA id s21-20020a05620a29d500b006ed30a8fb21sm8350546qkp.76.2022.11.21.06.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 06:54:22 -0800 (PST) Date: Mon, 21 Nov 2022 09:54:20 -0500 From: Tom Rini To: Sergei Antonov Cc: u-boot@lists.denx.de, Simon Glass Subject: Re: [PATCH] rtc: add ht1380 driver Message-ID: <20221121145420.GH7282@bill-the-cat> References: <20221025142326.339332-1-saproj@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iwjEIfU64POCkTAH" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --iwjEIfU64POCkTAH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 21, 2022 at 05:47:16PM +0300, Sergei Antonov wrote: > On Wed, 26 Oct 2022 at 14:34, Sergei Antonov wrote: > > > > On Wed, 26 Oct 2022 at 02:35, Simon Glass wrote: > > > > > > +static void ht1380_half_period_delay(void) > > > > +{ > > > > + /* Delay for half a period. 1 us complies with the 500 KHz = maximum > > > > + input serial clock limit given by the datasheet. */ > > > > > > /* > > > * Delay for half... > > > * second line > > > */ > > > > > > Please fix globally. > > > > OK. I was confused by doc/develop/codingstyle.rst: > > * The exception for net files to the `multi-line comment > > `_ > > applies only to Linux, not to U-Boot. > > What is the U-Boot style of multi-line comments remains a mystery to me. >=20 > Tom, > could you please clarify what is U-Boot style for multi-line comments? > I can not draw it from doc/develop/codingstyle.rst I'll make an attempt at re-wording the line there, but, per: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting /* * It should be * like this. */ --=20 Tom --iwjEIfU64POCkTAH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN7kRkACgkQFHw5/5Y0 tyzk0AwAuX6We0e/N3oO/bLuv8RCGpsAss7+QeXQ6YMFyKTM5SG5YJslfPn4lpY8 8NUL9Ewsr2+X+KEHjkLMQORw+ApGlv/yLTkQspSuPytdob7QRCqh1o8Gye9WE2Mk pz+Z/jwoAe0UWU50paKgxEbAoYr0iOanzUyG6ETTjr+r+vGK5zUqgKcGhoWZkU8Y JkDilmFQG2q88cz5qBN6KcZMAx7c4NLnghFjFpsNu+hLetF7Vitt9PdbLCMxf+7l BNhzmiIwXLuEKeET+YgI7pBo3jNTpTH1F6QgF1nVvR2dJ1vKbzGO2xGHs9hx8OUY Rf2W8tcUXlV22TsEFlYPyeXO5CtFEyHM8cRXhcbfVFucuz0uYw4TX8RMCMopyfjy KfFPFdGWCPq3TExj02UjEc9FQltAm/IsJ4icBWaSif2Zj81zEj4tWlTdx0yOVqab 2rubpVuuf6eYEa8FRHspob0N8bnAyby9Pl9j3TBWRTvo6FPiUwzrYI3e3WQ+KrlS LN5nVkXi =b5G9 -----END PGP SIGNATURE----- --iwjEIfU64POCkTAH--