Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34BB2C4332F for ; Mon, 21 Nov 2022 17:34:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E05C852EA; Mon, 21 Nov 2022 18:33:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DveGTneA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 61692852D3; Mon, 21 Nov 2022 18:33:56 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8871F852EA for ; Mon, 21 Nov 2022 18:33:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id w9so7684472qtv.13 for ; Mon, 21 Nov 2022 09:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RT2lzx5QiT25LEoD/vZNMwuzavAEXGHak45BxyHvqqw=; b=DveGTneAl3Mr5HmuGv4AHwbWhbHrOD1Bve1F0OIjIbdPi6BpmZK5unRpxIxBmjBSDl S1hqcACAym3SzW1XKSGGOkYq2GCdMFfh2ct22U5yPVTM3EUuL72kADatNlhlzQ5hSW8S 5bvClWJTooMpFU5EdNOTdULyC4fKAedeJBjK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RT2lzx5QiT25LEoD/vZNMwuzavAEXGHak45BxyHvqqw=; b=P9AjoDL0xBVPXB77n9hPAw1MCwdKEdQNsLXS3w9WV5L7H/1+sL/16RpbyLUSMD/s6b yWO0T6h4qXVUv7z/K0Ysl6R4ZFwzIWP/pT8P+uxN7hk3U91u6HxDeajgSuuTaKsAmNRH vniYvz+QR8xVsMDrChje6DKlutinZmm51+CYQUszSYBaPDTW8+8z2bSw+Zx+bYs73Ge4 6Py/sklit8CcrNyvrke0R9ULbZGHO63fzelymUKitJ7m3D+8IbMBOm6UozJen+tGveFJ VegNTmbSiF7TDGb+n8fybL4ZvNaOBx22+HplMtmnuv3tktb7pl/WXqZm8TjXIUB+VfVJ +xZA== X-Gm-Message-State: ANoB5pndjg9JdIkOg28HTRSt6OuVIffYZH+xI+K3xqnY0/2YABRVYLHO OR0PDzytqifGRtuZiVP11/Bzbg== X-Google-Smtp-Source: AA0mqf65R/6f5P/1B+8Ub5Dep8Njmj7/qYPqp7PrROaYaWbTjky6FZWydibVZR6ERQriNLj3/KGU7Q== X-Received: by 2002:ac8:6bd8:0:b0:3a5:2105:677e with SMTP id b24-20020ac86bd8000000b003a52105677emr17816828qtt.127.1669052032276; Mon, 21 Nov 2022 09:33:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-91a3-6c7b-3405-8039.res6.spectrum.com. [2603:6081:7b00:6400:91a3:6c7b:3405:8039]) by smtp.gmail.com with ESMTPSA id gc7-20020a05622a59c700b0035ce8965045sm6976038qtb.42.2022.11.21.09.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 09:33:51 -0800 (PST) Date: Mon, 21 Nov 2022 12:33:49 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Troy Kisky , Joe Hershberger , Wolfgang Denk , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 1/2] Fix usage of CONFIG_PREBOOT Message-ID: <20221121173349.GM7282@bill-the-cat> References: <20220710114256.27322-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E50aLcSU4JxQSj/B" Content-Disposition: inline In-Reply-To: <20220710114256.27322-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --E50aLcSU4JxQSj/B Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 10, 2022 at 01:42:55PM +0200, Pali Roh=E1r wrote: > Due to usage of PREBOOT in Kconfig, macro CONFIG_PREBOOT is always defined > when CONFIG_USE_PREBOOT is enabled. In case CONFIG_PREBOOT is not > explicitly enabled it is set to empty C string and therefore > '#ifdef CONFIG_PREBOOT' guard does not work. Fix this issue by introducing > a new Kconfig symbol PREBOOT_DEFINED which cause to define new C macro > CONFIG_PREBOOT_DEFINED only when CONFIG_PREBOOT is really defined. >=20 > Change usage of '#ifdef CONFIG_PREBOOT' by '#ifdef CONFIG_USE_PREBOOT' for > code which checks if preboot code would be called and by > '#ifdef CONFIG_PREBOOT_DEFINED' for defining preboot code. >=20 > Signed-off-by: Pali Roh=E1r For the record, we need to long term figure out a better solution to user configurable default environment stuff. Doing this via Kconfig is fragile / problematic. However, as this patch does solve a real problem, applied to u-boot/master, thanks! --=20 Tom --E50aLcSU4JxQSj/B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN7tn0ACgkQFHw5/5Y0 tyzu0gwAszHLsm9rCdVeqaXSSzGmdENJrdVaBVMH/6DPJ4+p06ZjPmGyPCha8DFi 8hzMvRoSwU9xEBuOm0mTLB1sRi0zrbXxGTEV0RU6ERWqVYjaOoGRxilBenzHQ/Vq aNqZwa9gj3z1iIVmrLYN+wiexFnFHwIJ4thEjuCrwxQ5+ZVc2g3hrUsNmAHIsMtI mThhnGbOri+otMGKpF5pRoVRxdWCTW/ifOCuhc8W6F2nRN3lsVNqM0P/JQMmKhCw BYDLO9deNtZTXONtxmHtphv1iXyqDdeK9QCg8TX0ykXlVqF3rfbO3kmKb5qj3993 9WxjSwr0Vk7ycH5sjTE5qXdEorsAYojlJALxftECos7C4d86H6ondDq7kkaWpRNv yNOqY0jPCZj6hf882n1CB2MwOcC422CnHiWf3aYtYxxPWYS+rSvH6sN04wDEVsvY Ac5D6Pv+IEAmGkCPT0h1AJV/bef/QuCrY3RZQXafTZZYi5M8oHg6HloTFDVZtHUP lQkzv9kn =RFlI -----END PGP SIGNATURE----- --E50aLcSU4JxQSj/B--