From: qinhaijun@eswincomputing.com Date: Tue, 22 Nov 2022 15:13:21 +0800 Subject: [PATCH 1/1] lib: sbi_ecall_base: add check for function parameter pointers In-Reply-To: <20221122071321.4274-1-qinhaijun@eswincomputing.com> References: <20221122071321.4274-1-qinhaijun@eswincomputing.com> Message-ID: <20221122071321.4274-2-qinhaijun@eswincomputing.com> List-Id: To: opensbi@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: haijun qin When a null pointer is passed in by mistake, the program will enter the trap, so the check for the pointer is added. Signed-off-by: haijun qin --- lib/sbi/sbi_ecall_base.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/sbi/sbi_ecall_base.c b/lib/sbi/sbi_ecall_base.c index 786d2ac..3d4a367 100644 --- a/lib/sbi/sbi_ecall_base.c +++ b/lib/sbi/sbi_ecall_base.c @@ -39,6 +39,9 @@ static int sbi_ecall_base_handler(unsigned long extid, unsigned long funcid, { int ret = 0; + if(out_val == NULL) + return SBI_EINVALID_ADDR; + switch (funcid) { case SBI_EXT_BASE_GET_SPEC_VERSION: *out_val = (SBI_ECALL_VERSION_MAJOR << -- 2.17.1