Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0F5FC4332F for ; Tue, 22 Nov 2022 07:33:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 324DE8529D; Tue, 22 Nov 2022 08:33:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="e7SQ2j3d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00C1083600; Tue, 22 Nov 2022 08:33:42 +0100 (CET) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E2EE0852A6 for ; Tue, 22 Nov 2022 08:33:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilin.mikhail.ol@gmail.com Received: by mail-lj1-x22f.google.com with SMTP id t10so17058384ljj.0 for ; Mon, 21 Nov 2022 23:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+4OT9VFHFzplOvGQPn3+bVJHMCxWoK05KlrZP2BfoAY=; b=e7SQ2j3daxd/jKVvbE2xXfmcVbfakxqUHLEiNY7X93T76ymdaHzthK1et/kfqeDdpI 6IrLJQuWNczoOJ6xCWcCsXUTCjqxR+GjeHeY2GTX3yoeuV4QQVs6EvUzUTAo/7X3FQbf nXr3SC1pQIv8JFwVwHpYXkwIi6J24qN6TwO829tZ10qZDi2vUiKCE53Hs+sw5F8yBfgd 7vgFcQM4IrVw6p8l2TJoPPmIcgzfboix7BJH6bhSZIKLSF6LBOZ7fzzCRxI60scCUW+q sNOmPMatqC5eTplO4ZOV+cK5cuuniIB4beY6z1M9CFYXS/Q1VSsJogqdN05WQveFXMtI 6YoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+4OT9VFHFzplOvGQPn3+bVJHMCxWoK05KlrZP2BfoAY=; b=a0PdqhwhEMciuy4llvF+2uK7LFzsVEhOfPmm3PBVGR/4jpWendT7FgRcS7m/mdLIF8 mjIsiNGND1mP8upE9i/GND6vtpMzmo6B8CI5+7zx1TpdbPk8GstMyk9/4f04lsrkr2Ko jOO7CpCghQgZd9gAnkP40Z26jcn3RMMgnzTeXWQIF2uUfDpCCDyEvJTbnroEbBPcIdV8 iF3uXkDbHZW7bS5vblECS3mIaiLcdsuj4XpJCyc5yzVoj5u2WJv2SQUlIATYJCqDWAV3 HbMKk9Y59h/db1Qufn+V5tZ/aQsu3rdVlH4vZruVV6LLW1+Hm2TaTMnZuju2456d+AMm tPkQ== X-Gm-Message-State: ANoB5plpxSb3ReG2fZLbMZXuohTO1wo8vfy/bi5WRBMNSU6iM9GtPTZo XqtqW48QTL7eOZE6z/oD5XeCOKNUH6Q= X-Google-Smtp-Source: AA0mqf7HMCCEheYMGOGH5CYxw937t/osdlkmTQM/9Rw6d0Ji4Tu/RbKTnBfc9JWZG58uNHSQezxKHA== X-Received: by 2002:a05:651c:10a2:b0:279:e41:1481 with SMTP id k2-20020a05651c10a200b002790e411481mr2008679ljn.184.1669102418726; Mon, 21 Nov 2022 23:33:38 -0800 (PST) Received: from milin-wrk.rasu.local ([178.70.40.200]) by smtp.gmail.com with ESMTPSA id s1-20020a056512214100b004a45ed1ae21sm2340911lfr.224.2022.11.21.23.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 23:33:38 -0800 (PST) From: Mikhail Ilin To: u-boot@lists.denx.de Cc: Mikhail Ilin , Heinrich Schuchardt , Alexander Graf Subject: [PATCH] efi_loader: Fix buffer underflow If the array index 'i' < 128, the 'codepage' array is accessed using [-128...-1] in efi_unicode_collation.c:262. This can lead to a buffer overflow. Negative index in efi_unicode_collation.c:262. The index of the 'codepage' array should be c-0x80 instead of i-0x80. Date: Tue, 22 Nov 2022 10:33:24 +0300 Message-Id: <20221122073324.3135-1-ilin.mikhail.ol@gmail.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Fixes: 0bc4b0da7b59 ("efi_loader: EFI_UNICODE_COLLATION_PROTOCOL") Signed-off-by: Mikhail Ilin --- lib/efi_loader/efi_unicode_collation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_unicode_collation.c b/lib/efi_loader/efi_unicode_collation.c index c700be8756..282045b556 100644 --- a/lib/efi_loader/efi_unicode_collation.c +++ b/lib/efi_loader/efi_unicode_collation.c @@ -259,7 +259,7 @@ static void EFIAPI efi_fat_to_str(struct efi_unicode_collation_protocol *this, for (i = 0; i < fat_size; ++i) { c = (unsigned char)fat[i]; if (c > 0x80) - c = codepage[i - 0x80]; + c = codepage[c - 0x80]; string[i] = c; if (!c) break; -- 2.17.1