Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0FD4C43219 for ; Thu, 24 Nov 2022 21:33:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D33DA85628; Thu, 24 Nov 2022 22:33:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ckHQkplq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FE928562A; Thu, 24 Nov 2022 22:32:59 +0100 (CET) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 163A385628 for ; Thu, 24 Nov 2022 22:32:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x430.google.com with SMTP id x5so4176022wrt.7 for ; Thu, 24 Nov 2022 13:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9yk/ZSaq0hPed9lwoxOryZreAPAvwtelwUGWn4d3g4k=; b=ckHQkplqViFqoNE8MCgNwOpd5rPN9ldvyLzLX6t+PAWO1hNra19K22liiPuqXmPCDV fAL1MHyE+9exrk0aYvOeOkGMDVGo+BgaxgAZuyMreG9G8QdZs4Z5Th/xD16JfaJI6kXZ oPQz37gX5InJtz8W9a/lkDle2by2FFWHNqxeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9yk/ZSaq0hPed9lwoxOryZreAPAvwtelwUGWn4d3g4k=; b=6HT1Y5fS1rdG3yNwx2G9fh6Q+T2h5bwxuu+vHeABxwnKw8q3MdRnk2w8GmyiPFSUCR TiqOT9nXe7QeI669FMVBEtRyh0E2QejZBIND+sU4s1N8DFMLVjaOFyE455s4ty8sL2iC AQUXyg/J43Ax0taNDcK6gQOyQIQl5c/stWkmj194eAXobovUUJRL7ASlPjw57SuzHxkC e8RRaaKUvwz3eg4RXd01HNgyWnjjz3XKm1NKgADZ/4qeDwjdV8n/m+SOo3YZvwIZQZkG 4E2bS74pYewJJia6IWEOGf3EjnO52k9tBJnSsYfTeoFSSD6+G5Dj6WFkJy8EXUfXgDRr z6aA== X-Gm-Message-State: ANoB5pmCBOaUkul5iYRWhesQcTvIerVNRQjHkXH93ty0t+YMSORaVDQS 6trmSY3o7VHlta97wMAtEaI9Bg== X-Google-Smtp-Source: AA0mqf7vYZFtsjGkoGhyTrpjxyfsoRQZfqXIcDBWvELqqHXoiK0EdF2cMhn4EzdHgf8jJl8qfU3HfA== X-Received: by 2002:adf:e283:0:b0:236:58e5:290d with SMTP id v3-20020adfe283000000b0023658e5290dmr15341360wri.2.1669325576530; Thu, 24 Nov 2022 13:32:56 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0c0d-8cfa-55df-646e.res6.spectrum.com. [2603:6081:7b00:6400:c0d:8cfa:55df:646e]) by smtp.gmail.com with ESMTPSA id s18-20020adfea92000000b0023677e1157fsm2272833wrm.56.2022.11.24.13.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 13:32:56 -0800 (PST) Date: Thu, 24 Nov 2022 16:32:53 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de Subject: Re: [PATCH] cmd: ubifs: Do not show usage when command fails Message-ID: <20221124213253.GF3787616@bill-the-cat> References: <20220807195856.19782-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K/NRh952CO+2tg14" Content-Disposition: inline In-Reply-To: <20220807195856.19782-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --K/NRh952CO+2tg14 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 07, 2022 at 09:58:56PM +0200, Pali Roh=E1r wrote: > Return value -1 cause U-Boot to print usage message. Return value > 1 (CMD_RET_FAILURE) indicates failure. So fix return value when ubifs > command starts it execution and fails. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Simon Glass > Reviewed-by: Dhruva Gole Applied to u-boot/master, thanks! --=20 Tom --K/NRh952CO+2tg14 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN/4wUACgkQFHw5/5Y0 tyzd2gv8DzI4NpCrYSpLXHsNpveY7ARWC0P1Ct7iZ7KIjA69kkYwXdI8lE7WZuhC z7e5cKUvffdpStCgQexEBFv8YvWbw2Mplyfp0XZ5HEa215A908MJm7R7ZHEZXIR0 ZAzhybSjughzYY5FxHykw6dyp9KQtbVEPcqaIUv56R8ZUEC7uliWHd0G95owu516 eJlRScPDrn8IMoH9ATLGFDuop7JNwzg8xoOSNjhUt6QsbAtgdsmPkQrGXAkCU8Oc Kv6i4I9o2MUsMMms9H7XrSJes5VKwGF7OVP/2TL4tU60/9n7C0qNJk4/gpPUH5Z6 WQSTInaS0luDYhC2N3bIIFhZPjow9OjpW0hSCU+PRIx1aohbX1odm24UyVd03N3c sMYjPilNgJL2VRIuF0UpJBjJ4zD4KKB3IV35hf7xLlV+/sBYJesKl5EPzs833GCJ KEiCh2xuTWUG7y4pTYhVIxPEsTTgvNwQw43TbNQ4G7j/u7Bl+8J/lhTtr2YU1goj adjfz6GN =Ix88 -----END PGP SIGNATURE----- --K/NRh952CO+2tg14--