Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7700CC433FE for ; Thu, 24 Nov 2022 21:33:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EA388563E; Thu, 24 Nov 2022 22:33:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jL+Z60zJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F6D385635; Thu, 24 Nov 2022 22:33:12 +0100 (CET) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EDEC985632 for ; Thu, 24 Nov 2022 22:33:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x42d.google.com with SMTP id bs21so4172648wrb.4 for ; Thu, 24 Nov 2022 13:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IhfwkdVNec0MhBG/j9HPus9pxSW/gRgrDBMZRNeq7q8=; b=jL+Z60zJ3cqlvoAiv6vY/KDa6gZNnHrgX8cf8HknOYZB7TutAtULm/r1HMeovX3icW O8q4cadeMmS12C6ItVOqJ9IB8ApKF3BwArAga38nKBiGDKMBrj91R392mR5rnib5sw2+ XXbw+Jaj9BZrhWpF6ZxnFCZQS6wwklGV5r4Sk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IhfwkdVNec0MhBG/j9HPus9pxSW/gRgrDBMZRNeq7q8=; b=dSprLSefLmrAy7AWcTiYu9lBNluv7HURE59fCRzDRLnrZ1Ux1EFUFReJ/7u1S2wNU+ e2Hh1KrdrBVXaESUPiUA+XB86zn6fw07JtSHH8NiuQ+C6Sl+bM9wLsOGDmPKxqOQt6sL oKt6gafmcGL1k70x60WEU063MX/jvH10YF3wOeZT6dxGUkFtDOOQC+RwuHh78gmlwLP6 yTluc9PNIfwiBQ1gsirx2EPmvhpIlDwx3uU2Ae4O5REa205H4Cx8AyTSJ9AlHVXfoZ4H PPiFDu81CN8yNZJGnoSeVrskIkt+G5sx8rwalhCn4GlDuhcIlVpmy0+rYxDE8WG+Y0IG eqoQ== X-Gm-Message-State: ANoB5pl/hDSmQ/UpjX+EmMSvx9hYH3w3ctNDmtvG8wj2kl6FOW9uJUsC 5pbWYZh5MMubbqlW6Sc6bzdyHyZbXXjTzw== X-Google-Smtp-Source: AA0mqf6X+JrvtOdcV3wY5PD1mgD+3WDbFTiYeOgr1On58K6JLLuSDhv7UniUrgPUX5fHFjbE2mEVmA== X-Received: by 2002:adf:f042:0:b0:241:f764:785c with SMTP id t2-20020adff042000000b00241f764785cmr4834104wro.334.1669325589560; Thu, 24 Nov 2022 13:33:09 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0c0d-8cfa-55df-646e.res6.spectrum.com. [2603:6081:7b00:6400:c0d:8cfa:55df:646e]) by smtp.gmail.com with ESMTPSA id l1-20020a05600c4f0100b003c6f3f6675bsm7579852wmq.26.2022.11.24.13.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 13:33:09 -0800 (PST) Date: Thu, 24 Nov 2022 16:33:06 -0500 From: Tom Rini To: Dylan Hung Cc: ryan_chen@aspeedtech.com, chiawei_wang@aspeedtech.com, joel@jms.id.au, u-boot@lists.denx.de, BMC-SW@aspeedtech.com Subject: Re: [PATCH 1/3] ram: ast2600: Fix incorrect statement of the register polling Message-ID: <20221124213306.GH3787616@bill-the-cat> References: <20221111073008.16364-1-dylan_hung@aspeedtech.com> <20221111073008.16364-2-dylan_hung@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MGu/vTNewDGZ7tmp" Content-Disposition: inline In-Reply-To: <20221111073008.16364-2-dylan_hung@aspeedtech.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --MGu/vTNewDGZ7tmp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2022 at 03:30:06PM +0800, Dylan Hung wrote: > The condition "~data" in the if-statement is a typo. The original > intention is to poll if SDRAM_PHYCTRL0_INIT bit equals to 0. So use > "data =3D=3D 0" for instead. >=20 > Besides, the bit[1] of "phy_status" register is hardwired to > SDRAM_PHYCTRL0_INIT (with inverse logic). Since SDRAM_PHYCTRL0_INIT has > already done, remove the unnecessary checking of phy_status[1]. >=20 > Fixes: fde93143469f ("ram: aspeed: Add AST2600 DRAM control support") >=20 > Signed-off-by: Dylan Hung Applied to u-boot/master, thanks! --=20 Tom --MGu/vTNewDGZ7tmp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN/4xEACgkQFHw5/5Y0 tyxv2gv8D8dL4M5oJLzADU3u32Jk1IM7misY9zqHUyTX1sNiCBYGhkB9qa2sBh1j 0KENEi+QRL5Wf92NYGn9ioydURGHL/bnYD8Q/Ygbli/n5l+DAu11n0c9xzKseytl DLEwZMcYWxydyBows2ITRGajSY+w1sZLcRE9EEneBeJ6ndj2mc6CbAtgQ4VrMXsi dhYxgZ4VXcQQ0TPw0VvUS6BsTjQ8jbOkIosCqXNTy5dDjLMYzf7kHelyHaFZcyIi qliUV5+OlzJDhOR2P0OtiUha/JUYIAAsBLj7CmEssAuSOM/nUW+GPRQ+ak082Umb QNtTvAAz+nYBmNeaOkYNhSFgjhzLI8V2ZE6KguagSsJxPz0jB+IyBZcOvkkS3uRN Dck98J9Efed7O96ERNkqzm5VnsJZi47LF0bwatb94wUVSKNcjWxmIQ9oIFFTSrpv IwJw2l0O17A/W+9vawllhHyjrXjgHY/TMhK3oZ5Z/40Pxa2Av3f3vHuEOsMckysM rC+PCnA3 =IENe -----END PGP SIGNATURE----- --MGu/vTNewDGZ7tmp--